Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To:     "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        "guohanjun@huawei.com" <guohanjun@huawei.com>
CC:     "lenb@kernel.org" <lenb@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Zheng, Joey" <yu.zheng@hxt-semitech.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "Jiang, Yutang2" <yutang2.jiang@hxt-semitech.com>
Subject: Re: [PATCH v2] ACPI / tables: Add IORT to injectable table list
Thread-Topic: [PATCH v2] ACPI / tables: Add IORT to injectable table list
Thread-Index: AQHTlCPb2ARzJ9BNo0O5jf5uTQ8ff6OLKU8AgAJYFwCAArwzgA==
Date:   Fri, 2 Feb 2018 07:18:28 +0000
Message-ID: <1517555897.3387.6.camel@hxt-semitech.com>
References: <1516695922-15045-1-git-send-email-shunyong.yang@hxt-semitech.com>
         <1517276662.2652.12.camel@hxt-semitech.com>
         <74324d8a-c144-5b21-bea1-9f2e1b891c0f@huawei.com>
In-Reply-To: <74324d8a-c144-5b21-bea1-9f2e1b891c0f@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <230C63D794E8754E876676F6DD99C9BD@hxt-semitech.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Hanjun

On Wed, 2018-01-31 at 21:32 +0800, Hanjun Guo wrote:
> Hi Shunyong,
> 
> On 2018/1/30 9:44, Yang, Shunyong wrote:
> > 
> > Hi,?Rafael
> > 
> > Could you please help to review this patch? This is a small change
> > to
> > add ACPI_SIG_IORT to?table_sigs[].?
> > Loading IORT table from initrd is very useful to debug SMMU
> > node/device
> > probe, MSI allocation, stream id translation and verifying IORT
> > table
> > from firmware. So, I add this.
> It's true, mappings in IORT will be easy getting wrong, so it would
> be
> good to test it without updating the firmware.
> 
> But I think you'd better to add your comment about why you need
> IORT in the commit message in your patch, that will be useful
> to convince Rafael to take your patch.
> 

Thanks for your suggestion. I will add detailed information to commit
message and send out v3 later.

Thanks.
Shunyong.