Received: by 10.223.176.5 with SMTP id f5csp424550wra; Thu, 1 Feb 2018 23:38:45 -0800 (PST) X-Google-Smtp-Source: AH8x227fZ7RU6fo5Rj+Xa2vQc33XXuO8oNPmK8NA9tmIT47zE9MnlidNgVRHk9MyjvQ6QDnyJ/p+ X-Received: by 2002:a17:902:bf01:: with SMTP id bi1-v6mr4720382plb.254.1517557124962; Thu, 01 Feb 2018 23:38:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517557124; cv=none; d=google.com; s=arc-20160816; b=0+YNQj1Bu4iuRMJKhsJuPErnLVIH8HZCss7oK48VgFEqqTaRKjMy1AQxrPh23t9J6r S0V/1HUqifj4OQO2sB5lzX4zl7B/emcHm8pVITNVeAYwfXWISpenazARAApdD0axjm9H uBKfU92IlwvMUTzyg+vgIvaaD+VFufTt7QKbhDgq2QzL2JRgh4Y6qa0TcOAG9WQRrZVh x90C2CNn68x2RugxuHKk7SIJ2R758+OwxQ7Sy9L42zBYsuCJ00/tH35byA7DnF6bh38A MeNdhD1sTvY93yCawplAjbJoFPy4BQAif4zKd9YIc7nR0xt6Rs2XnPDAgRJdT0RN5hSF arJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=xC6Vqhm9RgSjUzk7/+Bm47+Tkjr9QeQXvf7NjDG36pA=; b=vLLAXG57z0nioj9PGc9NmI4lzhELO57QRwuWYlvUnygnfKY2x+gCsGImY9uhpVSHtU /rnNZdEh55iZjVNkcHACx8i0bvXbmImlFv1Hs2v7s7lGW5mZ3bkBQbay6MXmqH2P3TbD hcHPgvym0pJRU9WvJv0945yvtKj9yxFrUtDDihvT30t+di+FIU6G7spBlF3kynR0K5a6 a+hpuMkH/UY9ZEOS9Zvc3kVOqioApZwIp9j/wGgMu8eTPclrKVmXhA3Nw8PN155/pzu/ gJeIbvPcfJxvbHngrnUlBm0ERxWkrrXXhFVt1W1yhAl9Tn4n7hOC5hY/OqDFjj5m497u rzoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z90si1289378pfl.204.2018.02.01.23.38.30; Thu, 01 Feb 2018 23:38:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbeBBHiA (ORCPT + 99 others); Fri, 2 Feb 2018 02:38:00 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:45188 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbeBBHhw (ORCPT ); Fri, 2 Feb 2018 02:37:52 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 6A9A2201B4; Fri, 2 Feb 2018 08:37:51 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iDs5nsL5K34r; Fri, 2 Feb 2018 08:37:50 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id C832C20084; Fri, 2 Feb 2018 08:37:50 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.361.1; Fri, 2 Feb 2018 08:36:47 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 4708431808B0; Fri, 2 Feb 2018 08:37:50 +0100 (CET) Date: Fri, 2 Feb 2018 08:37:50 +0100 From: Steffen Klassert To: Colin King CC: Herbert Xu , "David S . Miller" , Alexey Kuznetsov , "Hideaki YOSHIFUJI" , , , Subject: Re: [PATCH] esp4: remove redundant initialization of pointer esph Message-ID: <20180202073750.t5gcqfp7cv7vdxiu@gauss3.secunet.de> References: <20180130145348.32202-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180130145348.32202-1-colin.king@canonical.com> User-Agent: NeoMutt/20170609 (1.8.3) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 2718E553-53DE-4511-8BCF-B79176403651 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 02:53:48PM +0000, Colin King wrote: > From: Colin Ian King > > Pointer esph is being assigned a value that is never read, esph is > re-assigned and only read inside an if statement, hence the > initialization is redundant and can be removed. > > Cleans up clang warning: > net/ipv4/esp4.c:657:21: warning: Value stored to 'esph' during > its initialization is never read > > Signed-off-by: Colin Ian King I've queued this for ipsec-next, will be applied after the merge window.