Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0238321759
Date:   Fri, 2 Feb 2018 10:36:09 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     William Cohen <wcohen@redhat.com>
Cc:     peterz@infradead.org, mingo@redhat.com,
        linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org
Subject: Re: [PATCH] perf vendor events aarch64: Add JSON metrics for ARM
 Cortex-A53 Processor
Message-ID: <20180202133609.GE4835@kernel.org>
References: <20180131032813.9564-1-wcohen@redhat.com>
 <20180201144309.GA4835@kernel.org>
 <3bebcee1-102c-34ec-880a-722d96062a39@redhat.com>
 <20180201205129.GC4835@kernel.org>
 <c0d905c6-948d-98b1-85ca-5aa8b5090435@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c0d905c6-948d-98b1-85ca-5aa8b5090435@redhat.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Thu, Feb 01, 2018 at 04:52:16PM -0500, William Cohen escreveu:
> On 02/01/2018 03:51 PM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Feb 01, 2018 at 10:12:59AM -0500, William Cohen escreveu:
> >> On 02/01/2018 09:43 AM, Arnaldo Carvalho de Melo wrote:
> >>> Em Tue, Jan 30, 2018 at 10:28:13PM -0500, William Cohen escreveu:
> >>>> Add JSON metrics for ARM Cortex-A53 Processor
> >>>
> >>> Hi Will, would it be possible to you include an URL for the document
> >>> that served as a reference to you to write these files? Did you use some
> >>> script?
> >>
> >> Hi Arnaldo,
> >  
> >> I can certainly add the reference to section "12.9 Events" of the ARM
> >> Cortex -A53 MPCore Processor Revision: r0p4 Technical Reference Manual
> >> to the patch.  That would be useful for people to know where to look
> >> for additional information about the events.
> > 
> 
> Hi Arnaldo,
> 
> The ARM Cortex A53 manual is available at:
> 
> http://infocenter.arm.com/help/topic/com.arm.doc.ddi0500g/DDI0500G_cortex_a53_trm.pdf
 
> It would probably be useful to include that URL in the commit
> information to make it easier for people to look up the information.

Thanks, I'll add that to that cset.

- Arnaldo
 
> -Will
> 
> > I'll take these clarifications and add it to your patch, that I am
> > applying now, please let me know if you have anything else to add and
> > I'll ammend it if I get it before I send it upstream.
> >  
> >> Unlike the Intel processors there isn't a script that automatically
> >> generated these files. The patch was manually generated from the
> >> documentation and the previous oprofile ARM Cortex ac53 event file
> >> patch I made.
> > 
> > Thanks a lot for this extra information,
> > 
> > - Arnaldo
> >