Received: by 10.223.176.5 with SMTP id f5csp1041776wra; Fri, 2 Feb 2018 10:09:26 -0800 (PST) X-Google-Smtp-Source: AH8x227wGP+B9DCZwMPrhYloxKoZH6cQKDVEKqw2bNPPJis7Ot+NVW1C4Vo/N7wklOBQgticCAvP X-Received: by 10.101.101.149 with SMTP id u21mr5441291pgv.251.1517594966441; Fri, 02 Feb 2018 10:09:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517594966; cv=none; d=google.com; s=arc-20160816; b=de1+ZOIGClh1aoeNQvaKJ0kE4w9klcBu6aPi9txxhp3ljR5iBUD1xE/gunqPHMdaEn ESWp1R0khnyTaERNdTWF6Yl+8eUJZ8CiO4PgDQEwHDwzg+4hpPIH2SJy7YZHTzfugaHS XZxWf8kRwx4heOLEm/s9UrD/ychcVRdv2Y64CRkB+z55+Wpw+JEhs7RZYISgXzR/7+cE xM5EBML3TkslaT+JNPZqNpBxHfrDki3OsnDzOMcF1Z6rcY0vY2aEoTg1lHICpFyEzVJR 6E/8YW07mLI72kVsHtDvwhx1+pIIHslU0vAApVSAkdHzoRFRiz97MVE86Lsb0VlAiD7v Edfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=FXLN4rWnrQQ8WxU90GCbTIm89aka5VumaCdUzuwk2vA=; b=DAfCGIQ+nRP/yIGHDShAz+BrhBIrNeALmyesjdmUFnvhChXDSP3TBHUVEm7qsP1V4o 5WjpnAT95b1J8faG9Z/XvZ3OLZnMMVa58Z3Kl0VnAiJXXfmhqpPjQMT1Z/XFrVIwkA25 Mt2l57fh4efjB5tfC/iWCZ8IvrfS/qCOYuu6xIOYpkxKvw+aCPW8v5IoSRPIp5xl+xA4 MsQSHv6uHtcY/7U88FikPciAxSghtM+uQ3vT+QqgyeFxIGxJPugWTEF8+kicuNqbdfd7 ZwYtvghBdaFKioQbY0Rl5YuPGzi1fHu1TkiezJ/J67wBP3f6VZBuNnUt+gB93NWLYuOJ OJOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a67si473556pgc.151.2018.02.02.10.09.11; Fri, 02 Feb 2018 10:09:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754005AbeBBSHA (ORCPT + 99 others); Fri, 2 Feb 2018 13:07:00 -0500 Received: from hermes.aosc.io ([199.195.250.187]:54886 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753874AbeBBSFo (ORCPT ); Fri, 2 Feb 2018 13:05:44 -0500 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id A2AD0568A2; Fri, 2 Feb 2018 18:05:39 +0000 (UTC) From: Icenowy Zheng To: Maxime Ripard , Chen-Yu Tsai , Giuseppe Cavallaro , Corentin Labbe , "David S . Miller" Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Icenowy Zheng Subject: [PATCH 1/3] net: stmmac: dwmac-sun8i: drop V3s compatible and add V3 one Date: Sat, 3 Feb 2018 02:04:54 +0800 Message-Id: <20180202180456.60378-2-icenowy@aosc.io> In-Reply-To: <20180202180456.60378-1-icenowy@aosc.io> References: <20180202180456.60378-1-icenowy@aosc.io> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The V3s is just a differently packaged version of the V3 chip, which has a MAC with the same capability with H3. The V3s just doesn't wire out the external MII/RMII/RGMII bus. (V3 wired out it). Drop the compatible string of V3s in the dwmac-sun8i driver, and add a V3 compatible string, which has all capabilities. Signed-off-by: Icenowy Zheng --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 10 +++++----- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 10 ++++++---- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt index 3d6d5fa0c4d5..158124e8ee71 100644 --- a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt +++ b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt @@ -7,7 +7,7 @@ Required properties: - compatible: must be one of the following string: "allwinner,sun8i-a83t-emac" "allwinner,sun8i-h3-emac" - "allwinner,sun8i-v3s-emac" + "allwinner,sun8i-v3-emac" "allwinner,sun50i-a64-emac" - reg: address and length of the register for the device. - interrupts: interrupt for the device @@ -23,7 +23,7 @@ Required properties: - syscon: A phandle to the syscon of the SoC with one of the following compatible string: - allwinner,sun8i-h3-system-controller - - allwinner,sun8i-v3s-system-controller + - allwinner,sun8i-v3-system-controller - allwinner,sun50i-a64-system-controller - allwinner,sun8i-a83t-system-controller @@ -35,7 +35,7 @@ external PHY. Optional properties for the following compatibles: - "allwinner,sun8i-h3-emac", - - "allwinner,sun8i-v3s-emac": + - "allwinner,sun8i-v3-emac": - allwinner,leds-active-low: EPHY LEDs are active low Required child node of emac: @@ -51,7 +51,7 @@ of the mdio node. See phy.txt for the generic PHY bindings. The following compatibles require that the emac node have a mdio-mux child node called "mdio-mux": - "allwinner,sun8i-h3-emac" - - "allwinner,sun8i-v3s-emac": + - "allwinner,sun8i-v3-emac": Required properties for the mdio-mux node: - compatible = "allwinner,sun8i-h3-mdio-mux" - mdio-parent-bus: a phandle to EMAC mdio @@ -64,7 +64,7 @@ Required properties for the mdio-mux children node: The following compatibles require a PHY node representing the integrated PHY, under the integrated MDIO bus node if an mdio-mux node is used: - "allwinner,sun8i-h3-emac", - - "allwinner,sun8i-v3s-emac": + - "allwinner,sun8i-v3-emac": Additional information regarding generic multiplexer properties can be found at Documentation/devicetree/bindings/net/mdio-mux.txt diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index a3fa65b1ca8e..fd0519cf27b9 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -84,10 +84,12 @@ static const struct emac_variant emac_variant_h3 = { .support_rgmii = true }; -static const struct emac_variant emac_variant_v3s = { +static const struct emac_variant emac_variant_v3 = { .default_syscon_value = 0x38000, .soc_has_internal_phy = true, - .support_mii = true + .support_mii = true, + .support_rmii = true, + .support_rgmii = true }; static const struct emac_variant emac_variant_a83t = { @@ -1074,8 +1076,8 @@ return ret; static const struct of_device_id sun8i_dwmac_match[] = { { .compatible = "allwinner,sun8i-h3-emac", .data = &emac_variant_h3 }, - { .compatible = "allwinner,sun8i-v3s-emac", - .data = &emac_variant_v3s }, + { .compatible = "allwinner,sun8i-v3-emac", + .data = &emac_variant_v3 }, { .compatible = "allwinner,sun8i-a83t-emac", .data = &emac_variant_a83t }, { .compatible = "allwinner,sun50i-a64-emac", -- 2.15.1