Received: by 10.223.176.5 with SMTP id f5csp1135757wra; Fri, 2 Feb 2018 11:49:59 -0800 (PST) X-Google-Smtp-Source: AH8x227rks2uzMKzZB1eAkNO7vMQYrFnYecUixm88niimCIoGrgajsfP/A6AdVp2DEE/Ysu/8tbH X-Received: by 2002:a17:902:24c7:: with SMTP id l7-v6mr35922937plg.268.1517600999410; Fri, 02 Feb 2018 11:49:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517600999; cv=none; d=google.com; s=arc-20160816; b=ZiAOxWC5jUQ0Gxg/FqZKXsciV8tY4kHVwruRiAEO1mO/6+M1QqKClByuKCE5rUqlI7 4AjLfd7vwe9RzihE1g3cNNgJTwk6SvP3Jf5b/qSZsn1pa6c45Cpu0fG+qgCkceNvWepr a26AlkhzBShZQkSHsuzZ/N8IqbmHcZev1vuZBy2MVdUk9h2XwjSPe4x1GsFxoLPUtWAD lrGbh2IKT0VfG4moJizBCyHB0eK0NO7wrN9skfRK5gMzI34+L5/JMIeapEowyIoyuhwX 3vhW88BjaWyqRjmKYeOErXjGixHipviw1cSmWhjaZOAAiQO+K/wRRfJuf8Zg84XvwPQR oAeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=H4HfGXz83ToiSzuACA/3gAEIdtzUC+FZuL/00SHLJhE=; b=r1NRzluuSMF7g2pXAlyZEZAnYiEytu9NxfF/jm2vYQxysJ2oQhDT0NZUyO3Z+8l292 hrckh3nECvcvuB37dhDfiwOrhMLqCWkdXSNKLbOHdEzby75FkxipBCMbB+OOQJRRgDF3 ByDHYlM865SwsZjcN/DLWrmojPK7l9HUSOhS3J1ltkNxcs91BH7P/roB06fLiA6LlSTO bxuhiFYbGbcAL0wkvHwpw/8UAhn82B2GfiwimGvnDyH4V+yVcsZf1voqDI2BW0Lq+tUM Sa35l1VtcMN9TnDBXUhviWS9+Zhb5+88jKFlSn8hA9XtZ5iXdaLg3yO60Y/grJJ2KTiG YcIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v61-v6si2410459plb.16.2018.02.02.11.49.44; Fri, 02 Feb 2018 11:49:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275AbeBBSUm (ORCPT + 99 others); Fri, 2 Feb 2018 13:20:42 -0500 Received: from mga09.intel.com ([134.134.136.24]:12052 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752964AbeBBSU1 (ORCPT ); Fri, 2 Feb 2018 13:20:27 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Feb 2018 10:20:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,450,1511856000"; d="scan'208";a="28354757" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by orsmga001.jf.intel.com with ESMTP; 02 Feb 2018 10:20:24 -0800 Date: Fri, 2 Feb 2018 11:24:13 -0700 From: Keith Busch To: Jianchao Wang Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] nvme-pci: fix the freeze and quiesce for shutdown and reset case Message-ID: <20180202182413.GH24417@localhost.localdomain> References: <1517554849-7802-1-git-send-email-jianchao.w.wang@oracle.com> <1517554849-7802-3-git-send-email-jianchao.w.wang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517554849-7802-3-git-send-email-jianchao.w.wang@oracle.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 02, 2018 at 03:00:45PM +0800, Jianchao Wang wrote: > Currently, request queue will be frozen and quiesced for both reset > and shutdown case. This will trigger ioq requests in RECONNECTING > state which should be avoided to prepare for following patch. > Just freeze request queue for shutdown case and drain all the resudual > entered requests after controller has been shutdown. Freezing is not just for shutdown. It's also used so blk_mq_update_nr_hw_queues will work if the queue count changes across resets.