Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180201231313.28458-1-jschoenh@amazon.de>
References: <20180201231313.28458-1-jschoenh@amazon.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 2 Feb 2018 22:50:20 +0200
Message-ID: <CAHp75Vf--xVkNoEaNRntzygQYHorbNQYhSCDVcxyLAz2PHEWEQ@mail.gmail.com>
Subject: Re: [PATCH] x86: e820: Implement a range manipulation operator
To:     =?UTF-8?Q?Jan_H=2E_Sch=C3=B6nherr?= <jschoenh@amazon.de>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 2, 2018 at 1:13 AM, Jan H. Sch=C3=B6nherr <jschoenh@amazon.de> =
wrote:

> +                       [KNL,ACPI] Convert memory within the specified re=
gion
> +                       from <oldtype> to <newtype>. If "-<oldtype>" is l=
eft
> +                       out, the whole region will be marked as <newtype>=
,
> +                       even if previously unavailable. If "+<newtype>" i=
s left
> +                       out, matching memory will be removed. Types are
> +                       specified as e820 types, eg, 1=3D=3DRAM, 2=3D=3Dr=
eserved,
> +                       3=3D=3DACPI, 12=3D=3DPRAM.

s/=3D=3D/ =3D /g


> +       } else if (*p =3D=3D '%') {
> +               enum e820_type from =3D 0, to =3D 0;
> +
> +               start_at =3D memparse(p + 1, &p);
> +               if (*p =3D=3D '-')
> +                       from =3D simple_strtoull(p + 1, &p, 0);
> +               if (*p =3D=3D '+')
> +                       to =3D simple_strtoull(p + 1, &p, 0);
> +               if (*p !=3D 0)

if (*p)

or

if (*p !=3D '\0')

?

> +                       return -EINVAL;
> +               if (from && to)
> +                       e820__range_update(start_at, mem_size, from, to);
> +               else if (to)
> +                       e820__range_add(start_at, mem_size, to);
> +               else if (from)
> +                       e820__range_remove(start_at, mem_size, from, 1);
> +               else
> +                       e820__range_remove(start_at, mem_size, 0, 0);

--=20
With Best Regards,
Andy Shevchenko