Received: by 10.223.176.5 with SMTP id f5csp324320wra; Sat, 3 Feb 2018 00:01:23 -0800 (PST) X-Google-Smtp-Source: AH8x2256etc3qb68WnX27x42QbXmUAdX6ohTNHmAotvLnzrL5tm8espYYNu9bqrvFxcKZoo5psWI X-Received: by 10.99.42.9 with SMTP id q9mr23568950pgq.325.1517644883608; Sat, 03 Feb 2018 00:01:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517644883; cv=none; d=google.com; s=arc-20160816; b=qN2Uiv3rhIZ9JbzPebMxlXMuVg7OX/IIR9LpyzxjLm1+L+0b0w4oSsaQTda7Y2nCXn cKZax9BzAg3wfP5rK+vuHwfhxO4V3VsSlG5hQdlAZP5XBY4KClkoaQfiku9vvguKt2Tm ZJC/FCIlO6b5cxce54UUqlOTh8UYvlGVxDDBfeF3D6DV6Puz3lEl5a+cccisA7j3LiCC AVb/mxPBkIkq57Yd9Sb3+h5WOB9DEuof5G3Dk6if22yCyTK+X/WGD6zNIwXg9HavXh5i asbhyFRP5buCS64AkthodIvpznx/+BTsdmQTGxrqU6vNvtK+JIPm5NM22ozciF4B4kr/ gdlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=4Q9WTdK5uVjIFJlO30Yhz+rrGNtvG0hMNN3f8v4wdUc=; b=GWEjhKHo1lksDD94P8mAJgnTWyTG3OM0jBN9PtHXmlmaSuPsMkS/CU3MFqrlu2kIL+ 0kktnqpjrqRQi7/V4GZc2a90iiAc9DHI5pFNohBFcTnoXWuoiqpjl/ucHlYWAZpypf3a 6vQrbaw2YQHFiFMXuQqSWrtVql1yIXIlQjt5RyEq6ZOSHTG4HOCB+uvo3WZP7QYQLDd6 JNfPlxXiqVZJhaGmwWnLsoZ5sKTnRXqgDwj+shGMSz2gcptdtEIcrXQ7ZL860x407xMQ B5SGW1Je3Au/5UQr6/GwfEOobw6vrhXXZyyc75VkmppAYyKHxJLrLHXEIxV/dWPHBXnS HHJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Cdu8AHqC; dkim=pass header.i=@codeaurora.org header.s=default header.b=Cdu8AHqC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si1315134plb.472.2018.02.03.00.01.08; Sat, 03 Feb 2018 00:01:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Cdu8AHqC; dkim=pass header.i=@codeaurora.org header.s=default header.b=Cdu8AHqC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbeBCIAM (ORCPT + 99 others); Sat, 3 Feb 2018 03:00:12 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35634 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbeBCH6z (ORCPT ); Sat, 3 Feb 2018 02:58:55 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 43E01608BF; Sat, 3 Feb 2018 07:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517644731; bh=3bRtgW/1UGLSHkCpuK0MvWwju03sHmRucFoxDy+Zr7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cdu8AHqCIY7qQbWd2ZS4eB9E+po8NKJ+9IDMCDvVAs0IfkckPc59wlM/J/QtjEEFI d0tlzT3wWy9g3j73CU92Nq3CrsO32l1Q0dOZqMjrcdJB6qLcXaM1J24bDCpnbAslwY jt1i53F3cTiufw0NyMMO43NZT1iCax1lBzRl8zIw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: absahu@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 795246079C; Sat, 3 Feb 2018 07:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517644731; bh=3bRtgW/1UGLSHkCpuK0MvWwju03sHmRucFoxDy+Zr7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cdu8AHqCIY7qQbWd2ZS4eB9E+po8NKJ+9IDMCDvVAs0IfkckPc59wlM/J/QtjEEFI d0tlzT3wWy9g3j73CU92Nq3CrsO32l1Q0dOZqMjrcdJB6qLcXaM1J24bDCpnbAslwY jt1i53F3cTiufw0NyMMO43NZT1iCax1lBzRl8zIw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 795246079C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=absahu@codeaurora.org From: Abhishek Sahu To: Andy Gross , Wolfram Sang Cc: David Brown , Sricharan R , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Abhishek Sahu Subject: [PATCH 07/12] i2c: qup: use the complete transfer length to choose DMA mode Date: Sat, 3 Feb 2018 13:28:12 +0530 Message-Id: <1517644697-30806-8-git-send-email-absahu@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> References: <1517644697-30806-1-git-send-email-absahu@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently each message length in complete transfer is being checked for determining DMA mode and if any of the message length is less than FIFO length then non DMA mode is being used which will increase overhead. DMA can be used for any length and it should be determined with complete transfer length. Now, this patch introduces DMA threshold length and the transfer will be done in DMA mode if the total length is greater than this threshold length. Signed-off-by: Abhishek Sahu --- drivers/i2c/busses/i2c-qup.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 6227a5c..a91fc70 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -192,6 +192,8 @@ struct qup_i2c_dev { bool is_dma; /* To check if the current transfer is using DMA */ bool use_dma; + /* The threshold length above which DMA will be used */ + unsigned int dma_threshold; struct dma_pool *dpool; struct qup_i2c_tag start_tag; struct qup_i2c_bam brx; @@ -1294,7 +1296,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap, int num) { struct qup_i2c_dev *qup = i2c_get_adapdata(adap); - int ret, len, idx = 0; + int ret, idx = 0; + unsigned int total_len = 0; qup->bus_err = 0; qup->qup_err = 0; @@ -1320,14 +1323,13 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap, goto out; } - len = (msgs[idx].len > qup->out_fifo_sz) || - (msgs[idx].len > qup->in_fifo_sz); - - if (is_vmalloc_addr(msgs[idx].buf) || !len) + if (is_vmalloc_addr(msgs[idx].buf)) break; + + total_len += msgs[idx].len; } - if (idx == num) + if (idx == num && total_len > qup->dma_threshold) qup->use_dma = true; } @@ -1587,6 +1589,7 @@ static int qup_i2c_probe(struct platform_device *pdev) size = QUP_INPUT_FIFO_SIZE(io_mode); qup->in_fifo_sz = qup->in_blk_sz * (2 << size); + qup->dma_threshold = min(qup->out_fifo_sz, qup->in_fifo_sz); fs_div = ((src_clk_freq / clk_freq) / 2) - 3; hs_div = 3; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation