Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69D6221785
Date:   Sat, 3 Feb 2018 22:21:28 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Nicolas Pitre <nico@linaro.org>,
        Andi Kleen <ak@linux.intel.com>, linux-kernel@vger.kernel.org,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Josef Bacik <jbacik@fb.com>,
        Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH 3/3] x86: error_inject: make  just_return_func globally
 visible
Message-Id: <20180203222128.c551eb3e12bd38d3341ce3de@kernel.org>
In-Reply-To: <20180202145634.200291-3-arnd@arndb.de>
References: <20180202145434.100626-1-arnd@arndb.de>
        <20180202145634.200291-1-arnd@arndb.de>
        <20180202145634.200291-3-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri,  2 Feb 2018 15:56:19 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> With link time optimizations enabled, I get a link failure:
> 
> ./ccLbOEHX.ltrans19.ltrans.o: In function `override_function_with_return':
> <artificial>:(.text+0x7f3): undefined reference to `just_return_func'
> 
> Marking the symbol .globl makes it work as expected.

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> 
> Fixes: 540adea3809f ("error-injection: Separate error-injection from kprobe")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/x86/lib/error-inject.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/lib/error-inject.c b/arch/x86/lib/error-inject.c
> index 7b881d03d0dd..3cdf06128d13 100644
> --- a/arch/x86/lib/error-inject.c
> +++ b/arch/x86/lib/error-inject.c
> @@ -7,6 +7,7 @@ asmlinkage void just_return_func(void);
>  
>  asm(
>  	".type just_return_func, @function\n"
> +	".globl just_return_func\n"
>  	"just_return_func:\n"
>  	"	ret\n"
>  	".size just_return_func, .-just_return_func\n"
> -- 
> 2.9.0
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>