Received: by 10.223.176.5 with SMTP id f5csp687024wra; Sat, 3 Feb 2018 08:07:11 -0800 (PST) X-Google-Smtp-Source: AH8x224SycbqtEOYaPLto0Rgnwgjs7Dl1KNMjhtPRDMchxIlowdIriRuqBI4BFBMGwEnbhZD3I65 X-Received: by 2002:a17:902:261:: with SMTP id 88-v6mr39871225plc.384.1517674031516; Sat, 03 Feb 2018 08:07:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517674031; cv=none; d=google.com; s=arc-20160816; b=p/3kjz73RsHRpKwI6UALlHGa8RDXppVyNdVuCMrgy+5Y+VAomQRlnHcMD6sFrhoIF/ up5IU5MePZJY7Ni0cqi23LI+Nj4bLRrZ4+wthx7bDiFeVyfe3XiBvHJHjqbkDw47CRo1 lnRQV+9Zj85XcnBc8H9ryi47wlaL01i3PHkre841pmzesDShDAa4Sr4mmtHW1YmlHjUp feQpIqkTu0+etA6lhHxWE0xe4UjrbMzXepyLUySvvoMlxt0Mqsf6r+K98oCWUvJst8u/ 5nZCSDt8PPFr4jv9J5t7k3zKagCAqY3XDCwAMep5ImW7zCB4u6i6zbooY7sdPUu1lfnz H7kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:to:from:arc-authentication-results; bh=kMQC9Ybv7/zqi1y5+QbplSV0zuy9Vvl3IM/z9pjXjjo=; b=t4slUUCcok6PqmdlO4eRzzSEyK5jRRJgg6f55p72ie0IFPM2xkk8WQ95bM7e/Vxl2s OhIYMHAC0/OnPhfjWyCO7m6YTItJ/TIL/f6rebCCztb4D5o8E5t8v+qViUo99qsH7IGY INAOU09CK2v6Cr0wIKG6Kc0YgcL5gam9PeaTX3GFyIakL3285a7ZDiSxRCP+947HpJAa qVC+GJZ0uhi8IjWifYN5frg/uQvhiEkhqwNTp49vK2vRXkIWTnqL1oizZCTiFL//PA3T 4GkkjK7cwQUgfkbZBRZQFa6G9VEk49Ck97Hl+SDhzfG6wTjGD9EcqOjXHOkH/fXfE4il f+FQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t64si3116664pgc.294.2018.02.03.08.06.55; Sat, 03 Feb 2018 08:07:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbeBCP5c (ORCPT + 99 others); Sat, 3 Feb 2018 10:57:32 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:53503 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbeBCP5Z (ORCPT ); Sat, 3 Feb 2018 10:57:25 -0500 Received: from [222.129.50.137] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1ei0Bt-0003L1-8v; Sat, 03 Feb 2018 15:57:21 +0000 From: Aaron Ma To: aaron.ma@canonical.com, jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: Fix hid_report_len usage Date: Sat, 3 Feb 2018 23:57:15 +0800 Message-Id: <20180203155715.2970-1-aaron.ma@canonical.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180108024141.10590-2-aaron.ma@canonical.com> References: <20180108024141.10590-2-aaron.ma@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Follow the change of return type u32 of hid_report_len, fix all the types of variables those get the return value of hid_report_len to u32, and all other code already uses u32. Cc: stable@vger.kernel.org Signed-off-by: Aaron Ma --- drivers/hid/hid-input.c | 3 ++- drivers/hid/hid-multitouch.c | 5 +++-- drivers/hid/hid-rmi.c | 4 ++-- drivers/hid/wacom_sys.c | 4 ++-- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 04d01b57d94c..d86398755b0d 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1368,7 +1368,8 @@ static void hidinput_led_worker(struct work_struct *work) led_work); struct hid_field *field; struct hid_report *report; - int len, ret; + int ret; + u32 len; __u8 *buf; field = hidinput_get_led_field(hid); diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 3b4739bde05d..2e1736ba2444 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -370,7 +370,8 @@ static const struct attribute_group mt_attribute_group = { static void mt_get_feature(struct hid_device *hdev, struct hid_report *report) { struct mt_device *td = hid_get_drvdata(hdev); - int ret, size = hid_report_len(report); + int ret; + u32 size = hid_report_len(report); u8 *buf; /* @@ -1183,7 +1184,7 @@ static void mt_set_input_mode(struct hid_device *hdev) struct hid_report_enum *re; struct mt_class *cls = &td->mtclass; char *buf; - int report_len; + u32 report_len; if (td->inputmode < 0) return; diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index c6c05df3e8d2..9c9362149641 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -89,8 +89,8 @@ struct rmi_data { u8 *writeReport; u8 *readReport; - int input_report_size; - int output_report_size; + u32 input_report_size; + u32 output_report_size; unsigned long flags; diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 409543160af7..b54ef1ffcbec 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -219,7 +219,7 @@ static void wacom_feature_mapping(struct hid_device *hdev, unsigned int equivalent_usage = wacom_equivalent_usage(usage->hid); u8 *data; int ret; - int n; + u32 n; switch (equivalent_usage) { case HID_DG_CONTACTMAX: @@ -519,7 +519,7 @@ static int wacom_set_device_mode(struct hid_device *hdev, u8 *rep_data; struct hid_report *r; struct hid_report_enum *re; - int length; + u32 length; int error = -ENOMEM, limit = 0; if (wacom_wac->mode_report < 0) -- 2.14.3