Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 3 Feb 2018 11:17:01 -0800
From:   Stephen Hemminger <stephen@networkplumber.org>
To:     Christian Brauner <christian.brauner@ubuntu.com>
Cc:     netdev@vger.kernel.org, ebiederm@xmission.com, jbenc@redhat.com,
        nicolas.dichtel@6wind.com, linux-kernel@vger.kernel.org,
        dsahern@gmail.com, davem@davemloft.net
Subject: Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier
Message-ID: <20180203111701.2ff8d7a3@xeon-e3>
In-Reply-To: <20180203132904.11972-2-christian.brauner@ubuntu.com>
References: <20180203132904.11972-1-christian.brauner@ubuntu.com>
        <20180203132904.11972-2-christian.brauner@ubuntu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat,  3 Feb 2018 14:29:04 +0100
Christian Brauner <christian.brauner@ubuntu.com> wrote:

> +static int rtnl_ensure_unique_netns_attr(const struct sock *sk,
> +					 struct nlattr *tb[],
> +					 struct netlink_ext_ack *extack)
> +{
> +	int ret = -EINVAL;
> +	struct net *net = NULL, *unique_net = NULL;
> +
> +	/* Requests without network namespace ids have been able to specify
> +	 * multiple properties referring to different network namespaces so
> +	 * don't regress them.
> +	 */
> +	if (!tb[IFLA_IF_NETNSID])
> +		return 0;
> +
> +	if (!tb[IFLA_NET_NS_PID] && !tb[IFLA_NET_NS_FD])
> +		return 0;

Isn't this an error?

> +
> +	unique_net = get_net_ns_by_id(sock_net(sk), nla_get_s32(tb[IFLA_IF_NETNSID]));
> +	if (!unique_net)
> +		return -1;

Other paths are returning errno, so why -1 here?