Received: by 10.223.176.5 with SMTP id f5csp1441059wra; Sun, 4 Feb 2018 04:12:50 -0800 (PST) X-Google-Smtp-Source: AH8x225/zXY6GTWVrIZJ38TG5fuAog0E/OPhzb8bURCkffm7SjTu8/ePPaYar9A8t9KmnJDyZhj0 X-Received: by 10.99.113.7 with SMTP id m7mr31270183pgc.403.1517746370780; Sun, 04 Feb 2018 04:12:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517746370; cv=none; d=google.com; s=arc-20160816; b=Bn55ZxZBib5TrWBimbGF8ge1k+ttOqsuL/0+MsTFB8O6ONF//tTR30CUds9tOVDStg Qr8vjqyUmHamWAycq71AHH58cz5P5iVR1JfZ82UQmAZhNZa3mtGosFFUp5bf2d7nxgoF /hpqOjcI724L+qY3zG6v83W/4ech00IYrSA9CD78NolI/+EJ9lWkWsJOeProCfFhEtna Kg+gqdsdahnayLy0rj1EktHkK6yTx9GDpfIQQfvZjah2wIGOtSoImLUHpJlLtAWKo7Fk pAbKprVJnSBlGdrIcATUB8fIAkw8v3Yxp5cd1J7g5ukJ/+XBV95P44Gugr8hhbXX4NQB JCdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ETvBubU+lCvxn1TQ3Zi9zns0pXHE/CC47ilOJZ65HvI=; b=o5GnUcxQ9SPJpXt6DAkRYa8+NAL6drpbpZNXUP0JrXCIf+2x1mw11NH97cQg53fsND znv1QuWXi/Qd/rOiqQQq2SDhnUqlBKoPfp2koTlZLqlggXJes2d6VPgydLcxLEke1tw7 f+DT7bqDy95on3cFM5LNViv/lRggg11MZefLNa6C7+Y9yU8k6E9Jugh0OgnXpiMM+4YB a/N+pM3Rp2qsZE2iGxDdcJv8nA9fluau+ZL2Wbzbds3CtA1Ea8ORKx1TDAphm4UGGlzQ 9XsphbqGsY9iibzIhjnDCBchbpbqKP1+fN9Da88mHKcuczgoWmZBL9O8VlfVxA4uJgKC 6iHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si4184695pgp.5.2018.02.04.04.12.36; Sun, 04 Feb 2018 04:12:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbeBDMLQ (ORCPT + 99 others); Sun, 4 Feb 2018 07:11:16 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:34018 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbeBDMLK (ORCPT ); Sun, 4 Feb 2018 07:11:10 -0500 Received: from mail-wr0-f200.google.com ([209.85.128.200]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1eiJ8X-0004ie-P0 for linux-kernel@vger.kernel.org; Sun, 04 Feb 2018 12:11:09 +0000 Received: by mail-wr0-f200.google.com with SMTP id h13so3325959wrc.9 for ; Sun, 04 Feb 2018 04:11:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ETvBubU+lCvxn1TQ3Zi9zns0pXHE/CC47ilOJZ65HvI=; b=LUZdEeYA8xxEtijbcOM9epa4jCWWeJYFvzQu5RQzo6uVbIjtq+EIa/psytKtSB1tg8 x5nPuJEj9PvMCUGUqrR4FdyEewo2Ejv29h8jGP8QAUdlDKu26kzoB5EzxsP6ODZM4vyw Zqy9kAY3TrHq24TpG4JCRqP22eraMUPD0yZN/kRXnu2BtFLIrSflvA5pRHctp9uOarTn 8u2gdoLeHCZe0oj9s6v10VtGTILs41DmoFDTCDBzeoTWXS1rSQSFYhMuZI38/V1lGTpM LEMMwRS9g1irGfMqOaCiu9wrpL/mwbQve763nYJozaZw6P/vNx/XeRHXDEvacVnXE70T PnLw== X-Gm-Message-State: AKwxytcnB/iJmbrf7zHIV+41JXnSXGtjtrdZslUQJX35jKky/Q2k6jWH K4Yxy2w4OJDQPti8gnpx9KpuodgVSepuNriQMAdyLDRTeenhO6NApgUamkEXLzHFVz/eCpRy7o7 OcsJkTJf09xykCPvJrkVBLEIRUDJWfkZMPIaUrq0D5A== X-Received: by 10.80.224.195 with SMTP id j3mr73379367edl.50.1517746269524; Sun, 04 Feb 2018 04:11:09 -0800 (PST) X-Received: by 10.80.224.195 with SMTP id j3mr73379345edl.50.1517746269305; Sun, 04 Feb 2018 04:11:09 -0800 (PST) Received: from gmail.com ([2001:67c:1810:f051:f817:224e:7728:4274]) by smtp.gmail.com with ESMTPSA id n2sm5607384edl.74.2018.02.04.04.11.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Feb 2018 04:11:08 -0800 (PST) Date: Sun, 4 Feb 2018 13:11:02 +0100 From: Christian Brauner To: Stephen Hemminger Cc: Christian Brauner , netdev@vger.kernel.org, ebiederm@xmission.com, jbenc@redhat.com, nicolas.dichtel@6wind.com, linux-kernel@vger.kernel.org, dsahern@gmail.com, davem@davemloft.net Subject: Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier Message-ID: <20180204121100.GA1344@gmail.com> References: <20180203132904.11972-1-christian.brauner@ubuntu.com> <20180203132904.11972-2-christian.brauner@ubuntu.com> <20180203111701.2ff8d7a3@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180203111701.2ff8d7a3@xeon-e3> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 03, 2018 at 11:17:01AM -0800, Stephen Hemminger wrote: > On Sat, 3 Feb 2018 14:29:04 +0100 > Christian Brauner wrote: > > > +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, > > + struct nlattr *tb[], > > + struct netlink_ext_ack *extack) > > +{ > > + int ret = -EINVAL; > > + struct net *net = NULL, *unique_net = NULL; > > + > > + /* Requests without network namespace ids have been able to specify > > + * multiple properties referring to different network namespaces so > > + * don't regress them. > > + */ > > + if (!tb[IFLA_IF_NETNSID]) > > + return 0; > > + > > + if (!tb[IFLA_NET_NS_PID] && !tb[IFLA_NET_NS_FD]) > > + return 0; > > Isn't this an error? My reasoning was that having no explicit network namespace identifying attributes the caller operates on the current network namespace which is uniquely identified. > > > + > > + unique_net = get_net_ns_by_id(sock_net(sk), nla_get_s32(tb[IFLA_IF_NETNSID])); > > + if (!unique_net) > > + return -1; > > Other paths are returning errno, so why -1 here? Yes, this should be -EINVAL as well. Thanks! Christian