Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Stanislav Nijnikov <Stanislav.Nijnikov@wdc.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        Alex Lemberg <Alex.Lemberg@wdc.com>
Subject: RE: [PATCH v4 01/10] ufs: sysfs: attribute group for existing sysfs
 entries.
Thread-Topic: [PATCH v4 01/10] ufs: sysfs: attribute group for existing sysfs
 entries.
Thread-Index: AQHTm3fxo1n5KlULckmz1QORVYth36OPxRSAgARmIJCAAAalgIAABxiA
Date:   Sun, 4 Feb 2018 13:09:09 +0000
Message-ID: <DM2PR0401MB0975383CF11F3932BB5DA77E9AFF0@DM2PR0401MB0975.namprd04.prod.outlook.com>
References: <1517501746-19075-1-git-send-email-stanislav.nijnikov@wdc.com>
 <1517501746-19075-2-git-send-email-stanislav.nijnikov@wdc.com>
 <20180201165923.GA12838@kroah.com>
 <DM2PR0401MB097509D74E03449B0FA616249AFF0@DM2PR0401MB0975.namprd04.prod.outlook.com>
 <20180204123343.GA940@kroah.com>
In-Reply-To: <20180204123343.GA940@kroah.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 95c33611-3d75-45ce-b67b-08d56bd07ab7
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2018 13:09:09.5272
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0401MB1391
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Sunday, February 4, 2018 2:34 PM
> To: Stanislav Nijnikov <Stanislav.Nijnikov@wdc.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
> jaegeuk@kernel.org; Alex Lemberg <Alex.Lemberg@wdc.com>
> Subject: Re: [PATCH v4 01/10] ufs: sysfs: attribute group for existing sy=
sfs
> entries.
>=20
> On Sun, Feb 04, 2018 at 12:29:06PM +0000, Stanislav Nijnikov wrote:
> > > > +	curr_len +=3D snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
> > > > +			     "\nAll available Runtime PM levels info:\n");
> > > > +	for (lvl =3D UFS_PM_LVL_0; lvl < UFS_PM_LVL_MAX; lvl++)
> > > > +		curr_len +=3D snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
> > > > +				     "\tRuntime PM level [%d] =3D> dev_state
> > > [%s] link_state [%s]\n",
> > > > +				    lvl,
> > > > +				    ufschd_ufs_dev_pwr_mode_to_string(
> > > > +					ufs_pm_lvl_states[lvl].dev_state),
> > > > +				    ufschd_uic_link_state_to_string(
> > > > +					ufs_pm_lvl_states[lvl].link_state));
> > > > +
> > >
> > > sysfs if "one value per file", not "random text that someone has to
> > > parse per file" please.
> > >
> > > Huge hint, if you ever care about checking the size of the sysfs
> > > buffer you are writing into, you are doing something really really wr=
ong.
> > >
> > Hi Greg
> > It's the existing code, added by:
> > commit 09690d5a6ae1b7e4cb5ac429c311b99d09352c12
> > Author: subhashj@codeaurora.org <subhashj@codeaurora.org>
> > Date:   Thu Dec 22 18:41:00 2016 -0800
> >
> >     scsi: ufs: provide sysfs attribute to select the PM level
> >
> >     This patch provides the sysfs attribute to choose the power managem=
ent
> >     level for UFS runtime and system suspend.
> >
> >     Reviewed-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
> >     Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
> >     Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> >
> > I just moved it to an another file and changed the sysfs entries
> > creation by Jaegeuk Kim' request. At the moment the entry shows the PM
> > level, the device state, the link state and all possible PM levels. Do =
you
> want me to change it?
>=20
> Ah, you are just moving this code around.  Ok, that's fine for this patch=
, but
> please fix it up as part of this patch series because this isn't an accep=
table
> sysfs file at all.  If it were documented that would be a lot more obviou=
s as to
> just how wrong it was :(
>=20
> And, as it wasn't documented, you can change it as it's obvious no one us=
ed it
> :)
>=20
> thanks,
>=20
> greg k-h
=20
Can I fix these entries not in this patchset? As long as I know they are us=
ed and I
would prefer that change of the existing sysfs entries behavior be related =
to a
separate patch.

Regards.
Stanislav.