Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Subject: Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards
From:   Kai Heng Feng <kai.heng.feng@canonical.com>
In-Reply-To: <1517586717-6209-1-git-send-email-jackstocker.93@gmail.com>
Date:   Sun, 4 Feb 2018 21:35:42 +0800
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Seth Forshee <seth.forshee@canonical.com>,
        Stefan Bader <stefan.bader@canonical.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Devin Heitmueller <dheitmueller@kernellabs.com>,
        Sandeep Singh <sandeep.singh@amd.com>,
        Dmitry Fleytman <dmitry@daynix.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <14038CE4-3754-426C-AC53-0AFE58D095A3@canonical.com>
References: <1517586717-6209-1-git-send-email-jackstocker.93@gmail.com>
To:     JackStocker <jackstocker.93@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 2 Feb 2018, at 11:51 PM, JackStocker <jackstocker.93@gmail.com> wrote:
> 
> From: Jack Stocker <jackstocker.93@gmail.com>
> 
> Following on from this patch: https://lkml.org/lkml/2017/11/3/516,
> Corsair K70 RGB keyboards also require the DELAY_INIT quirk to
> start correctly at boot.
> 
> Device ids found here:
> usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13
> usb 3-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-3: Product: Corsair K70 RGB Gaming Keyboard 
> 
> Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a6aaf2f..9eb92dc 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -221,6 +221,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> 	/* Corsair Strafe RGB */
> 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT },
> 
> +	/* Corsair K70 RGB */
> +	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +

I think this change should move up, to make the table follows an ascending order.

> 	/* MIDI keyboard WORLDE MINI */
> 	{ USB_DEVICE(0x1c75, 0x0204), .driver_info =
> 			USB_QUIRK_CONFIG_INTF_STRINGS },
> -- 
> 2.7.4
>