Received: by 10.223.176.5 with SMTP id f5csp1673873wra; Sun, 4 Feb 2018 09:22:36 -0800 (PST) X-Google-Smtp-Source: AH8x227EPgqswxsi2ks5yYG3OQ2yh/ceF2w2stdVp2pTqoYlb/TakqNZ727gYn17lImO/Q8stvzE X-Received: by 10.99.113.11 with SMTP id m11mr8031429pgc.57.1517764956467; Sun, 04 Feb 2018 09:22:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517764956; cv=none; d=google.com; s=arc-20160816; b=CoBtGT5YQWhyd5wdKrJHzr2ZbNhm6YzGxCsxFizfQgwQ5dSKqvm92S8cTRBR8oFa// p8Y77fcmvtfVSCER8PR/pQXBwwRGetMytpcyT8C1LfNajbQ7lFQghVAsmTiQfwuBJKeC YvQnrTzqLvKCUdnhfJAenu2Yq8i+X0SHenU9pyFs6cr2wW32f9lr355CfaTOTFIYnlg8 e6MOX2LwF4xe2fyuwEkU7r1/Wqe9GBYaR0SxPv+f0slCn49ktCL+Bkng/DrsbqTPo1c0 JwHLC8MC964QVlwXpW/lUjvn29amlJc/d2/mL8Sfk5w/IbuyGCYWqRXouqsm9XuuIu+U 9v+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=Vf9lfxrSa85yrJPes5TfeQxtqSHdPJae7ggZOL7r7Jk=; b=Ugh1ENyNe4WGx1eLD0Ust3YhLz4+gGC3guqOHojGLLtiAZ7k31sQj9Ub1cTXmmGc5R 557BtX4PSYKrJvBleZqHsZLZOncFqbvIrByoCKSGZER8e0RwmRV5E1PQ1U8geZZnF5Fy osxBzKdIgT8oP3rHsNAVu5tgWg1obQMiyEY/GwVtKZnP+93hctsuqWVRLYyfblBckB5H t2b3dgTVihTT8hzjXIbmiaxuqX68gvOsmwxtGKsMyc46+pwZbXheCLcR6XuwYr4Nu2sX RLUuNCBbzZClzsbsBPlmTWuygJPxTn9lIL2YqtzlC0md/DbY6zpWTD5v3SZZmq0/1awY j/yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L9tb0jt4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o21si1279982pfj.203.2018.02.04.09.22.22; Sun, 04 Feb 2018 09:22:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L9tb0jt4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbeBDRVd (ORCPT + 99 others); Sun, 4 Feb 2018 12:21:33 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:34776 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbeBDRVX (ORCPT ); Sun, 4 Feb 2018 12:21:23 -0500 Received: by mail-io0-f196.google.com with SMTP id c17so27891348iod.1; Sun, 04 Feb 2018 09:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Vf9lfxrSa85yrJPes5TfeQxtqSHdPJae7ggZOL7r7Jk=; b=L9tb0jt4o99ncy8woaeymg625BoMqCoX8iBJJA//WEJ0NLjNe3vT8WaTza+Cnz0DVm EIBLMXf5Jwbq9CR0QzRAIZdLRuqOAAutIgp9a/M4THYZ8uxkpJiDJEq5tCqvRjBeEZqF XnZ7j7/tNkwNnJkXe6ljZgSZjmAnqZSjvdbA1bUnrRuHpqZf4lg1x0AWJ6GKcbgDVmwx pb8HQpH6+ToDJERB8R0aQfD3TfPjpTKz5nAXyRUpXMLaypBiEcJIBW+hDyGL1yOLu7Q+ /YvtWgjnJlqfdXD1npHLX48cEFniSgEgo2p5yhHIwaEsKZutGSaxq9UgqLe+p+fD2mYM j5uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vf9lfxrSa85yrJPes5TfeQxtqSHdPJae7ggZOL7r7Jk=; b=U/5A3jJq0KlQC90Gdq6fiOg9Nj2Myo4p0guTySisu14F5iryO860NzOND95BA/a3uf BAfe5Ww4ZgKH7YmMi43cmK7SAIc8KyUfqnMbMDYzFx3/XwlP9tNGfeDT1lNtOa5njdgI 3lLlCNycbjUjT5yPDrXDCICXI9fzW4pk6HFlf1y260cP1Asm90/nuV/KnPTrJ6f6t5gT RPn7aJZM6vVWhm2LRDScojMP4X+IpYCsHf3bPye484na3aFsTt3uCoDUYuqXizPK5InB kkVRsahubbRjEI4cS1F2XwqsbRmTb7QgcXLjOqmpdWxTBPtwC/+dZMi2DukRgPQZOdfK oUaA== X-Gm-Message-State: AKwxytd1aPvz2hpNw/A7OSEJ4t43R/UOlUIjj3K48rvmX0tH9FMdVNet J0sI4nTWMzAjfKAMfIwffm8= X-Received: by 10.107.222.17 with SMTP id v17mr37588653iog.274.1517764882644; Sun, 04 Feb 2018 09:21:22 -0800 (PST) Received: from dsa-mb.local ([2601:284:8202:1f70:cc21:745d:5abd:ae63]) by smtp.googlemail.com with ESMTPSA id m5sm1910776iti.3.2018.02.04.09.21.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Feb 2018 09:21:21 -0800 (PST) Subject: Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier To: Christian Brauner , Stephen Hemminger Cc: Christian Brauner , netdev@vger.kernel.org, ebiederm@xmission.com, jbenc@redhat.com, nicolas.dichtel@6wind.com, linux-kernel@vger.kernel.org, davem@davemloft.net References: <20180203132904.11972-1-christian.brauner@ubuntu.com> <20180203132904.11972-2-christian.brauner@ubuntu.com> <20180203111701.2ff8d7a3@xeon-e3> <20180204121100.GA1344@gmail.com> From: David Ahern Message-ID: <3b619bb9-f6cb-6ca9-955b-01c87132c389@gmail.com> Date: Sun, 4 Feb 2018 10:21:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180204121100.GA1344@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/4/18 5:11 AM, Christian Brauner wrote: > On Sat, Feb 03, 2018 at 11:17:01AM -0800, Stephen Hemminger wrote: >> On Sat, 3 Feb 2018 14:29:04 +0100 >> Christian Brauner wrote: >> >>> +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, >>> + struct nlattr *tb[], >>> + struct netlink_ext_ack *extack) >>> +{ >>> + int ret = -EINVAL; >>> + struct net *net = NULL, *unique_net = NULL; >>> + >>> + /* Requests without network namespace ids have been able to specify >>> + * multiple properties referring to different network namespaces so >>> + * don't regress them. >>> + */ >>> + if (!tb[IFLA_IF_NETNSID]) >>> + return 0; >>> + >>> + if (!tb[IFLA_NET_NS_PID] && !tb[IFLA_NET_NS_FD]) >>> + return 0; >> >> Isn't this an error? > > My reasoning was that having no explicit network namespace identifying > attributes the caller operates on the current network namespace which is > uniquely identified. agreed. those are not required attributes.