Received: by 10.223.176.5 with SMTP id f5csp1990770wra; Sun, 4 Feb 2018 17:36:15 -0800 (PST) X-Google-Smtp-Source: AH8x225hVyJmJNpoO582loG/aXa2mkUNVyffpevB+8tLleCq2N32dOzsPvb2qlSGnwB8PjKZI+r2 X-Received: by 10.99.107.73 with SMTP id g70mr9354560pgc.38.1517794575802; Sun, 04 Feb 2018 17:36:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517794575; cv=none; d=google.com; s=arc-20160816; b=sfHZkrQ0KwJvZ7ELWetxgWoa3PZlx1h+1QVM1nTHbIU+HgLy6j1Ea/80vLrfkYsCAs oFsW7eWCJsKpj8sKlVy9Y2q6Wkafk5IF+AbJyn90p/eTbCSnk1mMZrc7jJQn8uN3aKKU F5A9h6a4BhJC6Jqj3aJJAdCblrTpkws/iz/XvESIxejW/8vuzJ381mwsdEtMQVs6EEID 3aDJMDCZ1APngYLv+XhOR9o8RiFnQiu5p4nAn6gJh+nNwmyZCEld8E0+tFY+F/Vt8vUJ OEDqlOC/wdVDmrNQRTUZOAR04typOo0UMePrD+gjgmP/JrdiPxcV3OamCDWEWhzlCf36 +p+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=kj+NkS5kx0m0nTuA9dgPynbKqWY8enBxnrrVCqldn44=; b=RyVe2f/exU2yyB/kLMNB0EJC/kzl4xaD27R+Cx4yRrPdnzjdbnta1CqrshWTBCM9Bu KswhTiZtZfxMlF7JMtjpN5w1NALRyzBEANmplwINpiRzUx0EKJUy8DRUJod2dhYc0a+D Q5+Ugdd4Ej0N994RvFoUFIGr8AMaclTg+mQe9AAW0NaApBYDJ5CD8yF4pq7EDtVmfeQZ HgKwrXDq5+In4uRM5k0lyyFilWqTjDFg8JyhW0l3M0/aTmfXMG7MqCJFxrsF4EqCLlvQ QUTioDqc0zklwXXq4FfapRTX0DVS5UDZobClktUpr4MpD4MHv0bK1+smIyEtFUY/0fo5 Xzlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t66si2988108pgc.653.2018.02.04.17.36.01; Sun, 04 Feb 2018 17:36:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbeBEBe6 (ORCPT + 99 others); Sun, 4 Feb 2018 20:34:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:43680 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbeBEB3M (ORCPT ); Sun, 4 Feb 2018 20:29:12 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4E573AE14; Mon, 5 Feb 2018 01:28:01 +0000 (UTC) From: Davidlohr Bueso To: akpm@linux-foundation.org, mingo@kernel.org Cc: peterz@infradead.org, ldufour@linux.vnet.ibm.com, jack@suse.cz, mhocko@kernel.org, kirill.shutemov@linux.intel.com, mawilcox@microsoft.com, mgorman@techsingularity.net, dave@stgolabs.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: [PATCH 37/64] arch/arc: use mm locking wrappers Date: Mon, 5 Feb 2018 02:27:27 +0100 Message-Id: <20180205012754.23615-38-dbueso@wotan.suse.de> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20180205012754.23615-1-dbueso@wotan.suse.de> References: <20180205012754.23615-1-dbueso@wotan.suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Davidlohr Bueso This becomes quite straightforward with the mmrange in place. Signed-off-by: Davidlohr Bueso --- arch/arc/kernel/troubleshoot.c | 5 +++-- arch/arc/mm/fault.c | 12 ++++++------ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/arc/kernel/troubleshoot.c b/arch/arc/kernel/troubleshoot.c index 6e9a0a9a6a04..7212ba466c56 100644 --- a/arch/arc/kernel/troubleshoot.c +++ b/arch/arc/kernel/troubleshoot.c @@ -89,11 +89,12 @@ static void show_faulting_vma(unsigned long address, char *buf) dev_t dev = 0; char *nm = buf; struct mm_struct *active_mm = current->active_mm; + DEFINE_RANGE_LOCK_FULL(mmrange); /* can't use print_vma_addr() yet as it doesn't check for * non-inclusive vma */ - down_read(&active_mm->mmap_sem); + mm_read_lock(active_mm, &mmrange); vma = find_vma(active_mm, address); /* check against the find_vma( ) behaviour which returns the next VMA @@ -115,7 +116,7 @@ static void show_faulting_vma(unsigned long address, char *buf) } else pr_info(" @No matching VMA found\n"); - up_read(&active_mm->mmap_sem); + mm_read_unlock(active_mm, &mmrange); } static void show_ecr_verbose(struct pt_regs *regs) diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c index e423f764f159..235e89a3ed8e 100644 --- a/arch/arc/mm/fault.c +++ b/arch/arc/mm/fault.c @@ -100,7 +100,7 @@ void do_page_fault(unsigned long address, struct pt_regs *regs) if (user_mode(regs)) flags |= FAULT_FLAG_USER; retry: - down_read(&mm->mmap_sem); + mm_read_lock(mm, &mmrange); vma = find_vma(mm, address); if (!vma) goto bad_area; @@ -143,7 +143,7 @@ void do_page_fault(unsigned long address, struct pt_regs *regs) /* If Pagefault was interrupted by SIGKILL, exit page fault "early" */ if (unlikely(fatal_signal_pending(current))) { if ((fault & VM_FAULT_ERROR) && !(fault & VM_FAULT_RETRY)) - up_read(&mm->mmap_sem); + mm_read_unlock(mm, &mmrange); if (user_mode(regs)) return; } @@ -171,7 +171,7 @@ void do_page_fault(unsigned long address, struct pt_regs *regs) } /* Fault Handled Gracefully */ - up_read(&mm->mmap_sem); + mm_read_unlock(mm, &mmrange); return; } @@ -190,7 +190,7 @@ void do_page_fault(unsigned long address, struct pt_regs *regs) * Fix it, but check if it's kernel or user first.. */ bad_area: - up_read(&mm->mmap_sem); + mm_read_unlock(mm, &mmrange); bad_area_nosemaphore: /* User mode accesses just cause a SIGSEGV */ @@ -219,7 +219,7 @@ void do_page_fault(unsigned long address, struct pt_regs *regs) die("Oops", regs, address); out_of_memory: - up_read(&mm->mmap_sem); + mm_read_unlock(mm, &mmrange); if (user_mode(regs)) { pagefault_out_of_memory(); @@ -229,7 +229,7 @@ void do_page_fault(unsigned long address, struct pt_regs *regs) goto no_context; do_sigbus: - up_read(&mm->mmap_sem); + mm_read_unlock(mm, &mmrange); if (!user_mode(regs)) goto no_context; -- 2.13.6