Received: by 10.223.176.5 with SMTP id f5csp2023202wra; Sun, 4 Feb 2018 18:31:41 -0800 (PST) X-Google-Smtp-Source: AH8x227+iXBQGjiiDgmmM8bpu5BRqJJoju1dMkTY0ze790mOFD7sE14Htis46NlntF8wEVZPovqG X-Received: by 10.99.126.25 with SMTP id z25mr4225159pgc.279.1517797901487; Sun, 04 Feb 2018 18:31:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517797901; cv=none; d=google.com; s=arc-20160816; b=ZLH54f3mm2feh/B14GwGInXKaY5GLWNtzE94E8hri/tdJbOo4vUNJpkjZImmKCiOz7 Z815iu3XUvWD5D1GF0XM78NwfYZ4LX96WErynHCpE3VREPV8PiUsLg+85cSGX79L6Xl0 u/EUMGcgJrotATe6tcMAuw3k+T67TQU93YYiwgSM2thhqYgWYDVj8fJ3s65DqjEJ35WY paLPdCGxEXx3tYQ+scZkseEqsLCoFpMFQQv5X6ZAbbsxbjGl3jr/Wq7Ma3WJxVISDCxH B+nfnMCM31yIyNUMyYGDDnoyPt3q1U/lVRLYD6P2NRK7zu2gdZtNku1KMpmFvzMO7YDX g1Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=ATyc4xK81xpooHoe0fr5R6u1eZfYm62hjtj0j3vIsaM=; b=f/au6BkWm4zVPxeSpZZ9LT+UzOywIR7E7LR1JmPT68rqIefNtsSBug6oWnJ2UBoOps wEptHa1HD6wrdQb8NPxV2p9CA+n3doe87jFoLX7Z7EelP4kdy44N9GRDya9lKC8zMAc3 gwdcBWBLEvjW6+/bk2hTjj9bqeyr+NzZz0CHNf2E7STsso+gROR2XTYNZXLUxc2yGevA ftHrDPgIce6s1TZyydBLwY18tahLbTWqnup6E8sQRIa+kXTpvPzlZ9PRC8u046hikSS2 kbMsmmH90uhQ/jDCSqx9sWE8AqzrxNfxggLwEYLgV2jCz4rv3qLgIrqruTB9lZjCgVLs z1lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=H/8Xzhm2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q63si4270454pfb.264.2018.02.04.18.31.27; Sun, 04 Feb 2018 18:31:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=H/8Xzhm2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbeBECaw (ORCPT + 99 others); Sun, 4 Feb 2018 21:30:52 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:57796 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbeBECap (ORCPT ); Sun, 4 Feb 2018 21:30:45 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w152QuD2137680; Mon, 5 Feb 2018 02:30:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=ATyc4xK81xpooHoe0fr5R6u1eZfYm62hjtj0j3vIsaM=; b=H/8Xzhm2L691rYXxOURaMoAJzyqt8sbBhepjIHiDODfktxV87+DNKBnIULk16xErPsNn lz6SY7ldn3iC5dpmxjYeWX93qtUx1TtLUYKqfyF+3vojMoGjcV0ZlErV+RhryJB8txVe EEdU/C6UFopa0zMQxZF4KOLxAnrIfwrdP9iZLIl7YrXNTr/hGQ0OFBxXqZYL+HrIn7IQ tQcRCE6HxBe7Mrqx/Stcq58gH/xAhs1YxvmoCFmg13r2WWP9csKZAiUvpgkO27wFMLr3 2Q5deb0f1bwDRgjqsTDQ2ytaI8mzCuSpQmfqWAQ2Xa1t3o8FzwH3xlf3RJmcvRnwjqSH eA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2fxcg607gu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 05 Feb 2018 02:30:13 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w152UCBc009774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Feb 2018 02:30:12 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w152UBxr006887; Mon, 5 Feb 2018 02:30:11 GMT Received: from [10.182.69.179] (/10.182.69.179) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 04 Feb 2018 18:30:11 -0800 Subject: Re: [PATCH 1/6] nvme-pci: move clearing host mem behind stopping queues To: Keith Busch Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <1517554849-7802-1-git-send-email-jianchao.w.wang@oracle.com> <1517554849-7802-2-git-send-email-jianchao.w.wang@oracle.com> <20180202184605.GJ24417@localhost.localdomain> From: "jianchao.wang" Message-ID: <848639df-1a65-35fe-1c7d-d79cfe4ec581@oracle.com> Date: Mon, 5 Feb 2018 10:30:27 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180202184605.GJ24417@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8795 signatures=668662 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=482 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802050030 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Keith Thanks for your kindly response and directive. On 02/03/2018 02:46 AM, Keith Busch wrote: > This one makes sense, though I would alter the change log to something > like: > > This patch quiecses new IO prior to disabling device HMB access. > A controller using HMB may be relying on it to efficiently complete > IO commands Yes, I will change it next version. Sincerely Jianchao