Received: by 10.223.176.5 with SMTP id f5csp2281690wra; Mon, 5 Feb 2018 01:07:26 -0800 (PST) X-Google-Smtp-Source: AH8x227aeTtkSanNaT9U9q7k6vnkEp08DcWUWQTGZ+8l5Q0vWTqxOdor4UqGBJctBFmgDHpsoC4m X-Received: by 2002:a17:902:10b:: with SMTP id 11-v6mr44329724plb.336.1517821646350; Mon, 05 Feb 2018 01:07:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517821646; cv=none; d=google.com; s=arc-20160816; b=YE8CLZlJeiMkZ4YWGp7fBBH/P1m6NdyGinayDouzceNzDikZ6ib+zAoh+X8P39plkH rWDkefjUwRI98+VkAjzRRelPstalGweivJC2p1Qn2AGWTAKK+UVna5a/X62xRPew9YqP M48jLyOUfaurpmm841+nXtl2VvDGZBja9pQyhQ8imDnnIbE+OdMPUWBbAP7JePL1G6/v f+sRRxTazCm0V3+11HUEFhS0v+BlpZI0YKg2UQZgQiavHcabgVTBdwHpLnjFdPmZUoPY h0YfFVPFzvYphnZXG60gMtjgtJUZbVswlFgnnZ4NjxnSC8a1zMWzsNgDdlbrePwqEg2G Wn4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=VqBBVk7u/AJQodtq5qItiY3pm8/L9OVy9MGyX3SKUJU=; b=yy4UfJZBb4gATBT7t9T88HzenW01mWnkB5XJWxgFffFVJYEyl8iT3pD5o/a46RI5lH e9rcIMx7XRJxTQnewNyVbuL4rs07Oaq14Lh5DTSwNoAXbq9opOTcmSI8hGFcA98qoGXt Q4sUMY2NNQ83LSUOXn+J3jCbr45cBt2bWCHMoQIMxO0fu44QsaxQSMcCcJiZup4DcdvJ UGjzFQHhLr/dKfyu4flWOwTmCXZGrUVU00rFmzJUtvgHEmnC8MFCO7z+d5JKQTbDNTrd aW4PTIMZ0U4Emc8aHQyLeCh5458T66zdsI695DGmarZ+Z2OM4C9/+58aSZ5h0xzvZ+7X 4g0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fVUW7oa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n128si2507002pgn.752.2018.02.05.01.07.11; Mon, 05 Feb 2018 01:07:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fVUW7oa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbeBEJGA (ORCPT + 99 others); Mon, 5 Feb 2018 04:06:00 -0500 Received: from mail-pl0-f41.google.com ([209.85.160.41]:35318 "EHLO mail-pl0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752264AbeBEJFu (ORCPT ); Mon, 5 Feb 2018 04:05:50 -0500 Received: by mail-pl0-f41.google.com with SMTP id j19so11372596pll.2 for ; Mon, 05 Feb 2018 01:05:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VqBBVk7u/AJQodtq5qItiY3pm8/L9OVy9MGyX3SKUJU=; b=fVUW7oa7NRn80ub6DEOyhkOBWMIlLYCCC2wAYYwQkKfcy6rupxZFSJP0I1570wUQDL mBgaEtK0DbJ//kEaM0I+KcgIS2pu3VLZ0h77Q48eYcm+PTQVhWDizhizHMYQe/ipOT0x Cx2mAXA0OamrbFqbkPj0RQ8s5iazmTua46jlY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VqBBVk7u/AJQodtq5qItiY3pm8/L9OVy9MGyX3SKUJU=; b=DIy5eAuu1GyUQO7hrfNfM0MLgnXDhUJ6CpehHCtGB8q9RF8h0qzE134ONheNkBHqHH Nplo4jKgB5Vlp3eDjbiC08NyU9nJ6Tx2tEp+kBAUDLpzuWl1nsWjk1/0HK+K0O0+1d/A gsxYxtYwGNEDrbO/3EAL334+gZXFQWp9xPrXuyZcHl0Dau2uKwddZLnpeOyOv/ODR8hf LI33g10MBeeGMJOXElOilkUDMvHZB2d0S2fdZkKMII5x4ZtAaQKPktPDIE1BM14GmuG7 b1cyRe4Eh7Xs8Mto8lav7FIx3lj3INMrlWQmhuZzGN/yorkFSsztpMwg389YXjjt8muY nn5Q== X-Gm-Message-State: AKwxytcs3KcsXATiu7OtdwtD7qQPaagokY/4I1O5U1LeJ6ce2cYTTC4n oCsf0QBnJanxIck7vDk9GYqKig== X-Received: by 2002:a17:902:7290:: with SMTP id d16-v6mr13169646pll.303.1517821549192; Mon, 05 Feb 2018 01:05:49 -0800 (PST) Received: from localhost ([122.172.61.199]) by smtp.gmail.com with ESMTPSA id n63sm13086341pgn.39.2018.02.05.01.05.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 01:05:48 -0800 (PST) Date: Mon, 5 Feb 2018 14:35:46 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Bo Yan , Saravana Kannan , sgurrappadi@nvidia.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: skip cpufreq resume if it's not suspended Message-ID: <20180205090546.GE28462@vireshk-i7> References: <1516744675-21233-1-git-send-email-byan@nvidia.com> <20180205040118.GB28462@vireshk-i7> <1710637.vo8uP0oTBm@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1710637.vo8uP0oTBm@aspire.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05-02-18, 09:50, Rafael J. Wysocki wrote: > By design (which I admit may be confusing) it should be fine to call > dpm_resume_end() after a failing dpm_suspend_start(), whatever the reason > for the failure is. cpufreq_suspend/resume() don't take that into account, > everybody else does. Hmm, I see. Can't do much then, just fix the only broken piece of code :) -- viresh