Received: by 10.223.176.5 with SMTP id f5csp2350361wra; Mon, 5 Feb 2018 02:33:51 -0800 (PST) X-Google-Smtp-Source: AH8x227dmrbUsRTRQsK3JXQHRbwqlvaLj8MmkmeNqZAbKR/mSkjum/TSs9bjUmehbP1msJkNfaI+ X-Received: by 2002:a17:902:b785:: with SMTP id e5-v6mr34427806pls.317.1517826831393; Mon, 05 Feb 2018 02:33:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517826831; cv=none; d=google.com; s=arc-20160816; b=yqcIPpwzszzWZv9BbAeiQdjPXvIdD/RGiqWzHRlpImPShLeLx594DprzGvTy43bBSN 53eMawkE4y7WdOlp47ulK6BOj+bO02H5Cmn9KSQsDikiTCzWe5W1++qh86g5+IW1n03l wP8xxzzevenhJxULiaLL3WY+p5oBdvI6ujpxGGog7i5R0Aia9IHgMyDnsO3XNk4HclZu UGM5WkEKloy7aMk3MPRS0UraHyZyU58FOhQzvWZQN+lzu31S1FevcJ7kqoK6izVUgwHE +fIR6UcHT9IBk9jmNxNUz+csBcM8hZ37xMc7hHq7kNp3kJZAmnoUPCM3iKtDgpW7izM4 Nx8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=/XS+QEmjOrBN91pWQN08oman65E403DtyU61wgpBB6c=; b=IeyqBFQq1ll3ROF1a0oZKsR86qLY+M6xvwGPO3IvA9zU99+rbTHTdTOAxiOhYgGxem gmxWmaBq7Pu7/9+KurNbqVyh2exPAEWXeLtsRImZpWBeNMyBjLvL5lug4418ZOfHsVf8 EoJeufoCuCttRkpjmXzrSXS3AK9kYtqQP200PKE8YCLJPUGSTsLMXeMPMESdDZ2O/qnO TXfxJvrjqMlOLpgJO0S4k8kZDPTOF07wdzpvBeM1wGaGFQzik4vswf05qxO1qhPY4OLd x6PuA8utkrumD5Sqvij+8VySTWwGRvUpcGi3zZnCRjp9pwry74F0N0T8pAgDrmTRPEFJ eifA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=rQyNXkak; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j13si5279368pgs.510.2018.02.05.02.33.37; Mon, 05 Feb 2018 02:33:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=rQyNXkak; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbeBEKbh (ORCPT + 99 others); Mon, 5 Feb 2018 05:31:37 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:57199 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbeBEKba (ORCPT ); Mon, 5 Feb 2018 05:31:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/XS+QEmjOrBN91pWQN08oman65E403DtyU61wgpBB6c=; b=rQyNXkakJTkfsdl4tBI2+0aKs QirVgQzY9qRNuN3u3BOmxJva5wpBdhxx8srexDGFNabC4fA/RWabCm/PJoluFk5vWkhdhBwtfSjnM 4jW+PKLMXd1ThI81FO71nzM7sU1RLjk5VpwKOf77J7piyooq72XfLMr9ARemqynb1yCmT5YooShng wwt6pwdEKvCbQgUisIX2s4WtqFzeDzRxYj+psUbAo3AtbWLeAd5cgiCuS68+/6lm1TNmys5Bhza6s 1gTZw+0bbAAoJrexSTtS3D7lUCL0PV0sNSKnfTB0tiy/ILG73e574Tdp93bqz/X8jXVFLQ1qF4d3k 3Zb5fTwdA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1eie3e-0003Po-6u; Mon, 05 Feb 2018 10:31:30 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7C5392029F9F9; Mon, 5 Feb 2018 11:31:28 +0100 (CET) Date: Mon, 5 Feb 2018 11:31:28 +0100 From: Peter Zijlstra To: Wen Yang Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn Subject: Re: [PATCH] sched/rt: Make update_curr_rt() more accurate Message-ID: <20180205103128.GR2295@hirez.programming.kicks-ass.net> References: <1517800721-42092-1-git-send-email-wen.yang99@zte.com.cn> <20180205103038.GI2249@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180205103038.GI2249@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 05, 2018 at 11:30:38AM +0100, Peter Zijlstra wrote: > On Mon, Feb 05, 2018 at 11:18:41AM +0800, Wen Yang wrote: > > rq->clock_task may be updated between the two calls of > > rq_clock_task() in update_curr_rt(). Calling rq_clock_task() only > > once makes it more accurate and efficient, taking update_curr() as > > reference. > > > > Signed-off-by: Wen Yang > > Reviewed-by: Jiang Biao > > Thanks! I just noticed update_curr_dl() has the exact same issue, could you also do a patch for that?