Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 5 Feb 2018 11:41:54 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Sasha Levin <Alexander.Levin@microsoft.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Abhijeet Kumar <abhijeet.kumar@intel.com>
Subject: Re: [PATCH AUTOSEL for 4.14 029/110] ASoC: nau8825: fix issue that
 pop noise when start capture
Message-ID: <20180205114154.GB12384@sirena.org.uk>
References: <20180203180015.29073-1-alexander.levin@microsoft.com>
 <20180203180015.29073-29-alexander.levin@microsoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="O5XBE6gyVG5Rl6Rj"
Content-Disposition: inline
In-Reply-To: <20180203180015.29073-29-alexander.levin@microsoft.com>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--O5XBE6gyVG5Rl6Rj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 03, 2018 at 06:00:42PM +0000, Sasha Levin wrote:
> From: Abhijeet Kumar <abhijeet.kumar@intel.com>
>=20
> [ Upstream commit d070f7c703ef26e3db613f24206823f916272fc6 ]
>=20
> In skylake platform, we hear a loud pop noise(0 dB) at start of
> audio capture power up sequence. This patch removes the pop noise
> from the recording by adding a delay before enabling ADC.

>  	switch (event) {
>  	case SND_SOC_DAPM_POST_PMU:
> +		msleep(125);
>  		regmap_update_bits(nau8825->regmap, NAU8825_REG_ENA_CTRL,

This is another one of these where I'm not convinced that backporting to
stable isn't going to introduce regressions - it will fix problems on
some systems but if someone really cares about a startup pop and has
arranged to do something like discard the start of the audio where the
pop occurs then this may cut off even more and cause them to miss
things. =20

--O5XBE6gyVG5Rl6Rj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlp4QwEACgkQJNaLcl1U
h9BY1gf/Z2AYW2wrykftBW3dBU/wkDBYN1y5uX9zRs2AUj+SgxzvBueBbKMqtmFw
p9v/4HBvvSPFBmAKDx2P0OeqlnKYb9AUcJklASlDugrHzOWZQ8JtGFXHgRMzpHb5
1Fi/FWICRHTnQ/wDeSFjisACyLMKm0a4t88cW8iWOrEoKA46PwlaWnNt6QIXh2t6
s2XqIby9Gdt5PZ+u+RfT2sURCdYVVrc7C6p7U3g9AdiQwxKaoobdfVRU9inUDiU9
djbT0Q0xSFjJDCHufg8euyeoPLD6vAGLH4nQXSJyO0eqxAOF7hY400hWrUEJeqXv
bi9dHdzJtMpi7sXvg90ODPl/0FSY7g==
=nfP1
-----END PGP SIGNATURE-----

--O5XBE6gyVG5Rl6Rj--