Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 5 Feb 2018 17:25:20 +0100
From:   Niklas Cassel <niklas.cassel@axis.com>
To:     Jingoo Han <jingoohan1@gmail.com>
Cc:     'Andy Shevchenko' <andy.shevchenko@gmail.com>,
        'Kishon Vijay Abraham I' <kishon@ti.com>,
        'Joao Pinto' <Joao.Pinto@synopsys.com>,
        'Lorenzo Pieralisi' <lorenzo.pieralisi@arm.com>,
        'Bjorn Helgaas' <bhelgaas@google.com>,
        linux-pci@vger.kernel.org,
        'Linux Kernel Mailing List' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] PCI: designware-ep: Return an error when requesting
 a too large BAR size
Message-ID: <20180205162519.GA3044@axis.com>
References: <20180201161119.3852-1-niklas.cassel@axis.com>
 <20180201161119.3852-4-niklas.cassel@axis.com>
 <CAHp75VdX5=kzKFunM-Kbw7KOBt3+xik_pxhX1EZdO9eA3QHrBQ@mail.gmail.com>
 <000601d39b8e$f58a76f0$e09f64d0$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000601d39b8e$f58a76f0$e09f64d0$@gmail.com>
User-Agent: Mutt/1.9.1+16 (8a41d1c2f267) (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 01, 2018 at 02:00:40PM -0500, Jingoo Han wrote:
> On Thursday, February 1, 2018 1:58 PM, Andy Shevchenko wrote:
> > 
> > On Thu, Feb 1, 2018 at 6:11 PM, Niklas Cassel <niklas.cassel@axis.com>
> > wrote:
> > 
> > include/linux/sizes.h:
> > 
> > +SZ_4G  0x100000000ULL
> > 
> > > +       if (size > 0x100000000ULL) {
> > 
> > #include <linux/sizes.h>
> > 
> > if (size > SZ_4G) {
> 
> I like this one for the readability.
> Thank you.
> 

I liked it too, however both variants

if (size > 0x100000000ULL) {

if (size > SZ_4G) {

result in:

drivers/pci/dwc/pcie-designware-ep.c:131:11: warning:
  comparison is always false due to limited range of data type [-Wtype-limits]

when compiling with W=1 on a platform with 32-bit size_t.


The annoying thing here is that a BAR can be 64-bit,
yet the parameter size is defined as a size_t,
so the error will only show on 32-bit and not on 64-bit.

What do you think about:

if (upper_32_bits(size)) {
	dev_err(pci->dev, "can't handle BAR larger than 4GB\n");
	return -EINVAL;
}

That should compile without warnings for both
32-bit size_t and 64-bit size_t.


Regards,
Niklas