Received: by 10.223.176.5 with SMTP id f5csp2701848wra; Mon, 5 Feb 2018 08:27:32 -0800 (PST) X-Google-Smtp-Source: AH8x2253kBn6t7zQa6xnyS+nkrdTfBLYCFoAqCNpgpH0JUYAmPcpNDMjv2Iarb78tqWYhsso0xEY X-Received: by 2002:a17:902:3064:: with SMTP id u91-v6mr9936954plb.421.1517848052604; Mon, 05 Feb 2018 08:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517848052; cv=none; d=google.com; s=arc-20160816; b=zOfz/kNX8H2vFD6eK5va6uz5QkgOwSCre2/P47IPhyXVrDsV1NmnQDWn1mfawXJmxY ws3Qr7SevbgLZu2nk7jIL5jxz5BsYE4M1t/cx/5o2aSrtZNZXpeZAADjt72HKZElt2JI 5hybDIxWiWA/+ZRMfnhE2nj3nF5oZDY6ydnAXMiaeeRRPV3V26j5PR9q6IcMUO5njTXj NDn7D4u9pOLb++8txbFWR8+1rI3AKDmUkkc00p5boX/RGIkNGgWvY43CNZafLbartELO c0Zw71+k/BOkghyx6RWEkgusg5WRqvu0tx3NUWnzlDAQniF2sbYg5PA4pTxAEX50qVnh 1T/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=qV0bjP66xaVCkalg1QuS+cRv8+W4GVkLNjGYkp2IBkg=; b=WCxhribDDs+SR7mOXrC6Fs9BN1aTF0UWRZesDusyL1n/SIlHpf72PkEC5vqOKto4ij su1gVRmeZOJiBcBCF4BKzTs3U4AsdEn7MD/fdZ8F8F1UOOkLjgfpQW/71hTlbPx+3EmE Am4cnHUXd4kYEIWQmdaxN6WlNOekLaut76NgwEE+8TNhGNQjVPJFUOyHrcstkh3RINcZ l6nCYj33l9XFivaPZAW8g334tRgg30b+X7tG4isrXWQgdRSqFcRUvztS+IxbXJLx8Thl vHbZf1TY8aKKQWKc9MdKgKmf4HE4OnEN4gSIvKOTbS6Ydw/Rv4CpTjfTLrbRYYTq7BNd wx7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@meituan.com header.s=20130113 header.b=fjh+Z9Df; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=meituan.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s190si5617669pgc.753.2018.02.05.08.27.18; Mon, 05 Feb 2018 08:27:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@meituan.com header.s=20130113 header.b=fjh+Z9Df; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=meituan.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbeBEQ0f (ORCPT + 99 others); Mon, 5 Feb 2018 11:26:35 -0500 Received: from mx-fe5-210.meituan.com ([103.37.138.210]:57236 "EHLO mx02.meituan.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925AbeBEQ02 (ORCPT ); Mon, 5 Feb 2018 11:26:28 -0500 X-Greylist: delayed 936 seconds by postgrey-1.27 at vger.kernel.org; Mon, 05 Feb 2018 11:26:27 EST Received: from localhost (localhost [127.0.0.1]) by dx-it-mx02.dx.sankuai.com (Postfix) with ESMTP id 8E42D2980347; Tue, 6 Feb 2018 00:26:22 +0800 (CST) Authentication-Results: dx-it-mx02.dx.sankuai.com (amavisd-new); dkim=pass (1024-bit key) header.d=meituan.com Received: from mx02.meituan.com ([127.0.0.1]) by localhost (dx-it-mx02.dx.sankuai.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rygdxqN-0WRM; Tue, 6 Feb 2018 00:26:21 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by dx-it-mx02.dx.sankuai.com (Postfix) with ESMTP id 220152980345; Tue, 6 Feb 2018 00:26:21 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.9.2 dx-it-mx02.dx.sankuai.com 220152980345 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meituan.com; s=20130113; t=1517847981; bh=qV0bjP66xaVCkalg1QuS+cRv8+W4GVkLNjGYkp2IBkg=; h=From:To:Subject:Date:Message-Id; b=fjh+Z9DfdCgsm+/xQx7kUH2FOOqdxqxTWILLud0ialkdW/NqW2XeH3s7BMwS+t1ga tlBIdIf4GB12TammWVLRt0rBKTtZHufenPLZxT65uG5mSrJL2yBmpHVyHAW6i11mSL O6bZRHZcfJWM4vctv3QynFQEyTQpjYcOtgJBZK2E= X-Virus-Scanned: amavisd-new at dx-it-mx02.dx.sankuai.com Received: from mx02.meituan.com ([127.0.0.1]) by localhost (dx-it-mx02.dx.sankuai.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id llHlQ_NYGRaC; Tue, 6 Feb 2018 00:26:21 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [114.245.93.137]) by dx-it-mx02.dx.sankuai.com (Postfix) with ESMTPA id 55C7D2980342; Tue, 6 Feb 2018 00:26:13 +0800 (CST) From: Wang Long To: tytso@mit.edu, jack@suse.com Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, wanglong19@meituan.com Subject: [PATCH] jbd2: remove duplicate `\n` in jbd_debug Date: Mon, 5 Feb 2018 21:21:21 +0800 Message-Id: <1517836881-31775-1-git-send-email-wanglong19@meituan.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current jbd_debug output as the following: ``` [180397.891399] fs/jbd2/commit.c: (jbd2_journal_commit_transaction, 718): JBD2: Submit 4 IOs [180397.891417] fs/jbd2/commit.c: (jbd2_journal_commit_transaction, 821): JBD2: commit phase 3 [180397.899183] fs/jbd2/commit.c: (jbd2_journal_commit_transaction, 863): JBD2: commit phase 4 [180397.899189] fs/jbd2/commit.c: (jbd2_journal_commit_transaction, 886): JBD2: commit phase 5 [180397.900321] fs/jbd2/commit.c: (jbd2_journal_commit_transaction, 923): JBD2: commit phase 6 [180397.900327] fs/jbd2/commit.c: (jbd2_journal_commit_transaction, 1092): JBD2: commit phase 7 ``` Every jbd_debug call in kernel will append `\n` in its fmt argument, so remove duplicate `\n` Signed-off-by: Wang Long --- fs/jbd2/journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 3fbf48e..93016bb 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -114,7 +114,7 @@ void __jbd2_debug(int level, const char *file, const char *func, va_start(args, fmt); vaf.fmt = fmt; vaf.va = &args; - printk(KERN_DEBUG "%s: (%s, %u): %pV\n", file, func, line, &vaf); + printk(KERN_DEBUG "%s: (%s, %u): %pV", file, func, line, &vaf); va_end(args); } EXPORT_SYMBOL(__jbd2_debug); -- 1.8.3.1