Received: by 10.223.176.5 with SMTP id f5csp2703519wra; Mon, 5 Feb 2018 08:29:21 -0800 (PST) X-Google-Smtp-Source: AH8x227Bf2LMhR+WjQDx+aWC/pdS1SVFyta2b66oNL6tryuLz5lc1772HqDqNwD4TsK5R3A/aL+n X-Received: by 10.99.65.199 with SMTP id o190mr36322064pga.238.1517848161058; Mon, 05 Feb 2018 08:29:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517848161; cv=none; d=google.com; s=arc-20160816; b=c74UsCU9JtMBRs3aND6DhZI/qGx0cgJGvsDn58HYnzdCuUIP7p8g8FWLu6aGQgJPTu 48yFAX9jE2uI1+cQjJv/qqNWqNQ2grFv+bVe+GBbS+58m2utm99ho4ddIs10cO0tDmHY 3KKv9TZpvjshztpkxjS58KTkEfCYagxnOsZf9YcboHEanb/3iUXVTbhp/3lCaKaFBGDW 25IbeYAdDaWoIofR6RkgNRfFSryEUxFigx31bFnRfAd6DquS9iQDtLEO/Yzx5HsK/K66 weByHydSgnh644ZJ++hHqyXHQ0ekdaqATKFaBQ5rXjvgcpR2ZgBgufp6+PY7paK5A2TR GyMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=RUznYaQeF2QkclA4T7G0u7X82dw0TKiWdVcJuyVVH1o=; b=meBApd1josRIHxbu0hI8NIdqJKSHm3SSfDzdG1KkdwdNexlPnNkwAQQDCuNwGnwqcW I4gsCMEDTLVN0vzkMtwWDflXB67nN+n6hEBz4B7ERKxtW0S/p1yKnBaOYtpF2I1/rquY zDZmI0wN+wlZ5QL4IuD4I6eP15wrwSjJzoFYUE8EVx5Y9x6qdu0BcrVZMS0jGPdUPGnZ 0TziwZkauDrATi/jSuDnP6DJZX4GctMFgnBDZA5n3x2AMX+zMiQ6TdZJrOwAcVCpBkqg c0Iv6rIxMF/+Kh+/kDuyp1UEqJESOlVp2CNROdL819za0JelOZMOVnl7aEpmXi8aC5aD 5HPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WMmeP51W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s65si108249pfe.45.2018.02.05.08.29.06; Mon, 05 Feb 2018 08:29:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WMmeP51W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbeBEQ20 (ORCPT + 99 others); Mon, 5 Feb 2018 11:28:26 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:40165 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925AbeBEQ2V (ORCPT ); Mon, 5 Feb 2018 11:28:21 -0500 Received: by mail-pl0-f68.google.com with SMTP id g18so12093696plo.7; Mon, 05 Feb 2018 08:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RUznYaQeF2QkclA4T7G0u7X82dw0TKiWdVcJuyVVH1o=; b=WMmeP51WaTEymWvhVewfT2UfQnqPyZ8aEh7G/lYrh44SW8YAvn94AitaGZquwjWjK3 vcUN7zjPsWJbQXRgZ7LlL1nW2RUDdsv+H++kuERyHrD97dgxpTlk0NkO0sMg5YKUvMjB sTWrXHTWNZcku8CLW+N9LX6FxmmPYken9pBdSUPlt4WXh/t1pkoTHFTFHkwIblvdGs8H KiqbrKNZEO5OIIVVHrcbywLdAg1AGIbdRzz46/kPCTR3X40Redm4gIaMoaHMtVB0wetD IIPW6NFcr/GOLrhjawMF+rpz5exXGRXDemoeJkj+H9oj8KzUyglp92OEeCUuWsm0BsDD JnQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RUznYaQeF2QkclA4T7G0u7X82dw0TKiWdVcJuyVVH1o=; b=m+l4HQH4AOqIWUQmw/sEexKpwfcW7Wmmy5moVkuiRPHj13TMdWXbo1JYm/TyScNvvt EILq58t5RmoHxoYSoOMU/PlytLeiVaiHGg8El484IQyjIAjdnAQkgfAI6Vs0CW4q/sQL 88wTOHCuXs1z6ELk5z4SZSx0M0E6J35wQ0slVyK3lxbeHU+wnETIBuDo5patdThb5VEC nUJ1lSD4U5Ofwk4Zf/oap+FO7QyDKv5RzhfABGpETh0eiQzBxhqWVSe2tGNdgEUVRmOv uvZePINExwJ3B/FZsWJCu513euQwCeswJT6n5zxmfa3Ri/hYVjT84AUlIMaWBqTlAy74 87Vg== X-Gm-Message-State: AKwxytcX9CSlg6mpMg81muZZqpqtAB9fwaak88sDRTcSoKs1BIru/BZ2 wCX/+qFOv/J2tHvWkyOlfag= X-Received: by 2002:a17:902:5a88:: with SMTP id r8-v6mr23483699pli.289.1517848100733; Mon, 05 Feb 2018 08:28:20 -0800 (PST) Received: from dsa-mb.local ([2601:282:800:fd80:30d9:4c23:b13f:831e]) by smtp.googlemail.com with ESMTPSA id k126sm18684430pfc.24.2018.02.05.08.28.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 08:28:20 -0800 (PST) Subject: Re: [PATCH net 1/1 v2] rtnetlink: require unique netns identifier To: Christian Brauner , netdev@vger.kernel.org Cc: stephen@networkplumber.org, w.bumiller@proxmox.com, ebiederm@xmission.com, jbenc@redhat.com, nicolas.dichtel@6wind.com, linux-kernel@vger.kernel.org, davem@davemloft.net References: <20180205155550.21432-1-christian.brauner@ubuntu.com> <20180205155550.21432-2-christian.brauner@ubuntu.com> From: David Ahern Message-ID: Date: Mon, 5 Feb 2018 09:28:18 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180205155550.21432-2-christian.brauner@ubuntu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/5/18 8:55 AM, Christian Brauner wrote: > Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK > it is possible for userspace to send us requests with three different > properties to identify a target network namespace. This affects at least > RTM_{NEW,SET}LINK. Each of them could potentially refer to a different > network namespace which is confusing. For legacy reasons the kernel will > pick the IFLA_NET_NS_PID property first and then look for the > IFLA_NET_NS_FD property but there is no reason to extend this type of > behavior to network namespace ids. The regression potential is quite > minimal since the rtnetlink requests in question either won't allow > IFLA_IF_NETNSID requests before 4.16 is out (RTM_{NEW,SET}LINK) or don't > support IFLA_NET_NS_{PID,FD} (RTM_{DEL,GET}LINK) in the first place. > > Signed-off-by: Christian Brauner > --- > ChangeLog v1->v2: > * return errno when the specified network namespace id is invalid > * fill in struct netlink_ext_ack if the network namespace id is invalid > * rename rtnl_ensure_unique_netns_attr() to rtnl_ensure_unique_netns() to > indicate that a request without any network namespace identifying attributes > is also considered valid. > > ChangeLog v0->v1: > * report a descriptive error to userspace via struct netlink_ext_ack > * do not fail when multiple properties specifiy the same network namespace > --- > net/core/rtnetlink.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) LGTM. Acked-by: David Ahern