Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 3/3] x86/kvm: Expose AMD Core Perf Extension flag to
 guests
To:     Radim Krcmar <rkrcmar@redhat.com>
Cc:     kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Len Brown <len.brown@intel.com>, Kyle Huey <me@kylehuey.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Borislav Petkov <bp@suse.de>,
        Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>,
        Kan Liang <Kan.liang@intel.com>
References: <cover.1517333237.git.Janakarajan.Natarajan@amd.com>
 <f481ade083edd15c0f5850babaeef378ab06ffce.1517333237.git.Janakarajan.Natarajan@amd.com>
 <20180205134321.GD27896@flask>
From:   "Natarajan, Janakarajan" <Janakarajan.Natarajan@amd.com>
Message-ID: <1ab1c7a9-a55b-2903-50c7-444886ac1bfe@amd.com>
Date:   Mon, 5 Feb 2018 11:48:00 -0600
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180205134321.GD27896@flask>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2018 17:48:04.2478 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ea510128-2d8a-4390-5199-08d56cc09bf3
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1367
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/5/2018 7:43 AM, Radim Krcmar wrote:
> 2018-01-30 11:32-0600, Janakarajan Natarajan:
>> Expose the AMD Core Perf Extension flag to the guests.
>>
>> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
>> ---
>> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
>> @@ -365,7 +371,7 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
>>   		F(LAHF_LM) | F(CMP_LEGACY) | 0 /*SVM*/ | 0 /* ExtApicSpace */ |
>>   		F(CR8_LEGACY) | F(ABM) | F(SSE4A) | F(MISALIGNSSE) |
>>   		F(3DNOWPREFETCH) | F(OSVW) | 0 /* IBS */ | F(XOP) |
>> -		0 /* SKINIT, WDT, LWP */ | F(FMA4) | F(TBM);
>> +		0 /* SKINIT, WDT, LWP */ | F(FMA4) | F(TBM) | f_perfext;
> You can just say F(PERFCTR_CORE) here.  The conditional features are
> needed when there is a runtime config option for them.  We are
> automatically masking features that the host doesn't support,

Okay. I'll send a v5 with the changes.

Thanks.

>
> thanks.
>
>>   
>>   	/* cpuid 0xC0000001.edx */
>>   	const u32 kvm_cpuid_C000_0001_edx_x86_features =
>> -- 
>> 2.7.4
>>