Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/4] lightnvm: add 2.0 geometry identification
To:     =?UTF-8?Q?Matias_Bj=c3=b8rling?= <mb@lightnvm.io>,
        linux-block@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, javier@cnexlabs.com
References: <20180205121505.27563-1-mb@lightnvm.io>
 <20180205121505.27563-4-mb@lightnvm.io>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <b8ddae5a-064c-7468-d5e2-a5a20a93de19@infradead.org>
Date:   Mon, 5 Feb 2018 10:04:45 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20180205121505.27563-4-mb@lightnvm.io>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/05/2018 04:15 AM, Matias Bjørling wrote:
> Implement the geometry data structures for 2.0 and enable a drive
> to be identified as one, including exposing the appropriate 2.0
> sysfs entries.
> 
> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
> ---
>  drivers/lightnvm/core.c      |   2 +-
>  drivers/nvme/host/lightnvm.c | 334 +++++++++++++++++++++++++++++++++++++------
>  include/linux/lightnvm.h     |  11 +-
>  3 files changed, 295 insertions(+), 52 deletions(-)
> 
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index c72863b36439..250e74dfa120 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -934,7 +934,7 @@ static int nvm_init(struct nvm_dev *dev)
>  	pr_debug("nvm: ver:%x nvm_vendor:%x\n",
>  			dev->identity.ver_id, dev->identity.vmnt);
>  
> -	if (dev->identity.ver_id != 1) {
> +	if (dev->identity.ver_id != 1 && dev->identity.ver_id != 2) {
>  		pr_err("nvm: device not supported by kernel.");
>  		goto err;
>  	}

Hi,
The pr_err() above could be a bit more informative to the user. E.g.,
		pr_err("nvm: device ver_id %d not supported by kernel.",
			dev->identity.ver_id);

BTW, isn't that line missing a '\n'?

-- 
~Randy