Received: by 10.223.176.5 with SMTP id f5csp2921735wra; Mon, 5 Feb 2018 12:20:18 -0800 (PST) X-Google-Smtp-Source: AH8x226vyIcs3rWv73vLK+aKzVbb8mJ9UAsEEr/hApd54UU614pbBfwkAv69g9ZhiXev2Uoo5a2h X-Received: by 10.99.114.87 with SMTP id c23mr30721pgn.122.1517862018360; Mon, 05 Feb 2018 12:20:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517862018; cv=none; d=google.com; s=arc-20160816; b=BGHrChd6g5w+xUsqZ1+dEZN5pysVwuI6VU7CosgAVaf68GRx7XGQLKVu2WclZ1BE5E bVjhFV+l3+LNDkKrkwUq0eWmORXimzUDmBLoKgXu66ccasmcuTsxAjNLrNhTTha3UW7c pJiFePCcUwt0qODA3obGF3sDwDXwcEQTZFqZsy1TDanHpSefWR+jhqsUwZDscVmzhpTF 30WyiTGzUWhXmUyE74jemf1d+Az/lo2VoHOHE3t2BU9flmk1T4vVDPPsKrA/ZzJUYNXs g8g2k2IbjV6mltTRBj9I8egk+c/OwzG+XPw/VU6OqGTE9Uj0PcsYtQIYoS3Fq8CVeYLm a7fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature :arc-authentication-results; bh=xsZq9/XhOgeV/ufZSu8beb90a8nF5weWEv2h2TaeypA=; b=GsOUs3gt5gxtr6LajqLjImRXEVKoR7NHA5M6AStY2SZQOVmlMSIJIjEJfmv3hMJx0w Olx3uJH0VewL1xqAsmB1+tZv/0Z060rXLZfKoa65T2ThAT0bYSfKZfueWe7Zqz92RGg5 GOD7eHWGFY1t8/75C6O+AI/2izG1Nlkzi910rhHTEkGutbDfLzEWwQJSCLeDDznJTGeQ 5JYQYVN1F0xYASloOMjvZrK0M0ym2KX1tstKGNUowEZdAYzFBFJd71IDmfkR8MyLSdmQ UfdJC8yuDv/TtpF63Z7w1fjf7aF0nQqmpucOQTue71deYLShadQ7wEWY2PYktiF/0jeK JD8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm2 header.b=L/jFEwQt; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=aova0knm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b9-v6si7286638pli.407.2018.02.05.12.20.02; Mon, 05 Feb 2018 12:20:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm2 header.b=L/jFEwQt; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=aova0knm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbeBEUTL (ORCPT + 99 others); Mon, 5 Feb 2018 15:19:11 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42445 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbeBEUTF (ORCPT ); Mon, 5 Feb 2018 15:19:05 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EE13320A4D; Mon, 5 Feb 2018 15:19:04 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 05 Feb 2018 15:19:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=xsZq9/XhOgeV/ufZSu8beb90a8nF5weWEv2h2TaeypA=; b=L/jFEwQt NtdWeFZMSrPnkt/9UpdioJsG90IXLaMB3thAm12h5EXm9/ICsNzx+V8UnesVj5uQ yBSIURPeCyTVU+2nUDhLXAFJvM5aCkd4MefR0W9Wi0DmQqgsedtvUqNSQ1sl928S F3jB+q5Fr6znJm6jJhm7++Zg8JE8TIwahheulPxcOlLn7C1+IrOlK67HMlSn6iuD rcZIitxdl9clJtIGZN/TGKb0COuLaIv8qj3WeE7ZJYsqD7UxwFO5Ko2u2ORsFibU QKwp6eDAfzbwJIEMb2DqHAHON0W2YOavrjpXSb+Z7XtRWVPwTfTf/g2PHHHICLae 5YqjVxuedgrfOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=xsZq9/XhOgeV/ufZSu8beb90a8nF5 weWEv2h2TaeypA=; b=aova0knmufvmybhu21zabLQkyG894tp/yoCthpJ6OPYi1 WUuxZ0wq7+Yumj5LGJXkeLVjO92FpsIEEVMgA2xePdKmhSlkMshiEwt3C0ilQOG4 H5uJVB/4nQ3nt+DTOQPRu8ycIL5t2Z1bkVNYlu8qXbRT69iqqD4z+Il8KSK4BUQL TWajZHHaYezAZiE3r62SRpdfKYTLmC7joB8LoM1yPTYhQJ3YztZPATrrJ7u70SJ/ c4YkR10xewNXff0RwGibsdzAvk4HPfsWr/vL863bxHjaAuPlN1zurcHfmO+Pgrxa ivahE+BOzNhUFBR0uYKrLBPKvL/AY68WIVTSU86Bg== X-ME-Sender: Received: from localhost (106-69-204-165.dyn.iinet.net.au [106.69.204.165]) by mail.messagingengine.com (Postfix) with ESMTPA id 339757E3DF; Mon, 5 Feb 2018 15:19:03 -0500 (EST) Date: Tue, 6 Feb 2018 07:19:01 +1100 From: "Tobin C. Harding" To: Randy Dunlap Cc: Steven Rostedt , Adam Borowski , Petr Mladek , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Andrew Morton , Joe Perches , Kees Cook , "Roberts, William C" , Linus Torvalds , David Laight , Geert Uytterhoeven Subject: Re: [PATCH] vsprintf: avoid misleading "(null)" for %px Message-ID: <20180205201901.GR29988@eros> References: <20180204174521.21383-1-kilobyte@angband.pl> <20180205094438.pfd7ffymlvklpxe7@pathway.suse.cz> <20180205100305.GO29988@eros> <20180205152218.hxgozi67zka4hgkf@angband.pl> <20180205114952.6af99dff@gandalf.local.home> <49fbcc8b-9522-f19c-d51c-d0059445abdc@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49fbcc8b-9522-f19c-d51c-d0059445abdc@infradead.org> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 05, 2018 at 09:36:03AM -0800, Randy Dunlap wrote: > On 02/05/2018 08:49 AM, Steven Rostedt wrote: > > On Mon, 5 Feb 2018 16:22:19 +0100 > > Adam Borowski wrote: > > > >> My change touches %px only, where your concern doesn't apply. > >> > >> You're right, though, when it comes to %pK: > >> printk("%%pK: %pK, %%px: %px\n", 0, 0); > >> says > >> %pK: 00000000ba8bdc0a, %px: 0000000000000000 > >> > >> So what should we do? Avoid hashing 0? Print a special value? > > > > My personal opinion is that NULL should stay NULL and not be hashed. > > What security issue could be leaked by a NULL? I'm not a security > > person, that's a real question. > > Agree. While these views seem valid I don't think we are going to get much love trying to change %pK to give a smidgen more information when %pK is arguably out of favour :) Tobin