Received: by 10.223.176.5 with SMTP id f5csp2971365wra; Mon, 5 Feb 2018 13:18:55 -0800 (PST) X-Google-Smtp-Source: AH8x227+OhBrFHBqP2Q7a1CAAVj6Xu7BdV6zCrxlK0Y0EtYC3aXu0oZQvkZ/8+89yvEkOYXo9eCm X-Received: by 10.98.147.154 with SMTP id r26mr127169pfk.207.1517865535300; Mon, 05 Feb 2018 13:18:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517865535; cv=none; d=google.com; s=arc-20160816; b=aXJoYB1Pxn3LgcROkqxdaw92JTlALteRrlgozfI+2VHdhFk/oC5mWEkbIyqwxQtIGl NZL9ifJzCoVp/LrR3W+8FcLG0EkxF2nqk1QAE7IrJjNuDjlQZPds99AnLpbRncpf8D8K uE+jl+yOwCUjBT/dWqt1B2sDjNxxGzjxDtAbt6UfvjpS0U9ocL4JUBXU2Sv3WvWe1uTn IS5ibvEqFLr8rK2E/aKJuyEiituHmRLQ0NYyVBlKR0dFqsmw6SkcpbaeISt11lak/diM A/cIhyQgY8YAB4KhN+pmqcjK96Z2WVfz1lId4x+7YddjThPOPSVCatZagCPRhvoUaNYl mTxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=cve9+zAAu4+YUhe/sy004f5zbs+mcNNr8t3/DwQCSK8=; b=BkY9qIXxl8ccsknCCLjLey4cl3x5qXSDeiQU9qSANF0V5iZjIYQW/hz5y8EqAdAcnM EpLK27T4XM3r6ABzBJ9n6G4XKhksB4xMBMewYAJJc8D7fsG8B/qFwZd2faDCMng3jHrP VqfM7n8tGXHMyiEk9C08U97DprpfeIskY4HhlnXFj4Pz9LiizwaT1TcxBOPXuix8PuCD pisrM2rVq9RssBogBiN9AbEf3M+KMn7SBGAUiDwVmIRMlf4CNA7nnBeNoH6K6NNwbuFG TyguxlaFUdNU+3bFnDcl3LwglOksOuRxsBxkskVkYk9ntCDfD411ZllCs/xK608cwEs4 2uTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a92-v6si79188pla.543.2018.02.05.13.18.40; Mon, 05 Feb 2018 13:18:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbeBEVQg (ORCPT + 99 others); Mon, 5 Feb 2018 16:16:36 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:42014 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbeBEVQa (ORCPT ); Mon, 5 Feb 2018 16:16:30 -0500 Received: from mailhost.synopsys.com (mailhost3.synopsys.com [10.12.238.238]) by smtprelay.synopsys.com (Postfix) with ESMTP id 76C8E10C0AF2; Mon, 5 Feb 2018 13:16:30 -0800 (PST) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 49B2750D; Mon, 5 Feb 2018 13:16:30 -0800 (PST) Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2-vip.internal.synopsys.com [10.12.239.238]) by mailhost.synopsys.com (Postfix) with ESMTP id 3189850C; Mon, 5 Feb 2018 13:16:30 -0800 (PST) Received: from US01WEHTC1.internal.synopsys.com (10.12.239.235) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.266.1; Mon, 5 Feb 2018 13:16:29 -0800 Received: from [10.0.2.15] (10.9.130.156) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.266.1; Mon, 5 Feb 2018 13:16:29 -0800 Subject: Re: [PATCH] usb: dwc2: gadget: Use true and false for boolean values To: "Gustavo A. R. Silva" , John Youn , Greg Kroah-Hartman , CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Gustavo A. R. Silva" References: <20180123154531.GA22359@embeddedgus> From: John Youn Message-ID: <333168e1-f8b9-87bc-c6ba-a67c9112d686@synopsys.com> Date: Mon, 5 Feb 2018 13:12:49 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180123154531.GA22359@embeddedgus> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.130.156] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2018 07:45 AM, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/dwc2/gadget.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index e4c3ce0..1f684dd 100644 > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -116,10 +116,10 @@ static inline void dwc2_gadget_incr_frame_num(struct dwc2_hsotg_ep *hs_ep) > { > hs_ep->target_frame += hs_ep->interval; > if (hs_ep->target_frame > DSTS_SOFFN_LIMIT) { > - hs_ep->frame_overrun = 1; > + hs_ep->frame_overrun = true; > hs_ep->target_frame &= DSTS_SOFFN_LIMIT; > } else { > - hs_ep->frame_overrun = 0; > + hs_ep->frame_overrun = false; > } > } > > +Felipe Acked-by: John Youn Regards, John