Received: by 10.223.176.5 with SMTP id f5csp397079wra; Tue, 6 Feb 2018 00:30:48 -0800 (PST) X-Google-Smtp-Source: AH8x22649wAb3ikxuYxhggq3DDxR6GouT9l+ssGWZkhnQmDTeRJTV57YkF5JaBMyj82DSJxtqNdk X-Received: by 2002:a17:902:42c3:: with SMTP id h61-v6mr1627682pld.269.1517905848381; Tue, 06 Feb 2018 00:30:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517905848; cv=none; d=google.com; s=arc-20160816; b=NHrNfnV+yuJL2VNcCDNn1KAa5SNCX9KQ6Yu2njhB69NZSg1IJ47PgPv1bhZk6l8tOi eHG2HqF3Ku6m64651z/5HaZ9XmVPpUYPX0ULopt4jcKpY9qQmMsPhR4qBCysjp1fDJF6 Uwa8ijY8UHlR0hkFEum6FDJbqgUy+oMiKd3e+7sQijS9WtROxHifSZPSaKKRNMgwBRQ6 n5a1mF2dzJnJlY8IZmeci9hsKAThn0xld8u8Q3Iw7VmFwi0Tr+9NNzH+854vICQ7tRIm 4Zm7zPHJej542AZScuFxkbEFs4VNjVHZyhh3NZumJnKqCV5F5KJjRdlxJeJsuJ7U7yEi P8gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=oxwslaTZScQ1tniDCnbTG75frcgMmRjuxqA/IKjZJwg=; b=BogwzOwV+xXYonKgCKXoqqj06eAKyng47T2c5joS8iQFLUx518GUfpWrQPUt4OHrLp kDphf+PA64tSKd0pJRSo0sNQPwwTiyKUPMmBguT4NUmDnqqhq4KUiPdUXIsTSoCT0JUy UWxp0OquWttpIiknha498rj0C+PLCk22KPXjfLTBY/r5QMeFUpiEEVjJIwDPb1YXvG9f oruo9jgn+SuQu42H6sFmLdJq/AWhJnf5J1g44k0L9cpGWjJuaUeUizvNDBVXRCTpqalG JsGlZ2OSgma3fevN4tEmPXEF/kVlcItRtJzzlKVVjhWkMOHyChsLUWDL6dR+4qeBVxxz CEqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j186si1669784pge.177.2018.02.06.00.30.33; Tue, 06 Feb 2018 00:30:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbeBFI3G (ORCPT + 99 others); Tue, 6 Feb 2018 03:29:06 -0500 Received: from sauhun.de ([88.99.104.3]:36726 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbeBFI3A (ORCPT ); Tue, 6 Feb 2018 03:29:00 -0500 Received: from localhost (p54B33329.dip0.t-ipconnect.de [84.179.51.41]) by pokefinder.org (Postfix) with ESMTPSA id 06D922C69CF; Tue, 6 Feb 2018 09:28:56 +0100 (CET) Date: Tue, 6 Feb 2018 09:28:56 +0100 From: Wolfram Sang To: Geert Uytterhoeven Cc: Wolfram Sang , Linux Kernel Mailing List , Dan Carpenter , Linux-Renesas , DRI Development , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List , linux-samsung-soc@vger.kernel.org, netdev Subject: Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask Message-ID: <20180206082856.qx4pj7of36yytetc@ninjato> References: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i7fjmlnpcylye3br" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --i7fjmlnpcylye3br Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > I found two more using "git grep 'define.*0x[0-9a-f]* < '": I added '[0-9]\+' at the end of the regex to reduce the number of false positives... > drivers/net/can/m_can/m_can.c:#define RXFC_FWM_MASK (0x7f < RXFC_FWM_SHIFT) > drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n) > (0x00100 < (n)) /* 0 < n < 4 */ ... but you found those two true positives in there. Nice, thanks! --i7fjmlnpcylye3br Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlp5Z0QACgkQFA3kzBSg KbbYSA//brJm3Wk+jt6LxTyCknABbUX/AufrL2WXLokJ0ZmBYFIXcLww7cpJsl87 xpIkpfJmefWYgLTI3pqDWKZmAFKSV3r4auXeGTfGcZs+TceknU4GubxM75Swq0v9 1hXwREddK/RO5nnpfIER8oubrmZgCmHF6Z9ZrLOAOvXDaIbsxkLDnVXtxi3Xkii3 JvQ6tEer53ghJsLUj+PFN28yxgcBbQScisgr0Help/yEld++jf9nyAf02Ktccn9D HPpXfqOrIgE9XYplI4dl0dDUYM6wV7yOPvj4cQSTDRLX2Qf1iZ9sNVdkAAXFRSia 9YlmKE9+Zc0rcCrIjkbmFz+RDwYiT1/2UmxjPUvvPJskXqbdw6DBYEkcEqs/Xy7G Api/nktPfnbyT2f17k7kTWKh5YK5ZQfuf4WGTC/Nf54a2k8lASZrFyMqigxq1YXA DW5ypA/mqS+jZTi9R8FaZNz+oVn5HCMts2aDrATJ7+u2RaqzlN+rHk2qoa7AVEQW 4pRelcKxktnxIQWr1N/KH7EX4ktREprBRPAQH6O6CG/pIO+t9uILs0+ba21tt/Uf fFgoM+xBO/SO9R43kcYKq5uNs57KYI/Y9qyMln4ae4MmsDDRx3XM/6EoSJa5Q+Yu bpSI8U7C1v1elUOudk8RqPy7eWn2x7ufHBApRBkFZNvsqb/4CzY= =7Gs7 -----END PGP SIGNATURE----- --i7fjmlnpcylye3br--