Received: by 10.223.176.5 with SMTP id f5csp448625wra; Tue, 6 Feb 2018 01:34:15 -0800 (PST) X-Google-Smtp-Source: AH8x225Rs8CXZF43Xwfb7LCkqDadufsg3UGa7W+S7kvqndXNSDhHr0hCQzYXpQi1x4tv8nOsDumE X-Received: by 2002:a17:902:988b:: with SMTP id s11-v6mr1716304plp.99.1517909655343; Tue, 06 Feb 2018 01:34:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517909655; cv=none; d=google.com; s=arc-20160816; b=GFICB0Idgqt2Bd7IES9CiwE8w81wC9aaBiS0T94YIkmYrNkH1NhS74qHWBWnZzrJC7 FFac2aL+A6wfgaf4xtCVnp6FZ8jfoLQqW0wdFr3EyVadws03bRHPHXfEVKJFCkN/kJYp EVDiFwgVAj9IF4mfOCFIlZWPozCoslGSl+G99Zdf7eVUPpWO1BFvY92jQimKDZwxw8ie hCSJ9EkYWyaf8Nduf4NHOqQqM0hs6xYuELMjntfhSCXKO+v+RI9dlXpzJ+gmFyNmuFDO Vefm3vwhqGE37anBmEwQH6a7nljRvnqDgnoxQVEV6B3JejjD1q1xL15B4HzjSDw+r2DA AP8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=XLLyTKGQP1fS+DvyoZR9CFWPrqvAH7mFISWg8s6N0bc=; b=NEmHzz+fsul5Xi5M6EQGR+aq8Xf6B/enRumQpisA3vFYzVXzEnJBV/SjrShP8k0Qle FEYgXFuscdDLBbOiwkX7Rq90F90pIQL6bYqHiMGFqHkdVuyqMhgaLxzWSU4ZKEQ8GNbu gm68l2qs+cQThcdqB2tvQnww1Br+O8iLu+MAxvkO4D4gPtn7RYvr4fJlFTSOt8EXGZFM dZjbJiAvXPyMOGBZsHGzlfysbqoSPwqNFgsxEU/Pkx6WmqAXkpWzmuY0+AT0Z+y0UGnA EFkQcrW9K5Khz965x6mTDAkuNdyZzad+hOXuVY+wSR87yLtrxBwfP/mmcYHE4nEx88JR YY5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si2975621pgq.230.2018.02.06.01.34.00; Tue, 06 Feb 2018 01:34:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbeBFJdc (ORCPT + 99 others); Tue, 6 Feb 2018 04:33:32 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42050 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752199AbeBFJdX (ORCPT ); Tue, 6 Feb 2018 04:33:23 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w169TlPu095970 for ; Tue, 6 Feb 2018 04:33:23 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fy4y0k6qe-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 06 Feb 2018 04:33:22 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Feb 2018 09:33:21 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Feb 2018 09:33:17 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w169XHbj47382534; Tue, 6 Feb 2018 09:33:17 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2618BAE053; Tue, 6 Feb 2018 09:24:32 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 677DBAE059; Tue, 6 Feb 2018 09:24:30 +0000 (GMT) Received: from bangoria.in.ibm.com (unknown [9.124.31.33]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 6 Feb 2018 09:24:30 +0000 (GMT) From: Ravi Bangoria To: rostedt@goodmis.org Cc: mingo@redhat.com, srikar@linux.vnet.ibm.com, oleg@redhat.com, wangnan0@huawei.com, masami.hiramatsu.pt@hitachi.com, keescook@chromium.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, Ravi Bangoria Subject: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show() Date: Tue, 6 Feb 2018 15:04:30 +0530 X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180206093430.7550-1-ravi.bangoria@linux.vnet.ibm.com> References: <20180206093430.7550-1-ravi.bangoria@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18020609-0040-0000-0000-0000040CD32C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020609-0041-0000-0000-000026108066 Message-Id: <20180206093430.7550-2-ravi.bangoria@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-06_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802060118 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplify probes_seq_show() function. We are using %lx to display the offset and we don't prepend unnecessary 0s in the offset. Signed-off-by: Ravi Bangoria --- kernel/trace/trace_uprobe.c | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index c2c965398893..c12a3957e1ee 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -602,24 +602,9 @@ static int probes_seq_show(struct seq_file *m, void *v) char c = is_ret_probe(tu) ? 'r' : 'p'; int i; - seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system, - trace_event_name(&tu->tp.call)); - seq_printf(m, " %s:", tu->filename); - - /* Don't print "0x (null)" when offset is 0 */ - if (tu->offset) { - seq_printf(m, "0x%lx", tu->offset); - } else { - switch (sizeof(void *)) { - case 4: - seq_printf(m, "0x00000000"); - break; - case 8: - default: - seq_printf(m, "0x0000000000000000"); - break; - } - } + seq_printf(m, "%c:%s/%s %s:0x%lx", c, tu->tp.call.class->system, + trace_event_name(&tu->tp.call), tu->filename, + tu->offset); for (i = 0; i < tu->tp.nr_args; i++) seq_printf(m, " %s=%s", tu->tp.args[i].name, tu->tp.args[i].comm); -- 2.13.6