Received: by 10.223.176.5 with SMTP id f5csp623569wra; Tue, 6 Feb 2018 04:48:49 -0800 (PST) X-Google-Smtp-Source: AH8x225xHfMde6MmDtL6buLvtgJbEQh+SONCoGJG76/WhGcObmN5fNOZFTaQFV3p8ruPYDUMfuZg X-Received: by 2002:a17:902:ab8d:: with SMTP id f13-v6mr2346400plr.215.1517921329060; Tue, 06 Feb 2018 04:48:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517921329; cv=none; d=google.com; s=arc-20160816; b=JH2imv3FbI/tZZpJArjyX7Iid2oQZHgisME2wlS0KU2fAwDayAmI3PMi1gZbGIDlHr WQGwWmYuh65vV44NQ0bthWzp1gZLocwGIMp/axGJwOEQLjqrdxgJrZuFwQHTZSfkJJ7W F/J39TH40tNRHLHSrS6/88rzzfZ/Gm/3LsmjRTU5UBgRTjrCfKe//4pnAC6xd/9k2jtB Ki1PjqoxmFBsIY5u0+RGQV2waJaWbMzyNOSzxDmHYM4AZjbWa5z5ikt4HhXqQtuhLxeZ mhHlgPOiFeNxAWw00Qw/QvFu5H8nX8Xqh3AsUkJ7sDqAy1oJdpwlZLD8sKP2J364N3YR iPHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date:arc-authentication-results; bh=R6U3GIBDQQuLBPiP1/PP/sdsqUHo/WlkW7lpj+Y5ayI=; b=B3cJpUHt1GWpAMoKhBFxmbcBqrkMvVknYCyJ5CitAqMxmX/hVP15CUkQVaUAtVZdWm 25ZvQS5y6Fqj2onVPOF71yEGaDjskCQiIYfSjPMUc64n5pQG0FcbB3s5Nwtvwkn6FeWK kCPE0t0rJicy42kX+mrwcXjpEYM8qpRG3NJ0JNkjtMNLQu5uEaog6PRGsdJBrEn9QPi/ /80rjR09WFxZI9F95XSmBO7pkPPtD72MkY1PIw/aTZK7/xfPLvgqPv0bKPLp9gA8a/WO bVrMqX++OvI8QZiNEg315o6ebCLXtVJquSm65l/LnuBH5CeKPZy9h+hzAnv8dIMkJ4Cg binQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p26si3544018pge.348.2018.02.06.04.48.34; Tue, 06 Feb 2018 04:48:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbeBFMsC (ORCPT + 99 others); Tue, 6 Feb 2018 07:48:02 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37044 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807AbeBFMrs (ORCPT ); Tue, 6 Feb 2018 07:47:48 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w16Ck7fY031961 for ; Tue, 6 Feb 2018 07:47:47 -0500 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fybrbaq0q-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 06 Feb 2018 07:47:46 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Feb 2018 12:47:44 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Feb 2018 12:47:40 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w16Cld1Q44368098; Tue, 6 Feb 2018 12:47:39 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D38AF5204C; Tue, 6 Feb 2018 11:39:48 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.40.192.68]) by d06av21.portsmouth.uk.ibm.com (Postfix) with SMTP id 5919C5203F; Tue, 6 Feb 2018 11:39:47 +0000 (GMT) Date: Tue, 6 Feb 2018 04:47:39 -0800 From: Srikar Dronamraju To: Ravi Bangoria Cc: rostedt@goodmis.org, mingo@redhat.com, oleg@redhat.com, wangnan0@huawei.com, masami.hiramatsu.pt@hitachi.com, keescook@chromium.org, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show() Reply-To: Srikar Dronamraju References: <20180206093430.7550-1-ravi.bangoria@linux.vnet.ibm.com> <20180206093430.7550-2-ravi.bangoria@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180206093430.7550-2-ravi.bangoria@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18020612-0020-0000-0000-000003F2D2CE X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020612-0021-0000-0000-0000428549E9 Message-Id: <20180206124739.GA57073@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-06_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802060161 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Simplify probes_seq_show() function. We are using %lx to display > the offset and we don't prepend unnecessary 0s in the offset. > The prepending of 0s was introduced by tracing/uprobes: Do not print '0x (null)' when offset is 0 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2fb3382 Wan, Was there a reason to prepend 0s?