Received: by 10.223.176.5 with SMTP id f5csp628941wra; Tue, 6 Feb 2018 04:55:07 -0800 (PST) X-Google-Smtp-Source: AH8x2263d1g7y0kMVN4UzWOMO6K6LGr/2qZsoe0JRHIZ++kz2hIbZLF7ASHMHCLM0hk1HJ/vIPEE X-Received: by 10.98.254.21 with SMTP id z21mr2392214pfh.48.1517921707853; Tue, 06 Feb 2018 04:55:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517921707; cv=none; d=google.com; s=arc-20160816; b=i7K9O8tmdlNY2v3fSITDI6Mhi2EJ8ht7pG2srwQFdaCYLX3KCB4Yrtem/59Rn1IA7F WoEwHCibVpCeXQWWQWTyG4NRvWhGANr00vVwjTiueQwKokuMIaPQ5vmObvWEY3tdwEdi VJ59kZjpI0LcFWZ/PqiCIU7KWAonuuDHFa5QiEehG4mpX/pI4HB1pvuEXuGjdIYdjC3S rHFgs3SSlYMmcjQSb/R17TYDfKARDxEpw5aDjx1yQk/tfwYhHIkB0mEwq6umE6S+V5rh ru+oQAMcC4X16Ou6KhMF70R931UQm1wYZGdG3WKL3MA+bS37e6O/D7JR0ywZgZbDkV7Z 1PVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=p0i+xGXw1w+KS8XXiofqIxdB1Q6BxHrVYNDZ3UCb0Vk=; b=Kc2jvboM7XG2XyuYQY0VIV6ARPTNnjhfmcFnwjA+W2xQ90HHMZ8oSvNBn6KATf2mEf 17PX7jKnZUzGCrZB42OrzCFNqXct95PJ2jjKsuLlLMavgptsMqi3BnZYXwFoDSbd06yf Y0CP+w4iIAMPQTmgjPHuY2RnQFzpDrIHXDOyYpycy14bh+6OG37/d6POXkq02cV7wQdh OQcqKhMjOYHjWg8zunA0JnlPF4Or3YU3FHpdZipJwOHDVNnOd2uejsUjQXfTT13BCBGx nys/1ZG91YpNzYmkIV6i5BIWRcXp5EO0xWvrk2Kg/QX3QG4MkWM4bjXZK+3ufRPi+nTb +ADg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si4590664plw.164.2018.02.06.04.54.53; Tue, 06 Feb 2018 04:55:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752904AbeBFMyQ (ORCPT + 99 others); Tue, 6 Feb 2018 07:54:16 -0500 Received: from lb3-smtp-cloud8.xs4all.net ([194.109.24.29]:51942 "EHLO lb3-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752566AbeBFMyL (ORCPT ); Tue, 6 Feb 2018 07:54:11 -0500 Received: from [IPv6:2001:420:44c1:2579:2d7e:be56:ee2d:7ebf] ([IPv6:2001:420:44c1:2579:2d7e:be56:ee2d:7ebf]) by smtp-cloud8.xs4all.net with ESMTPA id j2l8eeb98ar0wj2lCefV6C; Tue, 06 Feb 2018 13:54:09 +0100 Subject: Re: [PATCH v5 01/16] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format To: Shunqian Zheng , linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, tfiga@chromium.org, laurent.pinchart@ideasonboard.com, zyc@rock-chips.com, eddie.cai.linux@gmail.com, jeffy.chen@rock-chips.com, allon.huang@rock-chips.com, devicetree@vger.kernel.org, heiko@sntech.de, robh+dt@kernel.org, Joao.Pinto@synopsys.com, Luis.Oliveira@synopsys.com, Jose.Abreu@synopsys.com, jacob2.chen@rock-chips.com References: <1514533978-20408-1-git-send-email-zhengsq@rock-chips.com> <1514533978-20408-2-git-send-email-zhengsq@rock-chips.com> From: Hans Verkuil Message-ID: <72af4cf9-64a5-7f3a-2179-23077d3812b3@xs4all.nl> Date: Tue, 6 Feb 2018 13:54:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1514533978-20408-2-git-send-email-zhengsq@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfKVuVfxF201/i7VL/mvbs1TbEPKFSdf118L4eQ29Ekl0QaPQ+raHwbdUE4Da1QgwAbhmsI82pMGBHM5lJfzItTjUlDx2AFYM3OeRk/w0SP1/VUBpLPlN uNtAy/t+iuwvMn0fXS3KnLyXJr29jgVzwv0dj1L0kxAxEvbhKiFZveN6umSjERHXfwe52kCqbVlmDO++QqSlys73xhTFfm3rQ5Y52opzA8pLVrvuIyZ7oiL/ O+t77V/7iuewcpfIPxQsM46tf6srXWLSECiRiLjwRUxUb0XaS1Sn8IfVe5Ov7d4w12JmzntLFTu5+8lxYT0SnHqassSFE1Cxk0DWRoeNgRLYrSsBB9578k1u p2f9k5A4iRkAPq0BMOZib0jw1Gdq1P1FsJbCdaisWegdsrWvXzEiPq9kAMs834cT5HWnxl6nSJwIrGug9AVv/cTEoUNShZUrxvihEgkOMg56GFnhHl5zmWkI o8VVEZvyR7qS+6EKq/M8MVM032sMpsPzEUMzX5VDabg3mlOrijFwVeYhfSBMFR2LwKWDsBU7ExrFAwXJE1rMVgfeIGKZZeDwqp2pqYDHn9XaBvF67povVA13 H50HwvwM4tz6AvKaFg13oAb4QyCk0O6WUfq7+cdrb7sV0hH2bZ9rK7Z/4CYYduBT2NA9pPDomHxIf8LppT1c+0+BuiCLnJcRmiaxV17y3kofRHrjo38PD1YK /qJMaaNmRc2w8cfTw8XNKNXOO4mz9FRIcGIEAHjDDGLEc2CD69AWnxP4MRlMg7QGj5I9Bs5vvrWsI1qp+2JNafrGGJ1QGvR5CP/wJ5xmJt5obXoWwuhsDRPL /0vxs/j6gANLLcrE41HNpqVMrbn7kdHestF56kIX5Q/gKUQMhtaGbcI0qMLzbxdqac23FqOB8oNxOAt9uflw+ATNKRHXjCn7aBhHM80A3SmH5ktK62zsktl/ glrxVHw6x9OVzTfh5wIra8Pe1cA= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/29/17 08:52, Shunqian Zheng wrote: > Add the Rockchip ISP1 specific processing parameter format > V4L2_META_FMT_RK_ISP1_PARAMS and metadata format > V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Jacob Chen Acked-by: Hans Verkuil Thanks! Hans > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > include/uapi/linux/videodev2.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 7961499..035fd22 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1246,6 +1246,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_TCH_FMT_TU08: descr = "8-bit unsigned touch data"; break; > case V4L2_META_FMT_VSP1_HGO: descr = "R-Car VSP1 1-D Histogram"; break; > case V4L2_META_FMT_VSP1_HGT: descr = "R-Car VSP1 2-D Histogram"; break; > + case V4L2_META_FMT_RK_ISP1_PARAMS: descr = "Rockchip ISP1 3A params"; break; > + case V4L2_META_FMT_RK_ISP1_STAT_3A: descr = "Rockchip ISP1 3A statistics"; break; > > default: > /* Compressed formats */ > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 1c095b5..c023c3a 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -689,6 +689,10 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_VSP1_HGO v4l2_fourcc('V', 'S', 'P', 'H') /* R-Car VSP1 1-D Histogram */ > #define V4L2_META_FMT_VSP1_HGT v4l2_fourcc('V', 'S', 'P', 'T') /* R-Car VSP1 2-D Histogram */ > > +/* Vendor specific - used for IPU3 camera sub-system */ > +#define V4L2_META_FMT_RK_ISP1_PARAMS v4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 params */ > +#define V4L2_META_FMT_RK_ISP1_STAT_3A v4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A statistics */ > + > /* priv field value to indicates that subsequent fields are valid. */ > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > >