Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D96EE208FE
Date:   Tue, 6 Feb 2018 10:51:31 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Thomas Richter <tmricht@linux.vnet.ibm.com>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
        heiko.carstens@de.ibm.com
Subject: Re: [PATCH] perf test: Fix test trace+probe_libc_inet_pton.sh for
 s390x
Message-ID: <20180206135131.GA3451@kernel.org>
References: <20180117083831.101001-1-tmricht@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180117083831.101001-1-tmricht@linux.vnet.ibm.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Wed, Jan 17, 2018 at 09:38:31AM +0100, Thomas Richter escreveu:
> On Intel test case trace+probe_libc_inet_pton.sh succeeds and the
> output is:
> [root@f27 perf]# ./perf trace --no-syscalls
>                   -e probe_libc:inet_pton/max-stack=3/ ping -6 -c 1 ::1
> PING ::1(::1) 56 data bytes
> 64 bytes from ::1: icmp_seq=1 ttl=64 time=0.037 ms
> 
>  --- ::1 ping statistics ---
> 1 packets transmitted, 1 received, 0% packet loss, time 0ms
> rtt min/avg/max/mdev = 0.037/0.037/0.037/0.000 ms
>      0.000 probe_libc:inet_pton:(7fa40ac618a0))
>               __GI___inet_pton (/usr/lib64/libc-2.26.so)
>               getaddrinfo (/usr/lib64/libc-2.26.so)
>               main (/usr/bin/ping)
> 
> The kernel stack unwinder is used, it is specified implicitly
> as call-graph=fp (frame pointer).
> 
> On s390x only dwarf is available for stack unwinding. It is also
> done in user space. This requires different parameter setup
> and result checking for s390x and Intel.

Thanks, looks sane, tested on x86_64, applied.

Do you have some other patches outstanding that I should look? I
travelled a bit, so trying to catch up on patches submitted.

Thanks again,

- Arnaldo