Received: by 10.223.176.5 with SMTP id f5csp765825wra; Tue, 6 Feb 2018 07:03:45 -0800 (PST) X-Google-Smtp-Source: AH8x224/543KW4Lv/hLgKERATm5Fgb/fiIQ5VxMyuZpFopuhTodp3RDy+CWnV/0CAztXuo+98I/v X-Received: by 2002:a17:902:6bc3:: with SMTP id m3-v6mr2683089plt.442.1517929425694; Tue, 06 Feb 2018 07:03:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517929425; cv=none; d=google.com; s=arc-20160816; b=FdsSbTmRhuCV6jl9imGTT9DJ2nlmEHG/f/W0EOhFtnG9ZVSazsTpGyZwQ0lThMTky4 mJhMLiIt6gilpFJXWi8cMP5okzeHs3UwUZ8Cz2oNx+JcxKU7Pm220jzJ3O7/DmUezpZ0 Xl4Nksp2e8ErUPKTbcLhQ1u/tdd05o5m7tbQApxPG0x0U75y/tSMnNq9i2AXFtgl2wWT KrYEnAnJLPWemuRqzDdJUvY97/GBfPbubpm7xpVBSBqbpTJL1lPuq/tdAZe+FACTkACi vWV8+RkyTJ+OwA4gQQzWSwCEN+7DXKybAtaMpe43AMEwxmZLSrKqtRQZF5B3CgTmro2G Sd2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=IL+KnGnX8IomClEd8vZC6bnRONA3Q4ybC/7OUFaOHN4=; b=bKwH1GfKh+EFVp3CQHR/QvstI6pasioSJKpE6t08/cKFCtgYytjGGYKtVI4WX40w0l 4QxIEcy6bnTS9MHb2Ny54jI4yRWfhAwhaE58y3Ruj1KqIOVG2tbN2+F/6MzuUiSX3UKs dESQt7Vhc7RcQbnMW76uhXe0Smb48gOYbKoBcbQnbhbyJKn+eL8I88wNckjLXvqfOvyo H7KgO2U2AAtu/JC4Ldtaavk8cvmx5CKCO3yGI0piGlyRBgbZgZ/eV187d4kl5pjkeiwK 0ohE4yvsXTUBoVzoOALKYC4HoWh2elP8H1Kpy6WKoyHeplotLMDCQp5q6KH8XuRZ2CU+ 7aSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j4si1233702pgf.585.2018.02.06.07.03.30; Tue, 06 Feb 2018 07:03:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbeBFPCC (ORCPT + 99 others); Tue, 6 Feb 2018 10:02:02 -0500 Received: from mga06.intel.com ([134.134.136.31]:63888 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbeBFPB5 (ORCPT ); Tue, 6 Feb 2018 10:01:57 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 07:01:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,469,1511856000"; d="scan'208";a="199038204" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by orsmga005.jf.intel.com with ESMTP; 06 Feb 2018 07:01:55 -0800 Date: Tue, 6 Feb 2018 08:05:52 -0700 From: Keith Busch To: sbates@raithlin.com Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-pci: Fix incorrect use of CMB size to calculate q_depth Message-ID: <20180206150552.GD31110@localhost.localdomain> References: <1517869943-3655-1-git-send-email-sbates@raithlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517869943-3655-1-git-send-email-sbates@raithlin.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 05, 2018 at 03:32:23PM -0700, sbates@raithlin.com wrote: > > - if (dev->cmb && (dev->cmbsz & NVME_CMBSZ_SQS)) { > + if (dev->cmb && use_cmb_sqes && (dev->cmbsz & NVME_CMBSZ_SQS)) { Is this a prep patch for something coming later? dev->cmb is already NULL if use_cmb_sqes is false.