Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kasan: remove redundant initialization of variable
 'real_size'
To:     Colin King <colin.king@canonical.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>, kasan-dev@googlegroups.com
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
References: <20180206144950.32457-1-colin.king@canonical.com>
From:   Andrey Ryabinin <aryabinin@virtuozzo.com>
Message-ID: <e86dcb38-d00e-d5d8-ca66-9ff4013a786c@virtuozzo.com>
Date:   Tue, 6 Feb 2018 23:10:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180206144950.32457-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2018 20:10:43.9639 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 24993ecc-f821-4124-1391-08d56d9db498
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2825
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 02/06/2018 05:49 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable real_size is initialized with a value that is never read,
> it is re-assigned a new value later on, hence the initialization is
> redundant and can be removed.
> 
> Cleans up clang warning:
> lib/test_kasan.c:422:21: warning: Value stored to 'real_size' during
> its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>

> ---
>  lib/test_kasan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index a808d81b409d..dba0ffd45fd7 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -419,7 +419,7 @@ static noinline void __init kasan_stack_oob(void)
>  static noinline void __init ksize_unpoisons_memory(void)
>  {
>  	char *ptr;
> -	size_t size = 123, real_size = size;
> +	size_t size = 123, real_size;
>  
>  	pr_info("ksize() unpoisons the whole allocated chunk\n");
>  	ptr = kmalloc(size, GFP_KERNEL);
>