Received: by 10.223.176.5 with SMTP id f5csp1208361wra; Tue, 6 Feb 2018 14:52:16 -0800 (PST) X-Google-Smtp-Source: AH8x227wVHeqSQmoaSlM4NPg6wmqlVH3+MxwK260wXb6dPFZI1+EIMuHLddPeqsPyS3iviJ9EO8I X-Received: by 2002:a17:902:7d96:: with SMTP id a22-v6mr3927875plm.296.1517957536570; Tue, 06 Feb 2018 14:52:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517957536; cv=none; d=google.com; s=arc-20160816; b=k1Aaxg0iMiNhARbaqNsJJIHGB4v72eyusMY1x0xvPva/PmRGk+eQHKgOreDH0je7WU Z7n3fU8wITOA7FsTmJ/mTKRIx4cnHMqAJx8ApjK+sZ5zTUG9RiTE6U3IizvBTa+4U8cY OKwOwtwqtX9GLonRk2rLzJBY3C0ypEpdYt9QGhBJlJimU2+v8UqXADV8noB5JNp8zXcd EfSCpRFyR0bXhP8pc4Gm4vjF97JpOkxo78ATHkOeuzXWWMR7Ss9N6GQA5Iw+Lqc6V98p JAiuYObOClGGaUmCYyt4kUqGfXw6mEVnZZu/XAxmuM9XQHLNtLz4HttcIEqQ+0SqqJe4 YbxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=lJXcSdlG9xjzKlT2cCRLpOhJ0zezrfaoC8zYOShGkDA=; b=u7BbTGAtqG7H1wDpQeq+knb7VXLwr5QIVTdMf/Okw58ncJDbBAcG7KACieTRWnXmXI 9oEntwXFP11UwTdUcxAuiBzuaS+n+Rl1NgpqPwOT5D3gPQN9n9TzrbPMdGChzVuFFDuB C4ZIQs9XQ3BCIb1oY81JeXoeeBje6M1f/NZ3r8dC9hQ3ShyMKQlzvK6Uyk2FivYZQxzH ruM648eNsnrQlrpIoRtqfOIL6RMzClFIY7VzY8zvfVC440r6lwqZYLfAqdX5IYMqLU7D tBeba/HiojnA+HCkIcNhbCcbbxerCxFmTHNBUrcVYE7aWX9ewYsB1dQyPlXhiDsHFIxf /QCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si33811pgv.672.2018.02.06.14.52.02; Tue, 06 Feb 2018 14:52:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753668AbeBFWvX (ORCPT + 99 others); Tue, 6 Feb 2018 17:51:23 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:45428 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753235AbeBFWvW (ORCPT ); Tue, 6 Feb 2018 17:51:22 -0500 Received: by mail-ot0-f194.google.com with SMTP id 73so3349555oti.12 for ; Tue, 06 Feb 2018 14:51:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lJXcSdlG9xjzKlT2cCRLpOhJ0zezrfaoC8zYOShGkDA=; b=BLdyFzypNu8jAqkGLAcq5b0hZWGNJfcaPHvmFC2HHfE5C/IdbaL5dmfQ/aF1/+p2LZ utlicOegaCz+Z2cli+noCpahIPBmeYnjL1Loxor1l1cEDZgbea1GsWUgchhQ82Avj6k+ lzRxqnCy5KSSyhjj6LkEEG20pVTN2KIY2SsyRYUUCJ1mtE34lVt0mfzN/g0ztwHpqkag Tf/Cn3hC0FVL669lCjZlI7gCBBeTPsJit0qAUP6+MeiU4INQmpWcQIc/7ON//Vxym+5J KV4wMiOhVtZfbwwMDdaFh/bXQbxissPyQY34+wC+gu3joJQyl38n3NHHlemtvCRNSkJQ l6DQ== X-Gm-Message-State: APf1xPCpa0+oKu3HdfzLHc6SyRNzrklrRwaVR6I+Fhdy4taMsj5iUVBB zc4Yyh3I9GwzVhcuQ8QZP2rIDHg0xJk= X-Received: by 10.157.113.81 with SMTP id y17mr3006889otj.306.1517957481446; Tue, 06 Feb 2018 14:51:21 -0800 (PST) Received: from ?IPv6:2601:602:9802:a8dc::f21a? ([2601:602:9802:a8dc::f21a]) by smtp.gmail.com with ESMTPSA id w2sm37564oth.48.2018.02.06.14.51.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2018 14:51:20 -0800 (PST) Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool To: Yisheng Xie , gregkh@linuxfoundation.org Cc: sumit.semwal@linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1517392252-20964-1-git-send-email-xieyisheng1@huawei.com> From: Laura Abbott Message-ID: <19448c54-7214-ce7c-1ae0-9e8605e34f2c@redhat.com> Date: Tue, 6 Feb 2018 14:51:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1517392252-20964-1-git-send-email-xieyisheng1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2018 01:50 AM, Yisheng Xie wrote: > ion_page_pool.c now is used to apply pool APIs for system heap, which do > not need do any initial at device_initcall. > > Meanwhile, this patch also remove some useless include files. > Acked-by: Laura Abbott > Signed-off-by: Yisheng Xie > --- > drivers/staging/android/ion/ion_page_pool.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c > index 817849d..3c1eba5 100644 > --- a/drivers/staging/android/ion/ion_page_pool.c > +++ b/drivers/staging/android/ion/ion_page_pool.c > @@ -14,12 +14,7 @@ > * > */ > > -#include > -#include > -#include > -#include > #include > -#include > #include > #include > > @@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool) > { > kfree(pool); > } > - > -static int __init ion_page_pool_init(void) > -{ > - return 0; > -} > -device_initcall(ion_page_pool_init); >