Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] staging: android: ion: Remove dead code in
 ion_page_pool_free
From:   Laura Abbott <labbott@redhat.com>
To:     Yisheng Xie <xieyisheng1@huawei.com>, gregkh@linuxfoundation.org
Cc:     devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <1517801177-37021-1-git-send-email-xieyisheng1@huawei.com>
 <6286ae0a-f439-3477-91bb-8df0e454b98e@redhat.com>
Message-ID: <a8c0aec1-5e90-ccbf-01bb-bb6d12281035@redhat.com>
Date:   Tue, 6 Feb 2018 15:11:15 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <6286ae0a-f439-3477-91bb-8df0e454b98e@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/06/2018 03:10 PM, Laura Abbott wrote:
> On 02/04/2018 07:26 PM, Yisheng Xie wrote:
>> ion_page_pool_add will always return 0, however ion_page_pool_free will
>> call ion_page_pool_free_pages when ion_page_pool_add's return value is
>> not 0, so it is a dead code which can be removed.
>>
> 
> Can you clean up ion_page_pool_add to be a void return as well?
> No sense in having it just always return 0.
> 

Nevermind, just saw the follow up patch. Both of them:

Acked-by: Laura Abbott <labbott@redhat.com>

>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>> ---
>>   drivers/staging/android/ion/ion_page_pool.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
>> index 4452e28..150626f 100644
>> --- a/drivers/staging/android/ion/ion_page_pool.c
>> +++ b/drivers/staging/android/ion/ion_page_pool.c
>> @@ -79,13 +79,9 @@ struct page *ion_page_pool_alloc(struct ion_page_pool *pool)
>>   void ion_page_pool_free(struct ion_page_pool *pool, struct page *page)
>>   {
>> -    int ret;
>> -
>>       BUG_ON(pool->order != compound_order(page));
>> -    ret = ion_page_pool_add(pool, page);
>> -    if (ret)
>> -        ion_page_pool_free_pages(pool, page);
>> +    ion_page_pool_add(pool, page);
>>   }
>>   static int ion_page_pool_total(struct ion_page_pool *pool, bool high)
>>
>