Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool
To:     Laura Abbott <labbott@redhat.com>, <gregkh@linuxfoundation.org>
References: <1517392252-20964-1-git-send-email-xieyisheng1@huawei.com>
 <19448c54-7214-ce7c-1ae0-9e8605e34f2c@redhat.com>
CC:     <sumit.semwal@linaro.org>, <devel@driverdev.osuosl.org>,
        <linux-kernel@vger.kernel.org>
From:   Yisheng Xie <xieyisheng1@huawei.com>
Message-ID: <fb1536ee-5223-4cd9-4698-f37ea8a6741c@huawei.com>
Date:   Wed, 7 Feb 2018 08:47:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <19448c54-7214-ce7c-1ae0-9e8605e34f2c@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Laura,

On 2018/2/7 6:51, Laura Abbott wrote:
> On 01/31/2018 01:50 AM, Yisheng Xie wrote:
>> ion_page_pool.c now is used to apply pool APIs for system heap, which do
>> not need do any initial at device_initcall.
>>
>> Meanwhile, this patch also remove some useless include files.
>>
> 
> Acked-by: Laura Abbott <labbott@redhat.com>

Thanks, and I split this into two small patchs as Greg's suggestion in a resent patch.

Yisheng

> 
>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>> ---
>>   drivers/staging/android/ion/ion_page_pool.c | 11 -----------
>>   1 file changed, 11 deletions(-)
>>
>> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
>> index 817849d..3c1eba5 100644
>> --- a/drivers/staging/android/ion/ion_page_pool.c
>> +++ b/drivers/staging/android/ion/ion_page_pool.c
>> @@ -14,12 +14,7 @@
>>    *
>>    */
>>   -#include <linux/debugfs.h>
>> -#include <linux/dma-mapping.h>
>> -#include <linux/err.h>
>> -#include <linux/fs.h>
>>   #include <linux/list.h>
>> -#include <linux/init.h>
>>   #include <linux/slab.h>
>>   #include <linux/swap.h>
>>   @@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool)
>>   {
>>       kfree(pool);
>>   }
>> -
>> -static int __init ion_page_pool_init(void)
>> -{
>> -    return 0;
>> -}
>> -device_initcall(ion_page_pool_init);
>>
> 
> 
> .
>