Received: by 10.223.176.5 with SMTP id f5csp72379wra; Tue, 6 Feb 2018 17:27:32 -0800 (PST) X-Google-Smtp-Source: AH8x227qvbdhkG/EXDdOH9Ih25nCZNN3EPHvijNoGrBDwxTu+fuejb4titJLNxhyREStaxAmlljS X-Received: by 10.99.123.81 with SMTP id k17mr3263736pgn.400.1517966852254; Tue, 06 Feb 2018 17:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517966852; cv=none; d=google.com; s=arc-20160816; b=L/dJJLT4la9QqGO55hQeE2ChZ01TYeZuKbJ50/2w644QZMNGCOAxHj3UYXmJAlvQw9 w33HL4Qn2Q2IqWp2TVzuU7yLgFRu2L5G6Gxknq2K0zRXEuDyDGC7I70SfVicLmUYzpLW qvRpwVVvS7iFls1T9IjiSxN0RGWlglaSqnpYBT81eRRlxrRohPS/S+w/VxKB8NhDD+Y7 nQk/l9kHkjL6wy9YlkIr3OsSzBDqXcPzut3K94nV+rofTqohB2vp1wbFcEVyLPalC+hC HJ3sevom7CLn5DkwMjhVOPwFxaxDmDwZBA1ZhkmSYXILT3r+12t3WVR7rcENWvx6KZsR JSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=kSFZ5QItAdChX3sz7olRPKm0ber70UhzOOzlA6TX+eg=; b=On+9Rc1WsqLJ2vZ93n9hXn6NkOtp8gqsFL+OLJ/Cf+0dNEu3YKZ/hfIuqei3t98gJ8 ApXWcpK/zXX+3nReu8WfQ/TwR2vk5Fa2kxSvXUlFk+ZsW6G1mbi0GOoNAAzGP9fsVObc FMow3EA7dVHC1Th4VpWNy6xleHGp+vZZ15QShVakah0DZ4SLypQkmI+Pf3MKdeh9N3Rw 6I3roI2oOrUXpJedfHF8dU1yIzD46ZsAXxtadUO+WIdcUjlLTA5Xr3R1rmssoGOcYWc+ ddBqpwJDM1jEdtQPiaNJBAeLBpkMHC0WHhxC3osdOjK9+J11jKNd6kt+q+uANvVFAgoT 6qWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=eGaqChrz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si214850pgv.507.2018.02.06.17.27.17; Tue, 06 Feb 2018 17:27:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=eGaqChrz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932208AbeBGB0e (ORCPT + 99 others); Tue, 6 Feb 2018 20:26:34 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:42296 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754189AbeBGB0c (ORCPT ); Tue, 6 Feb 2018 20:26:32 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w171PDhV009675; Wed, 7 Feb 2018 01:26:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=kSFZ5QItAdChX3sz7olRPKm0ber70UhzOOzlA6TX+eg=; b=eGaqChrzqKKlu4G/RPCzhG3tew0ydkwN2vvRl6eQhD3PNVLCP0Q8W5JI/QEdshaW5pjr rSAOwQTv/ZdFUStrZ2I3O49rz4UiOTo5Qf7JELkjchLZhI3VLLI+8Bzx66Anuqan6txf 6HOCMjbWG1cB/bu5IC+Lu16Iw0TCzl7Yf534noJI+6tZtLYx0JX1BNSxteY7gYhkkYVx 8/WeizfGobUF/Dvsh/lSAQO3u0qIiCxmMue0rGd9PV+XVrOBmxLrHgSqJmI+RD9NdQxW 61KOKp4YA+dColWm4bt2C26/mpEETk+rSRFO3ldZqQL8fr5uvg50a2MpqIHaSNTPAFLA ZQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2fypf506sx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Feb 2018 01:26:27 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w171QQMD026257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Feb 2018 01:26:26 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w171QPXS031431; Wed, 7 Feb 2018 01:26:26 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 06 Feb 2018 17:26:25 -0800 To: Colin King Cc: Johannes Thumshirn , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: libfc: remove redundant initialization of 'disc' From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180206142157.32001-1-colin.king@canonical.com> Date: Tue, 06 Feb 2018 20:26:23 -0500 In-Reply-To: <20180206142157.32001-1-colin.king@canonical.com> (Colin King's message of "Tue, 6 Feb 2018 14:21:57 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8797 signatures=668663 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=603 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802070013 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > Pointer disc is being intializated a value that is never read and then > re-assigned the same value later on, hence the initialization is redundant > and can be removed. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering