Received: by 10.223.176.5 with SMTP id f5csp480326wra; Wed, 7 Feb 2018 02:30:51 -0800 (PST) X-Google-Smtp-Source: AH8x224ZT1c437fp4xznnQLGEI1BPEVAGXWU6LhaQx1lC9ORbl3zQeBQjlrdcrtFTs1ccvkPUCC1 X-Received: by 10.98.19.19 with SMTP id b19mr5583434pfj.118.1517999451869; Wed, 07 Feb 2018 02:30:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517999451; cv=none; d=google.com; s=arc-20160816; b=lG9eufRtfNjkc27GL8aEzIvvoUFxDja3Xpc7GmbDsf5TgvGGWOcDLxjjcpN2NcxNdn Z6F81b/7bGS157/o04oIMSaIYXtVfhgJJZBbSTC0Mr4E7++HSk3tLpZxWaxDu6YNRtTU 66Go8BWNxir1MbuG1mifFXobRDO9Ey8IS+hh8gEIeMeeKjVkdoxxIxygX6x5yTFWHJFD LvRsTjGkdNy6yzZn+vWwW0xXWQ+5fQPxlciiJ2EU8Yj/mnqTXp/+iF5aT5B39QMMX6Ce q4aeBobxGYOC8jpYDSW2/eN9ykHPQMoKwHIMjkHBkt57ZDBT6iac1iB4A2TYTdV6qke7 XMlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=tM3Hdck5Nodx3fLF1ziYfUXzrKYJjU2aaTbx99hgXxc=; b=QrcHtv2+Bpb4H8aj2fDB/GdQXFRHw+/4E6wstcTWxW341ctQv6CiEKcdr0fX+Humhu BHt4USMC+6vuPEtQQglEeXqeJvsuvu5A8oNy2+2KARqzusqvo5LvoEjBxBc7oHEkf1RK rMWo326dd2BZiv0JLqATCmBr0Ko5BC4ggLyLAY0wZn5zwW3NJ/4OcOiS4EFpgWvpkQ4J 3KX8TGUHcZAhr+JZl8Svyc3GmCh5xADESMVENlJoIwpy4KlDLMszkosvpG6vivJDNU// 62uDrfIH2ejEo3CCqRojp+M4eLc+u+FNT68/hjNjQXeTJavGPQMWoka5bWtm8h5bAX09 Be6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5-v6si888150plt.563.2018.02.07.02.30.38; Wed, 07 Feb 2018 02:30:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753822AbeBGK36 (ORCPT + 99 others); Wed, 7 Feb 2018 05:29:58 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:38441 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753580AbeBGK3y (ORCPT ); Wed, 7 Feb 2018 05:29:54 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1ejMz6-0007e5-5h; Wed, 07 Feb 2018 10:29:48 +0000 From: Colin King To: "J . Bruce Fields" , Jeff Layton , Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static Date: Wed, 7 Feb 2018 10:29:47 +0000 Message-Id: <20180207102947.29292-1-colin.king@canonical.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variables nlm_ntf_refcnt and nlm_ntf_wq are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: fs/lockd/svc.c:60:10: warning: symbol 'nlm_ntf_refcnt' was not declared. Should it be static? fs/lockd/svc.c:61:1: warning: symbol 'nlm_ntf_wq' was not declared. Should it be static? Signed-off-by: Colin Ian King --- fs/lockd/svc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index 9c36d614bf89..346ed161756d 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c @@ -57,8 +57,8 @@ static struct task_struct *nlmsvc_task; static struct svc_rqst *nlmsvc_rqst; unsigned long nlmsvc_timeout; -atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0); -DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq); +static atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0); +static DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq); unsigned int lockd_net_id; -- 2.15.1