Received: by 10.223.176.5 with SMTP id f5csp481723wra; Wed, 7 Feb 2018 02:32:20 -0800 (PST) X-Google-Smtp-Source: AH8x225P9ABpVtUdAetLJcywkYIEHZEjLFADb8g9qaWihCs/oMSGhwlfCKITvI6T02El3fSZM7Qm X-Received: by 2002:a17:902:9a8b:: with SMTP id w11-v6mr5707544plp.118.1517999540813; Wed, 07 Feb 2018 02:32:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517999540; cv=none; d=google.com; s=arc-20160816; b=fFEZk5tZxDFhndRJ/oQ3c/GWvx19nRX5RJSadI0IUsx1HOtSLK9z0k7Ljn7ENkjsNI d541xOVZa7vZec/Hf4SgXnLxntVNrs8woi8ejIBIJCEy8FPJvnpIwaW4FVh5am+G4b+J MEy3mIFSy6gwXcjc6a/+ahZohAeuKT0pCPHrh4z+M/XJp3nAaoBpPsT6IgaLYKr8ZQjh OoTqsQkPkVFifUZqaXRTnXLpFERFlh/IUgJRrHGvTFmyPQg+U9G8q56KK2JnNieWkm80 pFknE9XQQjdk6FknXwlauCy17dyl2JWpFP3oKU8YQgoEb8Y/yOvqZsmHQ/iZgvMBJSDs 3Spw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=B2wrvW5myo5QfsdtXkP5haKqul4QFc5GOfc0/bXy3Zs=; b=kt8rnAUXuJBj8HgTu/lUuIFveR4VuAgSn9apHVZNOTUAJx5gYjLJXfxNUZdsBUk0sA n8VKatfdH1Yv6jCZ97ZLEYtIocMfgGsqciR5waWw/ApJM5uRCM5+dIf9nuUoXIGtTU6o p+yc2J2Qon1oCoiXKmU03hRBxtWGNISAZoEEsWSKBqaLf/sY87vEVyJbs8+ebAljMFHS eK6rQHK9jMK5dNQ3bTYiGMeeqr5QDlhDGfAJ+tQRAqGYxtjGuuy4RH3iSWjdogNyjRyR Vob0UQmSypGUb/qZY8F+CooYNGG+O1nvwpwU79Ud0YJXotlrveIEiR+ipPXj/Tf8LfEX 2c0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5si465139pgr.390.2018.02.07.02.32.06; Wed, 07 Feb 2018 02:32:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753807AbeBGKba (ORCPT + 99 others); Wed, 7 Feb 2018 05:31:30 -0500 Received: from mout.gmx.net ([212.227.17.21]:63733 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753676AbeBGKb2 (ORCPT ); Wed, 7 Feb 2018 05:31:28 -0500 Received: from homer.simpson.net ([185.191.217.115]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LyVcA-1eo82P0FiI-015mpE; Wed, 07 Feb 2018 11:31:15 +0100 Message-ID: <1517999473.6606.3.camel@gmx.de> Subject: Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook From: Mike Galbraith To: Paolo Valente Cc: Oleksandr Natalenko , Jens Axboe , linux-block , Linux Kernel Mailing List , Ulf Hansson , Mark Brown , Linus Walleij , 'Paolo Valente' via bfq-iosched , Alban Browaeys , Ming Lei , Ivan Kozik , SERENA ZIVIANI <169364@studenti.unimore.it>, Serena Ziviani , Holger =?ISO-8859-1?Q?Hoffst=E4tte?= Date: Wed, 07 Feb 2018 11:31:13 +0100 In-Reply-To: <5584030F-8F4E-4C98-84A5-79873A1BF775@linaro.org> References: <20180205190510.5499-1-paolo.valente@linaro.org> <20180205190510.5499-2-paolo.valente@linaro.org> <1517903761.9843.12.camel@gmx.de> <899B68CC-5955-4418-8BFF-DC55A743A61B@linaro.org> <1517918234.25841.31.camel@gmx.de> <77124223e6116350a5184a5199850304@natalenko.name> <1517924768.25841.32.camel@gmx.de> <8842084cc8a26b7f46ae600bda8a7bd0@natalenko.name> <82ffc96aacc3945861cbb708df346338@natalenko.name> <1517995431.25619.5.camel@gmx.de> <1517998516.6606.1.camel@gmx.de> <5584030F-8F4E-4C98-84A5-79873A1BF775@linaro.org> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8nzIsH5hK0FKrELrRBJuWNCD1zDr4NBEreJF1dEgi66KRUiv64K FrFPTmjfihqq0LbFWka/kZH1lz+KMZxfAZIkHnSHIbnOOCA0Mdyj+N/4IsLK2/3akZUBZKD z/2vMW8zWK+1VR4hnCbQjornM4WNmUdanTxIHjKO4WWa9CBG15bLZo7ItKLYlz2c4GpIbSP ZXV5Ue8mQRpQmcSBy/yVg== X-UI-Out-Filterresults: notjunk:1;V01:K0:oaIIth/Xnpk=:KCANipP9I9EbioDQOTt/Qv 5Xl76EqBDkBC27yDmb61tQ354Ry87UKMGUlNu/urQkgqwijueRriOBXPoWeXJlVu8Dhkepih5 d6nX5ojr6azjNUzH2dAkdRfXt9B/ZFXLLrwC2FIjexT86A+mhoSATyzj71pcLSIj65C4tHqy1 Q9dlnwflcTGzoQRf84qpaF31pfi8QCM5NO6iNuagt03ge0JVYVaUf8lt3bziQ/H+lWP9knRu6 KUNcpBYaicHgIqJsqujxArFEXpxB06zQF1vaG3zxK7Xk1IO3X0pgmNMYRVDRPvdmwM3g8Hu33 v0/PYDh3D6iJOSRwx7AkhRyjn1ayOGgGy7weD+k3hEluzU7JjPBTXkKs7Fw3X++sdIv58eHeW whT5hlyxLU3JKSxulr0iokTii4PgqRNGYIyjWl+sZ1eougZKemDSmfmR4b+EheZ2y7A0E/yjD j+EUj2Gsu0EosQIvD8XVT8lvbtah49iHC02jyIt+qnBiIxngb8xawYuDkFpoBIPb6VT1HOeU5 6aHvQEm96+D20xatmuZgi4eUTZWMo708Wn3YwQaXSfzdHeeiW4UzGBnMs3G9mocElflrIrrQ/ NE/Po+jF0it17Au0YYAMLBiX29lSez6wsS0xOmxna+L7i9nzrVTGUOcyRluWKOHginOQUGajo HvJ+z+oZs+tGQxWybsYG2xzivMQaR+kY8xgE1n9iXzpYTgiXfIigyKMj+UnQDnQ5YoFvujnl1 +LKHBfNoqCdRbe9c0C2Lw5dJTfMAJ7hiy6S8of90XD3mT79u4OthCe239/SPoKxFjial4XKQ7 C0QMteDbAauUzfxAB5+8siVXLvzaqLC++EVrvy6JYUPwAxY1XQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-07 at 11:27 +0100, Paolo Valente wrote: > > 1. Could you paste a stack trace for this OOPS, just to understand how we > get there? [ 442.421058] kernel BUG at block/bfq-iosched.c:4742! [ 442.421762] invalid opcode: 0000 [#1] SMP PTI [ 442.422436] Dumping ftrace buffer: [ 442.423116] (ftrace buffer empty) [ 442.423785] Modules linked in: fuse(E) ebtable_filter(E) ebtables(E) af_packet(E) bridge(E) stp(E) llc(E) iscsi_ibft(E) iscsi_boot_sysfs(E) nf_conntrack_ipv6(E) nf_defrag_ipv6(E) ipt_REJECT(E) xt_tcpudp(E) iptable_filter(E) ip6table_> [ 442.426685] pcbc(E) iTCO_wdt(E) aesni_intel(E) aes_x86_64(E) iTCO_vendor_support(E) crypto_simd(E) glue_helper(E) mei_me(E) i2c_i801(E) r8169(E) cryptd(E) lpc_ich(E) mfd_core(E) mii(E) mei(E) soundcore(E) pcspkr(E) shpchp(E) thermal> [ 442.429634] dm_multipath(E) dm_mod(E) scsi_dh_rdac(E) scsi_dh_emc(E) scsi_dh_alua(E) scsi_mod(E) efivarfs(E) autofs4(E) [ 442.430166] CPU: 2 PID: 489 Comm: kworker/2:1H Tainted: G E 4.15.0.ga2e5790-master #612 [ 442.430675] Hardware name: MEDION MS-7848/MS-7848, BIOS M7848W08.20C 09/23/2013 [ 442.431195] Workqueue: kblockd blk_mq_requeue_work [ 442.431706] RIP: 0010:bfq_only_requeue_request+0xd1/0xe0 [ 442.432221] RSP: 0018:ffff8803f7b8fcc0 EFLAGS: 00010246 [ 442.432733] RAX: 0000000000002090 RBX: ffff8803dbda2580 RCX: 0000000000000000 [ 442.433250] RDX: ffff8803fa3c8000 RSI: 0000000000000004 RDI: ffff8803dbda2580 [ 442.433778] RBP: ffff8803f9ec85d0 R08: ffff8803fa3c81c0 R09: 0000000000000000 [ 442.434296] R10: ffff8803fa3c81d0 R11: 0000000000001000 R12: ffff8803dbda2600 [ 442.434815] R13: 000000000000000d R14: 0000000000000000 R15: ffff8803f7b8fd88 [ 442.435334] FS: 0000000000000000(0000) GS:ffff88041ec80000(0000) knlGS:0000000000000000 [ 442.435863] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 442.436381] CR2: 00007f00e001e198 CR3: 0000000001e0a002 CR4: 00000000001606e0 [ 442.436909] Call Trace: [ 442.437445] __blk_mq_requeue_request+0x8f/0x120 [ 442.437980] blk_mq_dispatch_rq_list+0x342/0x550 [ 442.438506] ? kyber_dispatch_request+0xd0/0xd0 [ 442.439041] blk_mq_sched_dispatch_requests+0xf7/0x180 [ 442.439568] __blk_mq_run_hw_queue+0x58/0xd0 [ 442.440103] __blk_mq_delay_run_hw_queue+0x99/0xa0 [ 442.440628] blk_mq_run_hw_queue+0x54/0xf0 [ 442.441157] blk_mq_run_hw_queues+0x4b/0x60 [ 442.441822] blk_mq_requeue_work+0x13a/0x150 [ 442.442518] process_one_work+0x147/0x350 [ 442.443205] worker_thread+0x47/0x3e0 [ 442.443887] kthread+0xf8/0x130 [ 442.444579] ? rescuer_thread+0x360/0x360 [ 442.445264] ? kthread_stop+0x120/0x120 [ 442.445965] ? do_syscall_64+0x75/0x1a0 [ 442.446651] ? SyS_exit_group+0x10/0x10 [ 442.447340] ret_from_fork+0x35/0x40 [ 442.448023] Code: ff 4c 89 f6 4c 89 ef e8 be ec 2e 00 48 c7 83 80 00 00 00 00 00 00 00 48 c7 83 88 00 00 00 00 00 00 00 5b 5d 41 5c 41 5d 41 5e c3 <0f> 0b 0f 0b 0f 0b 0f 0b 0f 1f 80 00 00 00 00 0f 1f 44 00 00 41 [ 442.448668] RIP: bfq_only_requeue_request+0xd1/0xe0 RSP: ffff8803f7b8fcc0