Received: by 10.223.176.5 with SMTP id f5csp482320wra; Wed, 7 Feb 2018 02:33:03 -0800 (PST) X-Google-Smtp-Source: AH8x2249bYnUB2m2YwFnQylRe6WZUvtMfDLHlq54aXLE3xTZR78xWBGsA+THtZUbcLNeWI+O3riu X-Received: by 2002:a17:902:b104:: with SMTP id q4-v6mr5717990plr.143.1517999583370; Wed, 07 Feb 2018 02:33:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517999583; cv=none; d=google.com; s=arc-20160816; b=wUXGGvs8Ag/SVTloEz+gp9xVEoNfjw+m0vSoXqB/W0dQSlRoDVuO73/WXpYrYJOxQo Xyh+cQKDDsBPqCmhKpBkgCqhdOK0BmOfUNxlgDjhygKR/FPNtJGyb4VnQOzF5kWxNNPL eooT2ZEgkMmPgwFiqXgyGmeu6lVafNL+YwMIApBwAlTNzZ8vjujtNbCCAV0XSdJD+hkG G5e+dSIxNsUKAKtuHyXjHI0hpoeRr5UU9HWsZweIdObyjSDLWdlYxtQe3+OxOoHzUjdc H/dDXxiyLvHkHxBotQNq1bzLPSxhpdDZmqC9c6FIoZFyvAUV5RLvLHnpGv4//y4ktsJ0 T6ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=RSiYcWABTvoUfFPqfwPaiIlClKhnqMNeMecPugEMA+Q=; b=Um2lREjrcVeVn7bDQQ8BrqJiipcvjdPiFg728H2SCy2v8o0NSvPgMJ0VLz7GasNC2/ 9e8iDPzRyj4xJCFGfLQc9HfS7GozYuWmKhIr4PUgmptuF3Rn13qaXCmTiuPQRL9S058x R+lnA4k6kkZjG/+6hTsAL8nDzgxH1UNHaj0NLaMbBHTf6ML/E2f1YGBHg+UR7GjwvIpX cGviV1HA6hUBGZfWPcFMr8ecmhyFple74ifv7cfUMoBfx0soTb1mm5Cb14kP+swwl/q/ J5yqYgMaIpyZfZxGA4Qc6jLYfgOF+HglaacWa/S7aozg48TNDTk6xWP7ECBByEsbT9iN nBKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=eMsJNVzW; dkim=pass header.i=@codeaurora.org header.s=default header.b=RpH780cr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si770456pge.338.2018.02.07.02.32.49; Wed, 07 Feb 2018 02:33:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=eMsJNVzW; dkim=pass header.i=@codeaurora.org header.s=default header.b=RpH780cr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753857AbeBGKbn (ORCPT + 99 others); Wed, 7 Feb 2018 05:31:43 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40148 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753745AbeBGKbk (ORCPT ); Wed, 7 Feb 2018 05:31:40 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CEA8260A54; Wed, 7 Feb 2018 10:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517999499; bh=6F+qRTFKPQ6wx2d+3XjQMBFxYjkcup1zu6AO/tawn3U=; h=From:To:Cc:Subject:Date:From; b=eMsJNVzWzf05/YaVDed/N9LZTAeHYnBpVdQOoWX90cGfTjm8/yzWHM9PWB45AtUSn kPTEeP2F98dlLXcpmDTFtcyHXIN2r7PqDyrWjWuiHt9CjJgrZPmDivV5ZNWCwwAPIz OCA1lF34goDObM3t40JuTCS5pMZy6yGKaShAISfE= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-41.ap.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B87D8601C4; Wed, 7 Feb 2018 10:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517999497; bh=6F+qRTFKPQ6wx2d+3XjQMBFxYjkcup1zu6AO/tawn3U=; h=From:To:Cc:Subject:Date:From; b=RpH780crcMeZBNSSO91BX6+oxS5UVvgSnKLf8CgUljoenBjUiwFKCt4AgiOSDOxiD o12/E2s1ml8sePiElzgVgtzvc9Wbzi7/oZBu9Ib4hQrY+gYLLZVlnjdm1Hn6fjAIM7 qEBNU9a6QFibFM2TXQeDXln6NMUAEt19V/+M/qwE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B87D8601C4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org From: Vivek Gautam To: joro@8bytes.org, robh+dt@kernel.org, mark.rutland@arm.com, rjw@rjwysocki.net, robin.murphy@arm.com, will.deacon@arm.com, robdclark@gmail.com, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Cc: alex.williamson@redhat.com, gregkh@linuxfoundation.org, airlied@linux.ie, sboyd@codeaurora.org, sricharan@codeaurora.org, m.szyprowski@samsung.com, architt@codeaurora.org, linux-arm-msm@vger.kernel.org, vivek.gautam@codeaurora.org Subject: [PATCH v7 0/6] iommu/arm-smmu: Add runtime pm/sleep support Date: Wed, 7 Feb 2018 16:01:16 +0530 Message-Id: <1517999482-17317-1-git-send-email-vivek.gautam@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series provides the support for turning on the arm-smmu's clocks/power domains using runtime pm. This is done using the recently introduced device links patches, which lets the smmu's runtime to follow the master's runtime pm, so the smmu remains powered only when the masters use it. It also adds support for Qcom's arm-smmu-v2 variant that has different clocks and power requirements. Took some reference from the exynos runtime patches [1]. After much discussion [3] over the use of pm_runtime_get/put() in .unmap op path for the arm-smmu, and after disussing over more than a couple of approaches to address this, we are putting forward the changes *without* using pm_runtime APIs in 'unmap'. Rather, letting the client device take the control of powering on/off the connected iommu through pm_runtime_get(put)_suppliers() APIs for the scnerios when the iommu power can't be directly controlled by clients through device links. Rafael acked the change to export the suppliers APIs. Previous version of this patch series is @ [5]. [v7] * Addressed review comments given by Robin Murphy - -- Added device_link_del() in .remove_device path. -- Error path cleanup in arm_smmu_add_device(). -- Added pm_runtime_get/put_sync() in .remove path, and replaced pm_runtime_force_suspend() with pm_runtime_disable(). -- clk_names cleanup in arm_smmu_init_clks() * Added 'Reviewed-by' given by Rob H. [V6] * Added Ack given by Rafael to first patch in the series. * Addressed Rob Herring's comment for adding soc specific compatible string as well besides 'qcom,smmu-v2'. [V5] * Dropped runtime pm calls from "arm_smmu_unmap" op as discussed over the list [3] for the last patch series. * Added a patch to export pm_runtime_get/put_suppliers() APIs to the series as agreed with Rafael [4]. * Added the related patch for msm drm iommu layer to use pm_runtime_get/put_suppliers() APIs in msm_mmu_funcs. * Dropped arm-mmu500 clock patch since that would break existing platforms. * Changed compatible 'qcom,msm8996-smmu-v2' to 'qcom,smmu-v2' to reflect the IP version rather than the platform on which it is used. The same IP is used across multiple platforms including msm8996, and sdm845 etc. * Using clock bulk APIs to handle the clocks available to the IP as suggested by Stephen Boyd. * The first patch in v4 version of the patch-series: ("iommu/arm-smmu: Fix the error path in arm_smmu_add_device") has already made it to mainline. [V4] * Reworked the clock handling part. We now take clock names as data in the driver for supported compatible versions, and loop over them to get, enable, and disable the clocks. * Using qcom,msm8996 based compatibles for bindings instead of a generic qcom compatible. * Refactor MMU500 patch to just add the necessary clock names data and corresponding bindings. * Added the pm_runtime_get/put() calls in .unmap iommu op (fix added by Stanimir on top of previous patch version. * Added a patch to fix error path in arm_smmu_add_device() * Removed patch 3/5 of V3 patch series that added qcom,smmu-v2 bindings. [V3] * Reworked the patches to keep the clocks init/enabling function separately for each compatible. * Added clocks bindings for MMU40x/500. * Added a new compatible for qcom,smmu-v2 implementation and the clock bindings for the same. * Rebased on top of 4.11-rc1 [V2] * Split the patches little differently. * Addressed comments. * Removed the patch #4 [2] from previous post for arm-smmu context save restore. Planning to post this separately after reworking/addressing Robin's feedback. * Reversed the sequence to disable clocks than enabling. This was required for those cases where the clocks are populated in a dependent order from DT. [1] https://lkml.org/lkml/2016/10/20/70 [2] https://patchwork.kernel.org/patch/9389717/ [3] https://patchwork.kernel.org/patch/9827825/ [4] https://patchwork.kernel.org/patch/10102445/ [5] https://lkml.org/lkml/2018/1/19/217 Sricharan R (3): iommu/arm-smmu: Add pm_runtime/sleep ops iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam (3): base: power: runtime: Export pm_runtime_get/put_suppliers iommu/arm-smmu: Add support for qcom,smmu-v2 variant drm/msm: iommu: Replace runtime calls with runtime suppliers .../devicetree/bindings/iommu/arm,smmu.txt | 43 +++++++ drivers/base/power/runtime.c | 2 + drivers/gpu/drm/msm/msm_iommu.c | 16 +-- drivers/iommu/arm-smmu.c | 127 ++++++++++++++++++++- 4 files changed, 174 insertions(+), 14 deletions(-) -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation