Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 7 Feb 2018 13:51:11 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kangmin Park <l4stpr0gr4m@gmail.com>
Cc:     gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        arnd@arndb.de, linux-kernel@vger.kernel.org, justin@jvreeland.com,
        davem@davemloft.net, hdegoede@redhat.com, hadess@hadess.net,
        joe@perches.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] Resolve RF Type mismatch
Message-ID: <20180207105111.mle4uuq6ywj5yu26@mwanda>
References: <1517932633-7832-1-git-send-email-l4stpr0gr4m@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517932633-7832-1-git-send-email-l4stpr0gr4m@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 07, 2018 at 12:57:13AM +0900, Kangmin Park wrote:
> From: pr0gr4m <l4stpr0gr4m@gmail.com>

No changelog, no sign-off.  Changelogs are required but especially in
this case, it's not immediately obvious what this patch is about.

This patch has unrelated white space changes as well.  Here is how the
rules work:

> -	ODM_1T1R	=	0,
> +	ODM_1T1R		=	0,

This are unrelated.

This white space change is on the same line so that's fine (it's
related).

> -	else if ((rf_type == RF_1T2R) || (rf_type ==RF_2T2R))
> +	else if ((rf_type == RF_1T2R) || (rf_type == RF_2T2R) || (rf_type == RF_2T2R_GREEN))

regards,
dan carpenter