Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 7 Feb 2018 14:09:26 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     l4stpr0gr4m@gmail.com
Cc:     gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        arnd@arndb.de, linux-kernel@vger.kernel.org, justin@jvreeland.com,
        davem@davemloft.net, hdegoede@redhat.com,
        himanshujha199640@gmail.com, hadess@hadess.net, joe@perches.com,
        colin.king@canonical.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] Update rf_type_definition
Message-ID: <20180207110926.dzokcw2dwlinh2io@mwanda>
References: <1517952214-3434-1-git-send-email-l4stpr0gr4m@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517952214-3434-1-git-send-email-l4stpr0gr4m@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This is better.  But the subject should say [PATCH v2] and we need a
driver prefix.

On Wed, Feb 07, 2018 at 06:23:34AM +0900, l4stpr0gr4m@gmail.com wrote:
> From: Kangmin Park <l4stpr0gr4m@gmail.com>
> 
> enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h
> is different from enum tag_HAL_RF_Type_Definition on
> rtl8723bs/include/HalVerDef.h
> 
> So, update them to be the same reference from
> enum rf_type on rtlwifi/wifi.h which recent version.
> 
> As a result, ODM_RF_TYPE_E needs to be updated as well
> Therefore, it is updated reference from enum odm_rf_type
> on rtlwifi/phydm/phydm_pre_define.h too.
> And update some additional code to check more
> chip versions that resulted from it.
> 
> Also, fixed some space required errors and
> line over 80 characters warnings by checkpatch.pl.

Don't do this.  It's considered unrelated white space change and it
makes the code hard to review.

To be honest, I don't know the code well enough to say if this patch is
a good idea generally...  It seems risky and I wish someone would test
it or a maintainer would Ack it.

regards,
dan carpenter