Received: by 10.223.176.5 with SMTP id f5csp529252wra; Wed, 7 Feb 2018 03:23:17 -0800 (PST) X-Google-Smtp-Source: AH8x226iT98zp07akhftcPr1sNrFdqG0N9bZZWCeg7opUTsvKuM2KgaNMKI4iDRMqjjQrGW6sIQs X-Received: by 10.101.68.202 with SMTP id g10mr4780815pgs.210.1518002597240; Wed, 07 Feb 2018 03:23:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518002597; cv=none; d=google.com; s=arc-20160816; b=tdYI6WAkeBN9nlDLPHLXaLUiW1ClFlY9m+XiQ3tJEZvUIbTDJ5wLQ6D2oqjYAEugGS eACT/7LRGIZ2u/ZqQmWuLpA4honv5uaaZQb5zTgk5qouKekdr9Dx0PwxM7mtECXxncdN 112gMwwPwh598t5DEo907jFzxTBtFsbM1MF22lfVvTcDisVYsfLkzWXIEaevJBE6p8Hn iU28E3uAjJF0XqehPgNedVPYT0WZn/u8ivCmD3EMjYTOMrwKp2nUU4a9UoR+CPPZtocr IIfAHV87Edkfbj+0ZA19JmER8Z6ajM3tFQiKRhNYBPvwY4/MrE4BCvDowXqO3dWn+INy LGXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=Um5UKjfStpQcVQMeRadY1SAk40yTyS5XGdc8le7C7IQ=; b=oKEbO+yJo2c43F/1NVkGb2FisX/+wAiCjv5nYKDIp8CIKuFOLKfi31tskfPG2Vu1jg AGhLh4G+E1daOEThtmwzyu06uft6zUBI17EZb35TR/GSqCZU3HprvzdX5B//W4kY0Leg S24khdHSUsP202Bcrfell65mmKBJfFPhJgIvTqrQ4jsVQzb3D/aw/cDbWYgHp+2QtzL3 yySOp5atSyVc2Gu3eg5s8ECZDKe0y70/Z7jxUMI8IjgfeNDULqbgAHNq7QBms90aEhe9 qwDCgsmognvwZHQGVQdyFevCiVv+nejWF8h3vCvHLBvQRtxDbMfQeGaRKP6uUzUoDKwL g9MQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9-v6si937052plk.346.2018.02.07.03.23.02; Wed, 07 Feb 2018 03:23:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753852AbeBGLWQ (ORCPT + 99 others); Wed, 7 Feb 2018 06:22:16 -0500 Received: from mout.gmx.net ([212.227.17.22]:52741 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785AbeBGLWO (ORCPT ); Wed, 7 Feb 2018 06:22:14 -0500 Received: from homer.simpson.net ([185.191.217.115]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LxcbX-1el5uK1dl5-017DZX; Wed, 07 Feb 2018 12:22:03 +0100 Message-ID: <1518002521.29698.14.camel@gmx.de> Subject: Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook From: Mike Galbraith To: Paolo Valente Cc: Oleksandr Natalenko , Jens Axboe , linux-block , Linux Kernel Mailing List , Ulf Hansson , Mark Brown , Linus Walleij , 'Paolo Valente' via bfq-iosched , Alban Browaeys , Ming Lei , Ivan Kozik , SERENA ZIVIANI <169364@studenti.unimore.it>, Serena Ziviani , Holger =?ISO-8859-1?Q?Hoffst=E4tte?= Date: Wed, 07 Feb 2018 12:22:01 +0100 In-Reply-To: References: <20180205190510.5499-1-paolo.valente@linaro.org> <20180205190510.5499-2-paolo.valente@linaro.org> <1517903761.9843.12.camel@gmx.de> <899B68CC-5955-4418-8BFF-DC55A743A61B@linaro.org> <1517918234.25841.31.camel@gmx.de> <77124223e6116350a5184a5199850304@natalenko.name> <1517924768.25841.32.camel@gmx.de> <8842084cc8a26b7f46ae600bda8a7bd0@natalenko.name> <82ffc96aacc3945861cbb708df346338@natalenko.name> <1517995431.25619.5.camel@gmx.de> <1517998516.6606.1.camel@gmx.de> <5584030F-8F4E-4C98-84A5-79873A1BF775@linaro.org> <1518001397.29698.6.camel@gmx.de> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ZK/4X6VykiYty7bM3bRExopZrQsDejyBSvx+cb9cWGsmj3V1txG +MHj64WOhaa6XKKDPn9esITZhaMW2gUPzrNSllHrpTykMH7GMp+rY2WD/k9v9y2G05gtEXW Tx8EG7zTo130MZvwFJAQozTwOe9Ri5Vgc3eloOckjy0K/LIck+GFsWQokSDv+7S6MXBvP2C LQ/bi5CWDI0F+bjiknWiQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mV8Qaxpka3o=:zLmswbO26vu7BsDBcBj74N n3R+yll2TVYj9khAf5hzSpjHgM/LSXOOao1O/nt2bzOdqqCptG8FZVqX8md4sEG8BcStMel9w vPSodFcw4gTyTcaGOf9We9i+cR+So/Odv5n1YLOj4h1W/jGQYBLtrdZ5E9fvWJ19mgSizYf04 CO5fRpvyEnreyZ9kFcEf+8ZFTHYGq0dwAZn0VmDMbHwd3C/qd8j6ZSUH1bUEpUvHMMTgjA+vW OvoIqQPpoayL7CyJ4TDAv/HtOPAQZlvNWAVl15Hb3rCQFKS/v/UrTPLbDuuRBIDhnIheBJ4Kj yE6B25YBQeEK817iLtb4UeHSWmCTRx0CZG7fMEtcA6c29eMxGA/5tNz7vUdXgY38Hjqv7TERH MOUmvlvlXVTeD4JMCZhkPedL8mJdgMf365GXf9YbmCR6yIbnq+QeHuIAuR+4VaIcOY6qhOI+L pnOz2Wrb+4wimKcBXYAthudBjFC6TsBEXQtsxHIqRNiGR5fGnxYPieh+yzSsfb0RxUxsazfu6 bso9W5SgmU3rEBi8T++vFmMsOx+ZOjcn6miUdBZf4Wtrv9YBmRGZQbYPTkeYz9q4EIq346qEG Dqcv44tN5gMtOm2Dc08SdxkMCkbNNLXOaQYpD60vZPH3cNg8V2X80qmpyQA/1NdT7HObFr2yb YrNdphHgTa4jIHmB9QAiix1UYCE6wQq8GC/38n/ZOcSmxbArv1BcjLa0/XOQ/hqoshGKh6GxA 9h32KebzXT9Z6dG6+NDmFyEQWL4djGrRxigsO7E0YwcYs8VHWfTtNYPcnlpisNR0zLWhUyvne KC5+S44i0CyUMAbXmCJmMavWRjYJqcSTxCBJYts8lIk5YiNWfo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-07 at 12:12 +0100, Paolo Valente wrote: > Just to be certain, before submitting a new patch: you changed *only* > the BUG_ON at line 4742, on top of my instrumentation patch. Nah, I completely rewrite it with only a little help from an ouija board to compensate for missing (all) knowledge wrt BFQ internals. (iow yeah, I did exactly and only what I was asked to do:)