Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1517975986-46917-1-git-send-email-xieyisheng1@huawei.com>
References: <1517975986-46917-1-git-send-email-xieyisheng1@huawei.com>
From:   Sumit Semwal <sumit.semwal@linaro.org>
Date:   Wed, 7 Feb 2018 20:05:03 +0530
Message-ID: <CAO_48GFoqYt1nkGdTstQ-wappnN6tkGqXCBcRViCu74Y4bWa2g@mail.gmail.com>
Subject: Re: [PATCH 1/2] staging: android: ion: Cleanup ion_page_pool_alloc_pages
To:     Yisheng Xie <xieyisheng1@huawei.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Laura Abbott <labbott@redhat.com>, devel@driverdev.osuosl.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Yisheng,

On 7 February 2018 at 09:29, Yisheng Xie <xieyisheng1@huawei.com> wrote:
> ion_page_pool_alloc_pages calls alloc_pages to allocate pages for page
> pools. If alloc_pages return NULL, it will return NULL, or it will
> return the pages allocate from alloc_pages. So we can just return
> alloc_pages without any judgement.
>
With patch history comment addressed (same as the other patch you sent),
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Please feel free to add my
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>

> ---
>  drivers/staging/android/ion/ion_page_pool.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> index e3a6e32..6d2caf0 100644
> --- a/drivers/staging/android/ion/ion_page_pool.c
> +++ b/drivers/staging/android/ion/ion_page_pool.c
> @@ -11,13 +11,9 @@
>
>  #include "ion.h"
>
> -static void *ion_page_pool_alloc_pages(struct ion_page_pool *pool)
> +static inline struct page *ion_page_pool_alloc_pages(struct ion_page_pool *pool)
>  {
> -       struct page *page = alloc_pages(pool->gfp_mask, pool->order);
> -
> -       if (!page)
> -               return NULL;
> -       return page;
> +       return alloc_pages(pool->gfp_mask, pool->order);
>  }
>
>  static void ion_page_pool_free_pages(struct ion_page_pool *pool,
> --
> 1.7.12.4
>
Best,
Sumit.