Received: by 10.223.176.5 with SMTP id f5csp790179wra; Wed, 7 Feb 2018 07:36:03 -0800 (PST) X-Google-Smtp-Source: AH8x225ofzarerGu1JA5D25PCJgmRfIGqS62RdAa17O+9qgDrSdd/354FyOYhAcHVJp/BN/YFF8/ X-Received: by 2002:a17:902:9a9:: with SMTP id 38-v6mr6330590pln.202.1518017762970; Wed, 07 Feb 2018 07:36:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518017762; cv=none; d=google.com; s=arc-20160816; b=UrO6bOQQX6t9HDm64IUdZlJfsUkBy1KY7UK2EYXNabq2ECXLViLRcc3fRrxUIETIYa M/62ULJLKQhH2u7BJ3+n7iH4YmOmAWr+gxpvV01sNHN53+AUGXLHf6GKMw1K/6W77oo+ f7Ph8Ovt0Lpb7a4khw7bUi77HRFkm4ZLTwTtAiwZzDuJawi0uE1dQ4KmYMDR2MdbugcO GGhZwHS02d7YpQYjcI1YhKpa5/6h+PVlkTq+QGp1cc2tqMGwC+VOxiiv+aUot3WXXmvl oFWdb6U7//R1yotcxihoSEE1dfd0lquEZhDZq1Jy3DVbjiVkgW11EpyatfJdXQAtIuO2 CGRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=//E1Gd9m7vTafVORD+xQFMmCHUJOyl++xKC/3zGThzc=; b=aEVk72xxh55EYbrXUtTGEMa0Ok+IlA2C8DpgTniIJW8SmcPlq0ZFTqhx7tVPbgQQdt d8Tl/2t3Lu4S3Jvz3XHDu3jOZc9mlKJV09OJL9Rw9aA73y5+WOEbbZtpCboQu9Qtw1N5 kxf3XJM3gQNL3hJHudgPGL1pNHFBRk/HR96pp3yd8jVVCF7oSESXploV9N/cXzJ/8NVM +mQsoI87nAovX9aOb5owr+Di9rboPMT4CErkmzk47vL8IPb6eVsNlL6rsz6zyfSp5DqN 5okzGxPmk+STDKjjK6ZFvz1MyR5wJjBx4IqpcqlfR3yQf4m5C7bNfOeXUpdmB1F6ra9d YNLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e21si735142pga.146.2018.02.07.07.35.48; Wed, 07 Feb 2018 07:36:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbeBGPfG (ORCPT + 99 others); Wed, 7 Feb 2018 10:35:06 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:47333 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754091AbeBGPfF (ORCPT ); Wed, 7 Feb 2018 10:35:05 -0500 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w17FXrAN013816; Wed, 7 Feb 2018 16:34:46 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2fxmgpmcfg-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 07 Feb 2018 16:34:46 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 96E683A; Wed, 7 Feb 2018 15:34:44 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7767C5781; Wed, 7 Feb 2018 15:34:44 +0000 (GMT) Received: from localhost (10.75.127.47) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 7 Feb 2018 16:34:43 +0100 From: Pierre-Yves MORDRET To: Wolfram Sang , Maxime Coquelin , Alexandre Torgue , , , CC: Pierre-Yves MORDRET Subject: [PATCH] i2c: i2c-stm32f7: fix no check on returned setup Date: Wed, 7 Feb 2018 16:34:38 +0100 Message-ID: <1518017678-10283-1-git-send-email-pierre-yves.mordret@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG4NODE2.st.com (10.75.127.11) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-07_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before assigning returned setup structure check if not null Fixes: 463a9215f3ca7600b5ff ("i2c: stm32f7: fix setup structure") Signed-off-by: Pierre-Yves MORDRET --- Version history: v1: * Initial --- --- drivers/i2c/busses/i2c-stm32f7.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index b445b3b..16c7d77 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -888,6 +888,10 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) } setup = of_device_get_match_data(&pdev->dev); + if (!setup) { + dev_err(&pdev->dev, "Can't get device data\n"); + goto clk_free; + } i2c_dev->setup = *setup; ret = device_property_read_u32(i2c_dev->dev, "i2c-scl-rising-time-ns", -- 2.7.4