Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272165AbTG2VNZ (ORCPT ); Tue, 29 Jul 2003 17:13:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272160AbTG2VLM (ORCPT ); Tue, 29 Jul 2003 17:11:12 -0400 Received: from pasmtp.tele.dk ([193.162.159.95]:46347 "EHLO pasmtp.tele.dk") by vger.kernel.org with ESMTP id S272221AbTG2VJT (ORCPT ); Tue, 29 Jul 2003 17:09:19 -0400 Date: Tue, 29 Jul 2003 23:09:16 +0200 From: Sam Ravnborg To: yiding_wang@agilent.com Cc: linux-kernel@vger.kernel.org, Kai Germaschewski Subject: Re: 2.5.x module make questions Message-ID: <20030729210916.GA20154@mars.ravnborg.org> Mail-Followup-To: yiding_wang@agilent.com, linux-kernel@vger.kernel.org, Kai Germaschewski References: <334DD5C2ADAB9245B60F213F49C5EBCD05D55239@axcs03.cos.agilent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <334DD5C2ADAB9245B60F213F49C5EBCD05D55239@axcs03.cos.agilent.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2339 Lines: 57 On Tue, Jul 29, 2003 at 02:45:35PM -0600, yiding_wang@agilent.com wrote: > Team, > > I have two questions regarding kbuild. > 1, According to doc., makefile can do descending. Could make carry ascending? Kbuild is not designed to support ascending, and I do not think it is possible to tweak it to do so. If you manage to tweak kbuild to support it do not complain if it breakes. This is not intended neither supported. > 2, Does old style of makefile still work (it should according to the article of "Driver porting: compiling external module")? What Corbet suggest in the referenced doc is to have the following: ifndef KERNELRELEASE here goes old style Makefile else here goes Kbuild makefile endif And this is _only_ the topmost makefile. And the oldstyle part is only to make it simple to do make -C kernelsrcdir SUBDIRS=$PWD modules kbuild does not support old-style Makefiles, but fragments are supported. May I request you to read Documentation/kbuild/makefiles.txt - this is an up-to-date description of what kbuild supports, and what syntax to use. The most complex examples of use in the kernel today is some of the arch Makefiles. Maybe they can help you? > export TOPDIR > export CFLAGS > > all : ag.o > > ag.o: ../../../../t/s/ts.o ../../../f/c/fc.o ../../../f/i/fi.o s/sl.o > ld -r -o ag.o ../../../../t/s/ts.o ../../../f/c/fc.o ../../../f/i/fi.o s/sl.o This looks really ugly. I do not expect kbuild to even get close to help you here. kbuild is designed around the idea that objects are built directory-by-directory, and in the upper level directory the are linked. What you have surely does not follow that principle. > Any suggestion is welcomed. If the kbuild cannot do ascending, I have to change the source tree structure but that is the least I want to do. This is my best suggestion. Follow the normal way of doing things in the kernel make it easier/possible to use the infrastructure provided by the kernel. PS. Please also read the paper by Kai Germashewski from OLS - see www.linuxsymposium.org - it provide good background info on kbuild. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/