Received: by 10.223.176.5 with SMTP id f5csp929744wra; Wed, 7 Feb 2018 09:46:08 -0800 (PST) X-Google-Smtp-Source: AH8x225DhYPPvYD0cisvf3YHN9KvqRQ3wL8xo5mBHcidA8f4myXtzWz3ecjjeMIzs5ZGsuP6vHKq X-Received: by 10.98.11.201 with SMTP id 70mr6745353pfl.16.1518025568831; Wed, 07 Feb 2018 09:46:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518025568; cv=none; d=google.com; s=arc-20160816; b=mhWiEJCPP2ahqd3uMWf7NXBsFuqFlmMj7NUOVlUx+u8VB0nX1Zdbtu4DrV9X1St4R7 Zm/PHMjFY5jy5Q14gUQDhToo4aa4kY8SwH20f5PeQBd5vshMWuHb6czMHQTxQjf8YQQp iYfTjZ0uKhTFMp0j8EElD6+Xp6IekKnJc8heH6k+tokhuUk/vC8peLmmskSmhgnlMKCF azWtElZoDym1cdD5ahqIuzxoN4wHOspbd6s1QJrga+gT4xBazBloGBPtbQwPaM7YR6OX EJJYdtvXiWv/H3Lne1RkhPcd7ddDFVEzVX3fOo/+HAC46BOAVMCIGYczMHuBKuONca6S IznQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=zWLNw3gIaPXcRD2ypHyN34QTCrAMJh4qXUaca1oL2aY=; b=rtj96P4vV3JCZ4jFKOWs4Lt0LLPibX1dad4YSpCSJBeIAe1/EhqrzYTe3AmamY4fcu ZUQ5gmdoJlK1L6qcnFRw6x/052uwKYyRyjrACxlS5USr/Oo1RrNMe7lI2vwv9MBdBUT6 GzqJztKVQmw/4/jVMGyA6SZXtoxRQWVWerUNYr92HIrfRicJY6ov+hXmGPQVOLatvRdg sN9NaxvhUwLZbnml1QeFKQMYgBR8mmq/8ZKzezkxGheGFxEFiOPFmdv6iHzZ8ksA0juK yMnGsG7X2NtKeVTab8fovL978K1eIN5MMR0CymR4YDmBcqsEpNRtGCfsK/sxfktYwoFA CvGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j4si1200992pgf.585.2018.02.07.09.45.54; Wed, 07 Feb 2018 09:46:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692AbeBGRor (ORCPT + 99 others); Wed, 7 Feb 2018 12:44:47 -0500 Received: from mail.us.es ([193.147.175.20]:47704 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754429AbeBGRoo (ORCPT ); Wed, 7 Feb 2018 12:44:44 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4AA273066BA for ; Wed, 7 Feb 2018 18:44:43 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 389F5DA246 for ; Wed, 7 Feb 2018 18:44:43 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 368FDDA245; Wed, 7 Feb 2018 18:44:43 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.0 required=7.5 tests=ALL_TRUSTED,BAYES_50, HEADER_FROM_DIFFERENT_DOMAINS,SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D64E3DA3AC; Wed, 7 Feb 2018 18:44:40 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 07 Feb 2018 18:44:40 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (129.166.216.87.static.jazztel.es [87.216.166.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 5BACB41E4805; Wed, 7 Feb 2018 18:44:40 +0100 (CET) Date: Wed, 7 Feb 2018 18:44:39 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Michal Hocko Cc: Andrew Morton , Andrea Arcangeli , Yang Shi , Tetsuo Handa , netdev , guro@fb.com, LKML , Ingo Molnar , syzkaller-bugs@googlegroups.com, Linux-MM , coreteam@netfilter.org, netfilter-devel@vger.kernel.org, "Kirill A. Shutemov" , David Rientjes , "Kirill A. Shutemov" , David Miller , Dmitry Vyukov Subject: Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2) Message-ID: <20180207174439.esm4djxb4trbotne@salvia> References: <20180129182811.fze4vrb5zd5cojmr@node.shutemov.name> <20180129223522.GG5906@breakpoint.cc> <20180130075226.GL21609@dhcp22.suse.cz> <20180130081127.GH5906@breakpoint.cc> <20180130082817.cbax5qj4mxancx4b@node.shutemov.name> <20180130095739.GV21609@dhcp22.suse.cz> <20180130140104.GE21609@dhcp22.suse.cz> <20180130112745.934883e37e696ab7f875a385@linux-foundation.org> <20180131081916.GO21609@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180131081916.GO21609@dhcp22.suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jan 31, 2018 at 09:19:16AM +0100, Michal Hocko wrote: [...] > Yeah, we do not BUG but rather fail instead. See __vmalloc_node_range. > My excavation tools pointed me to "VM: Rework vmalloc code to support mapping of arbitray pages" > by Christoph back in 2002. So yes, we can safely remove it finally. Se > below. > > > From 8d52e1d939d101b0dafed6ae5c3c1376183e65bb Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Wed, 31 Jan 2018 09:16:56 +0100 > Subject: [PATCH] net/netfilter/x_tables.c: remove size check > > Back in 2002 vmalloc used to BUG on too large sizes. We are much better > behaved these days and vmalloc simply returns NULL for those. Remove > the check as it simply not needed and the comment even misleading. > > Suggested-by: Andrew Morton > Signed-off-by: Michal Hocko > --- > net/netfilter/x_tables.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c > index b55ec5aa51a6..48a6ff620493 100644 > --- a/net/netfilter/x_tables.c > +++ b/net/netfilter/x_tables.c > @@ -999,10 +999,6 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size) > if (sz < sizeof(*info)) > return NULL; > > - /* Pedantry: prevent them from hitting BUG() in vmalloc.c --RR */ > - if ((SMP_ALIGN(size) >> PAGE_SHIFT) + 2 > totalram_pages) > - return NULL; > - > /* __GFP_NORETRY is not fully supported by kvmalloc but it should > * work reasonably well if sz is too large and bail out rather > * than shoot all processes down before realizing there is nothing Patchwork didn't catch this patch for some reason, would you mind to resend? Thanks!