Received: by 10.223.176.5 with SMTP id f5csp1165412wra; Wed, 7 Feb 2018 13:58:47 -0800 (PST) X-Google-Smtp-Source: AH8x225C6S1AJQEaVnUcHmfPHdgA7RV5jKGHiXyjnTgP2WPUJdKU0KL4EZSjHMTjilhleyVKBjrV X-Received: by 2002:a17:902:a03:: with SMTP id 3-v6mr7457195plo.282.1518040726914; Wed, 07 Feb 2018 13:58:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518040726; cv=none; d=google.com; s=arc-20160816; b=ptCcQEJ+gZE0fSb3EiHnrowd7p25/eS3AtKE+XVONgwYD0Mv3hSs8+LoH/Y+pXSBOA wljCzXVSrf8Bd/LKRe1quWYHn6cm/un68fYdIvpVIFw4CpZkQeMLlp+y0buuGwupQXls ijeG7Tdl+8PqtsQv84YpVh1NSy6ZdVF/JJeNG6Jz7pKL6q0ONEHIlgnxGhcfSlra/X2y RCqAvoaetJfGEPkr+0BeAOBPOLX9bt0JQvEFHRW7Samuli0KgJnpwp8vru1qWCTHKHNw pWfS+0N+HhxxU0qW0TWGyfewPNc08XqXimzdFJsA2UNhAf8QQaBIm4m6FiYsJWZl5TYQ H05w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature:arc-authentication-results; bh=+3JvWWN7bOSuAFhnIEkLDzQqJaROPb+1mhFVa7KgSw8=; b=iJrvRF/fHJMlnXLFhdgiwq5uth+24Uy74nPDruJM95HOdR5Y/6dizW1KNPJEy365we SAS6KvPB+8WGnkb47rEES3hjL5c8mCxG1Yme+lYxXly5IXJ1A81Q4rGIqpW3gLxksuWP HyBOHt/pRjIV5LDY0To5ivPtfpv0CnnCBC1XzAv1DeISw3woGfFsxgWeJ8kdw6WmWJZP BjpT8Zki/mjAdmkoZ4kpQszS9v2svVDC/QpKUbhZyiG3oBjrkvpKArr9uWBnA0ypc1zt 0iJW3TN3NtCv6D8PBuZYCptVKQVg7c+RI/8/L210y94QkC1K0+56G6yJrkzlejyB7WK+ /45g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=X3dPMYeM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=android.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 69-v6si59318pla.156.2018.02.07.13.58.32; Wed, 07 Feb 2018 13:58:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=X3dPMYeM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=android.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750807AbeBGV5x (ORCPT + 99 others); Wed, 7 Feb 2018 16:57:53 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:41284 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbeBGV5w (ORCPT ); Wed, 7 Feb 2018 16:57:52 -0500 Received: by mail-pl0-f67.google.com with SMTP id k8-v6so888492pli.8 for ; Wed, 07 Feb 2018 13:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=from:to:subject:date:message-id; bh=+3JvWWN7bOSuAFhnIEkLDzQqJaROPb+1mhFVa7KgSw8=; b=X3dPMYeMw3ZNDL588fvnyN7sU7mNt1TYcafe3tomSNDKhGMmEGS8VHekP1XBsD7TIV +gJI9Jb0d+/WfWAI0YO+vvkHy8dOp2HLZIemIX6CnUXLC5JZsYSpRPoXDlTwk4C+Z2hE v0PIEz37H4o0QsMtRDZKoKvLDmEldSo8C6lvazO8DlYkTrswodyvOycfhaU29yyV8ssV +8d3WlDksTrLirWctuQqQM+nxbT7ISO/NwFP8RCpX5aDb0wjW5bJLiw4EtKkxVvDwwSj PM7pqUnAuxlWgsPEASjaUDOkla8sOQ5Dhq9JYJ60OB7KmWkmxL/msz0ODtLp9A+e3uSA bLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=+3JvWWN7bOSuAFhnIEkLDzQqJaROPb+1mhFVa7KgSw8=; b=agKLQWvdHfTuFL/hBRyAFhm3SxDw/ECNZCjVBWIbgWCqAXdE6buyQ/H67k/jOMnYVe MISgADGZ7LjFqsdd9lKKoIQurjEa68KJ7bq7KWDOY7r5++fvFqZZigxf/fWd7IJd/Up7 LKRRpy41sun/ecCfUk50swNIckkab3CML9ehczAvleUgJV0/oHOww3q6qGb9kCkk6xri RoZLU85bCJwADtslw4H5/MCtW6JvDzrGmUdASLZitbCenmWjgodfNWb7AAR28/woyiEN n84Hb0IgT5W2v2bcy/OUKHBp55kPU5iml8UBbV9qOfo7O0XLM9KghZ5esqtXZueak8zz Qdeg== X-Gm-Message-State: APf1xPCjLz00FlZdg5q6s5FX2ZsN4FEtkWvq2Gfyav2i1c8C3oJBLKYl R/aXHWUMcC6im9RFLrbtum1SAQ== X-Received: by 2002:a17:902:b28a:: with SMTP id u10-v6mr7225378plr.241.1518040671921; Wed, 07 Feb 2018 13:57:51 -0800 (PST) Received: from ava-linux2.mtv.corp.google.com ([2620:0:1000:1601:c21a:5723:1a47:e4a4]) by smtp.googlemail.com with ESMTPSA id s5sm8544346pfg.29.2018.02.07.13.57.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2018 13:57:51 -0800 (PST) From: Todd Kjos X-Google-Original-From: Todd Kjos To: tkjos@google.com, gregkh@linuxfoundation.org, arve@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, maco@google.com Subject: [PATCH] binder: replace "%p" with "%pK" Date: Wed, 7 Feb 2018 13:57:37 -0800 Message-Id: <20180207215737.251082-1-tkjos@google.com> X-Mailer: git-send-email 2.16.0.rc1.238.g530d649a79-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The format specifier "%p" can leak kernel addresses. Use "%pK" instead. There were 4 remaining cases in binder.c. Signed-off-by: Todd Kjos --- drivers/android/binder.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 37289683939c..7da09b10dae8 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -2141,7 +2141,7 @@ static void binder_transaction_buffer_release(struct binder_proc *proc, int debug_id = buffer->debug_id; binder_debug(BINDER_DEBUG_TRANSACTION, - "%d buffer release %d, size %zd-%zd, failed at %p\n", + "%d buffer release %d, size %zd-%zd, failed at %pK\n", proc->pid, buffer->debug_id, buffer->data_size, buffer->offsets_size, failed_at); @@ -3653,7 +3653,7 @@ static int binder_thread_write(struct binder_proc *proc, } } binder_debug(BINDER_DEBUG_DEAD_BINDER, - "%d:%d BC_DEAD_BINDER_DONE %016llx found %p\n", + "%d:%d BC_DEAD_BINDER_DONE %016llx found %pK\n", proc->pid, thread->pid, (u64)cookie, death); if (death == NULL) { @@ -4968,7 +4968,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m, spin_lock(&t->lock); to_proc = t->to_proc; seq_printf(m, - "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d", + "%s %d: %pK from %d:%d to %d:%d code %x flags %x pri %ld r%d", prefix, t->debug_id, t, t->from ? t->from->proc->pid : 0, t->from ? t->from->pid : 0, @@ -4992,7 +4992,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m, } if (buffer->target_node) seq_printf(m, " node %d", buffer->target_node->debug_id); - seq_printf(m, " size %zd:%zd data %p\n", + seq_printf(m, " size %zd:%zd data %pK\n", buffer->data_size, buffer->offsets_size, buffer->data); } -- 2.16.0.rc1.238.g530d649a79-goog