Received: by 10.223.176.5 with SMTP id f5csp1214864wra; Wed, 7 Feb 2018 14:59:26 -0800 (PST) X-Google-Smtp-Source: AH8x2242zIFXmF/shcY4SUp/D10Jl5k3+6Jmg1knlk2aFMfdByazyOv29/hVB0161BihEgNEKKyC X-Received: by 2002:a17:902:2843:: with SMTP id e61-v6mr7616881plb.260.1518044366301; Wed, 07 Feb 2018 14:59:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518044366; cv=none; d=google.com; s=arc-20160816; b=BIkOgH8qABFB0DDGQzmqCdfpxqxNSm2jytWMQu65en55aIGYEq1j9ITP8xJ0gbh373 NZvEevHvS0fp7EPV2owdQoCPg2ytM+9DZpO+0p2JyvrXcaDEKrikkmIJ7n3IzlbrctOg +LGXRu/d097p2tMqWEuWaoc9AyqwS/1Yb1GA0ob9RPokOysxPyCdiPdoOvc6a1DPuTBm 096ozKyajYdrdAKpitapD0pLHAGXnpdf9fWBTMhmp+MaClwLSHH/Cp55ymcMrLGncLBv hgkGge42go5yPHkpntSPG7aaTqi+0aqnFMtCMkWS3myw3eDirqDgwwaFRsFvZfj2pNMS 56pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=wxDFiwxfY5te41mvtoIzmEozKYHMAhgwtM5tLV3QBEY=; b=DWaEBwrfnJ2Q3W9gzbA2I5NqD5cT3th4XQB5hd3aGjIFnR5IB8gcI//Itn+8wLBHMQ NkIz8QVKAwcLbqgPkc7c0Eb8IVFR59QZqPrR2Ypec4Dot9vWejfDtNO8ynAq+fcoRXcf OCVh02QVtBNGLMcdixUKqZoIMABk6BK6+bGh5M0L/9yP+KlIeiBVJAiqwm6swR364I+I U92n+lCrpSwPIOMJrwEspPVni0GfXWcb5hvMCUcp/J7dEVs2xEasEkLUguIK119ad+zb isqcbxtD73JApooAS+8EC7WB/gPCyHQq1FQ7pQwBssf+6PpG0Vinpv6x4OQhiMI2Tgdu 2CWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si201008plo.446.2018.02.07.14.59.12; Wed, 07 Feb 2018 14:59:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbeBGW4o (ORCPT + 99 others); Wed, 7 Feb 2018 17:56:44 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43236 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbeBGW4n (ORCPT ); Wed, 7 Feb 2018 17:56:43 -0500 Received: from localhost (65-114-90-19.dia.static.qwest.net [65.114.90.19]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7D437CD0; Wed, 7 Feb 2018 22:56:29 +0000 (UTC) Date: Wed, 7 Feb 2018 16:56:28 -0600 From: Greg KH To: Todd Kjos Cc: tkjos@google.com, arve@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, maco@google.com Subject: Re: [PATCH] binder: replace "%p" with "%pK" Message-ID: <20180207225628.GC10647@kroah.com> References: <20180207215737.251082-1-tkjos@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180207215737.251082-1-tkjos@google.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 07, 2018 at 01:57:37PM -0800, Todd Kjos wrote: > The format specifier "%p" can leak kernel addresses. Use > "%pK" instead. There were 4 remaining cases in binder.c. Luckily this isn't an issue in mainline as we don't print %p values out anymore as of 4.15. That being said, this is a good fix and I'll queue it up after 4.16-rc1 is out, thanks. greg k-h