Received: by 10.223.176.5 with SMTP id f5csp1302990wra; Wed, 7 Feb 2018 16:53:49 -0800 (PST) X-Google-Smtp-Source: AH8x2262V8DaMddV08EaiaZwaaDp/Jsh2+Po3HKAFawADL4dS0n/TzxU/o26nlQBd2YEadLaO2t+ X-Received: by 2002:a17:902:860b:: with SMTP id f11-v6mr7970614plo.135.1518051229687; Wed, 07 Feb 2018 16:53:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518051229; cv=none; d=google.com; s=arc-20160816; b=Ru4UCjjMddNlgNyT4lvsLJOR70IStib2PiljZOWUnW6G0U0Fxgp0y/kRF08xa62ih8 cBAnhwLpe5XmFljdHc1ul60btTln8BnffQfb/ht0c6d1D+hbifAu5CYl7qtMOiCrLNa/ 9E1Hvj3uYsDKWvnHo5qXeaaW6/fGjo2a9IEeJjWlXXP1h4pqO1oYOzDLamOfYGuYS9zd fXztVcTjcnkr3PPepocobXBvpP84kCK5fuBjoX4FaPuSmQEcoqZ4q7ONsWCZ6sFhD50n rwL0xCYmM/s0fWp1JiXp37pOVt8SMjbN8Zc9dqGlD6XFO/Q16YDEohrDm0iuZ+gfUNmq /oiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Tja/CojyG797/VmcEMEa7C0Qghpz9Pr3/+CqP+6Nmhc=; b=QGiCjjAKVQ1r+iHhWRfXDMlsd4oSLogNj95kKgRgWmd75JztwOF0yv53IVblb0MM75 Zk+gkGhkaV2vDJpo9atoDshKuzGjxFz+ZAn4H30gd+rxU21oqk/jN6LuSRzdPXMGg82E rKRtdtx/xE3zG/k1rtG9+1h7GdxJUn3z3YiX8FZoHq36FM3IZymNrcqzR4Xsj4Dl9yqh 1HXCgUoYHt65rGlljng3BdyuLCZcteAwqnAetHpGhke+0UZD6scufv1kRPTDOiQB+/7O 9HCUJMN+9/AGBWZPi3qCsUPudDuz+8ZvirGDCw8rjhvt9iwK6tjzFJP4m8EzMijy5h1O eizw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=P7L3k7TI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si42240pgs.832.2018.02.07.16.53.35; Wed, 07 Feb 2018 16:53:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=P7L3k7TI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbeBHAwz (ORCPT + 99 others); Wed, 7 Feb 2018 19:52:55 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:45481 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbeBHAwx (ORCPT ); Wed, 7 Feb 2018 19:52:53 -0500 Received: by mail-pl0-f67.google.com with SMTP id p5-v6so1150798plo.12 for ; Wed, 07 Feb 2018 16:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Tja/CojyG797/VmcEMEa7C0Qghpz9Pr3/+CqP+6Nmhc=; b=P7L3k7TI0B4jAATQGEV21bsvdV+qIjnqqOo/BePQd3hIWWlYaOlncJ5g8lBYEdH6L2 DtaJcyxddRiMVza6iDQGI7bVFWlkDEzVFsJGxp9HT5bvvnEjVKXW51LMQ1VReXrx6BTv 3gB9J7RkEwcB1qXFd2QlpQqs66DEnNDdj2hzDQKoWLhRay5H1F5WUH4eF0wpT4zOtjUj UeUi2Dvpa6TqBlTAuafFgmjVueAsAQjkwQ+LIcjV73liLvnp2haAokf9wjRKbb/91okl sHrAbgnebwB9UDfB1ynB4UOi0sMnu1zYM0mpBMbQSGqg+kghmGMInXoKQ7tHBQi6bd36 5qDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Tja/CojyG797/VmcEMEa7C0Qghpz9Pr3/+CqP+6Nmhc=; b=s4wrdt/gR0ahzRyVwyN3jKHntzvtIcnwPHMUeUQAtLcjrkGKMcKsm7m2oKQpFii4Lg WOvHMicvHD7ZOGLbn3+aecg1ELn6Y4IZVS880kkMidCuwLmSl8op3Qqrg6BNHxJR7q2e 97P3/uHWoUIyYZjhJLX4tJqjswlVz4tURq+M+tJ6SDby9LTd2ihS+3pyHxkoMaY0bZkf AQNtPKXdNqmUzcfJH04aiAn8ku5O42oD7Gnryya0VjJ0BFqAI07n1wbNXyllMMGFC5lr AgswQHbZAS21JM4892ta2sMCQJ+foqAiZnM7hxdL6GxQ1JbogNpCXX8RZVBFNWqz/BPe YDRw== X-Gm-Message-State: APf1xPDHt8TH7HaXTwkh+V+yB0cP1X0B1jZLC18vnbwN20gDGZzj7JWK PDHay1caykln8rqGqENxN00= X-Received: by 2002:a17:902:241:: with SMTP id 59-v6mr7813644plc.280.1518051173253; Wed, 07 Feb 2018 16:52:53 -0800 (PST) Received: from 75c3b24ef355 (36-226-155-58.dynamic-ip.hinet.net. [36.226.155.58]) by smtp.gmail.com with ESMTPSA id n80sm6410261pfj.79.2018.02.07.16.52.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 16:52:52 -0800 (PST) Date: Thu, 8 Feb 2018 08:52:47 +0800 From: Alan Kao To: Palmer Dabbelt Cc: albert@sifive.com, rostedt@goodmis.org, mingo@redhat.com, yamada.masahiro@socionext.com, n54@gmx.com, akpm@linux-foundation.org, patches@groups.riscv.org, linux-kernel@vger.kernel.org, sorear2@gmail.com, alankao@andestech.com, greentime@andestech.com Subject: Re: [patches] [PATCH v3 0/6] Add dynamic ftrace support for RISC-V platforms Message-ID: <20180208005245.GA26140@75c3b24ef355> References: <20180118154545.17987-1-alankao@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 07, 2018 at 04:37:10PM -0800, Palmer Dabbelt wrote: > On Thu, 18 Jan 2018 07:45:39 PST (-0800), nonerkao@gmail.com wrote: > > This patch set includes the building blocks of dynamic ftrace features > > for RISC-V machines. > > > > Changes in v3: > > - Replace the nops at the tracer call sites into a "call ftrace_stub" > > instruction for better understanding (1/6 and 2/6) > > > > Changes in v2: > > - Fix the return value as writing to kernel text goes wrong (2/6) > > - Replace manual comparisons by calling memcmp (2/6) > > - Simplify the conditional assignment in the Makefile (1/6) > > > > Alan Kao (6): > > riscv/ftrace: Add RECORD_MCOUNT support > > riscv/ftrace: Add dynamic function tracer support > > riscv/ftrace: Add dynamic function graph tracer support > > riscv/ftrace: Add ARCH_SUPPORTS_FTRACE_OPS support > > riscv/ftrace: Add DYNAMIC_FTRACE_WITH_REGS support > > riscv/ftrace: Add HAVE_FUNCTION_GRAPH_RET_ADDR_PTR support > > > > arch/riscv/Kconfig | 3 + > > arch/riscv/Makefile | 3 + > > arch/riscv/include/asm/ftrace.h | 47 ++++++++ > > arch/riscv/kernel/Makefile | 5 +- > > arch/riscv/kernel/ftrace.c | 142 ++++++++++++++++++++++- > > arch/riscv/kernel/mcount-dyn.S | 241 ++++++++++++++++++++++++++++++++++++++++ > > arch/riscv/kernel/mcount.S | 22 ++-- > > arch/riscv/kernel/stacktrace.c | 6 + > > scripts/recordmcount.pl | 5 + > > 9 files changed, 461 insertions(+), 13 deletions(-) > > create mode 100644 arch/riscv/kernel/mcount-dyn.S > > Sorry it took me a while to get around to these. Do you mind submitting a > v4 that's based on linux-4.15? I'm getting all sorts of merge errors trying > to "git am" these. Sure. But do you mean the riscv-linux-4.15 at the github repo or Linus's linux-4.15-rc......,says, rc8? Also, we have fixed our internal email server issue, so I will send this v4 set using alankao@andestech.com, by which I signed off all previous ftrace patches, instead of the current gmail one. I hope this won't be confusing to you. Thanks, Alan